All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel@redhat.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christoph Hellwig <hch@infradead.org>,
	"Darrick J. Wong" <djwong@kernel.org>,
	Paul Mackerras <paulus@ozlabs.org>, Jan Kara <jack@suse.cz>,
	Matthew Wilcox <willy@infradead.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	ocfs2-devel@oss.oracle.com, kvm-ppc@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	Andreas Gruenbacher <agruenba@redhat.com>,
	stable@vger.kernel.org
Subject: [PATCH v9 02/17] powerpc/kvm: Fix kvm_use_magic_page
Date: Tue,  2 Nov 2021 13:29:30 +0100	[thread overview]
Message-ID: <20211102122945.117744-3-agruenba@redhat.com> (raw)
In-Reply-To: <20211102122945.117744-1-agruenba@redhat.com>

When switching from __get_user to fault_in_pages_readable, commit
9f9eae5ce717 broke kvm_use_magic_page: like __get_user,
fault_in_pages_readable returns 0 on success.

Fixes: 9f9eae5ce717 ("powerpc/kvm: Prefer fault_in_pages_readable function")
Cc: stable@vger.kernel.org # v4.18+
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 arch/powerpc/kernel/kvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/kvm.c b/arch/powerpc/kernel/kvm.c
index 617eba82531c..d89cf802d9aa 100644
--- a/arch/powerpc/kernel/kvm.c
+++ b/arch/powerpc/kernel/kvm.c
@@ -669,7 +669,7 @@ static void __init kvm_use_magic_page(void)
 	on_each_cpu(kvm_map_magic_page, &features, 1);
 
 	/* Quick self-test to see if the mapping works */
-	if (!fault_in_pages_readable((const char *)KVM_MAGIC_PAGE, sizeof(u32))) {
+	if (fault_in_pages_readable((const char *)KVM_MAGIC_PAGE, sizeof(u32))) {
 		kvm_patching_worked = false;
 		return;
 	}
-- 
2.31.1


WARNING: multiple messages have this Message-ID (diff)
From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel@redhat.com
Cc: kvm-ppc@vger.kernel.org, Paul Mackerras <paulus@ozlabs.org>,
	Jan Kara <jack@suse.cz>,
	Andreas Gruenbacher <agruenba@redhat.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, stable@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH v9 02/17] powerpc/kvm: Fix kvm_use_magic_page
Date: Tue,  2 Nov 2021 13:29:30 +0100	[thread overview]
Message-ID: <20211102122945.117744-3-agruenba@redhat.com> (raw)
In-Reply-To: <20211102122945.117744-1-agruenba@redhat.com>

When switching from __get_user to fault_in_pages_readable, commit
9f9eae5ce717 broke kvm_use_magic_page: like __get_user,
fault_in_pages_readable returns 0 on success.

Fixes: 9f9eae5ce717 ("powerpc/kvm: Prefer fault_in_pages_readable function")
Cc: stable@vger.kernel.org # v4.18+
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 arch/powerpc/kernel/kvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/kvm.c b/arch/powerpc/kernel/kvm.c
index 617eba82531c..d89cf802d9aa 100644
--- a/arch/powerpc/kernel/kvm.c
+++ b/arch/powerpc/kernel/kvm.c
@@ -669,7 +669,7 @@ static void __init kvm_use_magic_page(void)
 	on_each_cpu(kvm_map_magic_page, &features, 1);
 
 	/* Quick self-test to see if the mapping works */
-	if (!fault_in_pages_readable((const char *)KVM_MAGIC_PAGE, sizeof(u32))) {
+	if (fault_in_pages_readable((const char *)KVM_MAGIC_PAGE, sizeof(u32))) {
 		kvm_patching_worked = false;
 		return;
 	}
-- 
2.31.1


_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

WARNING: multiple messages have this Message-ID (diff)
From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v9 02/17] powerpc/kvm: Fix kvm_use_magic_page
Date: Tue,  2 Nov 2021 13:29:30 +0100	[thread overview]
Message-ID: <20211102122945.117744-3-agruenba@redhat.com> (raw)
In-Reply-To: <20211102122945.117744-1-agruenba@redhat.com>

When switching from __get_user to fault_in_pages_readable, commit
9f9eae5ce717 broke kvm_use_magic_page: like __get_user,
fault_in_pages_readable returns 0 on success.

Fixes: 9f9eae5ce717 ("powerpc/kvm: Prefer fault_in_pages_readable function")
Cc: stable at vger.kernel.org # v4.18+
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 arch/powerpc/kernel/kvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/kvm.c b/arch/powerpc/kernel/kvm.c
index 617eba82531c..d89cf802d9aa 100644
--- a/arch/powerpc/kernel/kvm.c
+++ b/arch/powerpc/kernel/kvm.c
@@ -669,7 +669,7 @@ static void __init kvm_use_magic_page(void)
 	on_each_cpu(kvm_map_magic_page, &features, 1);
 
 	/* Quick self-test to see if the mapping works */
-	if (!fault_in_pages_readable((const char *)KVM_MAGIC_PAGE, sizeof(u32))) {
+	if (fault_in_pages_readable((const char *)KVM_MAGIC_PAGE, sizeof(u32))) {
 		kvm_patching_worked = false;
 		return;
 	}
-- 
2.31.1



WARNING: multiple messages have this Message-ID (diff)
From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel@redhat.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christoph Hellwig <hch@infradead.org>,
	"Darrick J. Wong" <djwong@kernel.org>,
	Paul Mackerras <paulus@ozlabs.org>, Jan Kara <jack@suse.cz>,
	Matthew Wilcox <willy@infradead.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	ocfs2-devel@oss.oracle.com, kvm-ppc@vger.kernel.org,
	linux-btrfs@vger.kernel.org,
	Andreas Gruenbacher <agruenba@redhat.com>,
	stable@vger.kernel.org
Subject: [PATCH v9 02/17] powerpc/kvm: Fix kvm_use_magic_page
Date: Tue, 02 Nov 2021 12:29:30 +0000	[thread overview]
Message-ID: <20211102122945.117744-3-agruenba@redhat.com> (raw)
In-Reply-To: <20211102122945.117744-1-agruenba@redhat.com>

When switching from __get_user to fault_in_pages_readable, commit
9f9eae5ce717 broke kvm_use_magic_page: like __get_user,
fault_in_pages_readable returns 0 on success.

Fixes: 9f9eae5ce717 ("powerpc/kvm: Prefer fault_in_pages_readable function")
Cc: stable@vger.kernel.org # v4.18+
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 arch/powerpc/kernel/kvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/kvm.c b/arch/powerpc/kernel/kvm.c
index 617eba82531c..d89cf802d9aa 100644
--- a/arch/powerpc/kernel/kvm.c
+++ b/arch/powerpc/kernel/kvm.c
@@ -669,7 +669,7 @@ static void __init kvm_use_magic_page(void)
 	on_each_cpu(kvm_map_magic_page, &features, 1);
 
 	/* Quick self-test to see if the mapping works */
-	if (!fault_in_pages_readable((const char *)KVM_MAGIC_PAGE, sizeof(u32))) {
+	if (fault_in_pages_readable((const char *)KVM_MAGIC_PAGE, sizeof(u32))) {
 		kvm_patching_worked = false;
 		return;
 	}
-- 
2.31.1

  parent reply	other threads:[~2021-11-02 12:30 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02 12:29 [PATCH v9 00/17] gfs2: Fix mmap + page fault deadlocks Andreas Gruenbacher
2021-11-02 12:29 ` Andreas Gruenbacher
2021-11-02 12:29 ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` [PATCH v9 01/17] iov_iter: Fix iov_iter_get_pages{,_alloc} page fault return value Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] [PATCH v9 01/17] iov_iter: Fix iov_iter_get_pages{, _alloc} " Andreas Gruenbacher
2021-11-02 12:29   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` Andreas Gruenbacher [this message]
2021-11-02 12:29   ` [PATCH v9 02/17] powerpc/kvm: Fix kvm_use_magic_page Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` [PATCH v9 03/17] gup: Turn fault_in_pages_{readable,writeable} into fault_in_{readable,writeable} Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] [PATCH v9 03/17] gup: Turn fault_in_pages_{readable, writeable} into fault_in_{readable, writeable} Andreas Gruenbacher
2021-11-02 12:29   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` [PATCH v9 04/17] iov_iter: Turn iov_iter_fault_in_readable into fault_in_iov_iter_readable Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-04 18:22   ` Catalin Marinas
2021-11-04 18:22     ` Catalin Marinas
2021-11-04 18:22     ` [Cluster-devel] " Catalin Marinas
2021-11-04 18:22     ` [Ocfs2-devel] " Catalin Marinas
2021-11-04 20:31     ` Andreas Gruenbacher
2021-11-04 20:31       ` Andreas Gruenbacher
2021-11-04 20:31       ` [Cluster-devel] " Andreas Gruenbacher
2021-11-04 20:31       ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` [PATCH v9 05/17] iov_iter: Introduce fault_in_iov_iter_writeable Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` [PATCH v9 06/17] gfs2: Add wrapper for iomap_file_buffered_write Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` [PATCH v9 07/17] gfs2: Clean up function may_grant Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` [Ocfs2-devel] [PATCH v9 08/17] gfs2: Introduce flag for glock holder auto-demotion Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29 ` [Ocfs2-devel] [PATCH v9 09/17] gfs2: Move the inode glock locking to gfs2_file_buffered_write Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29 ` [PATCH v9 10/17] gfs2: Eliminate ip->i_gh Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` [PATCH v9 11/17] gfs2: Fix mmap + page fault deadlocks for buffered I/O Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` [PATCH v9 12/17] iomap: Fix iomap_dio_rw return value for user copies Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` [PATCH v9 13/17] iomap: Support partial direct I/O on user copy failures Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` [PATCH v9 14/17] iomap: Add done_before argument to iomap_dio_rw Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` [PATCH v9 15/17] gup: Introduce FOLL_NOFAULT flag to disable page faults Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` [PATCH v9 16/17] iov_iter: Introduce nofault " Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29   ` [Ocfs2-devel] " Andreas Gruenbacher
2021-11-02 12:29 ` [PATCH v9 17/17] gfs2: Fix mmap + page fault deadlocks for direct I/O Andreas Gruenbacher
2021-11-02 12:29   ` Andreas Gruenbacher
2021-11-02 12:29   ` [Cluster-devel] " Andreas Gruenbacher
2021-11-02 12:29   ` [Ocfs2-devel] " Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211102122945.117744-3-agruenba@redhat.com \
    --to=agruenba@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=cluster-devel@redhat.com \
    --cc=djwong@kernel.org \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=paulus@ozlabs.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.