From: Chaitanya Kulkarni <chaitanyak@nvidia.com> To: <linux-block@vger.kernel.org>, <linux-raid@vger.kernel.org>, <linux-nvme@lists.infradead.org>, <linux-scsi@vger.kernel.org>, <target-devel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>, <linux-xfs@vger.kernel.org>, <dm-devel@redhat.com> Cc: <axboe@kernel.dk>, <agk@redhat.com>, <snitzer@redhat.com>, <song@kernel.org>, <djwong@kernel.org>, <kbusch@kernel.org>, <hch@lst.de>, <sagi@grimberg.me>, <jejb@linux.ibm.com>, <martin.petersen@oracle.com>, <viro@zeniv.linux.org.uk>, <javier@javigon.com>, <johannes.thumshirn@wdc.com>, <bvanassche@acm.org>, <dongli.zhang@oracle.com>, <ming.lei@redhat.com>, <osandov@fb.com>, <willy@infradead.org>, <jefflexu@linux.alibaba.com>, <josef@toxicpanda.com>, <clm@fb.com>, <dsterba@suse.com>, <jack@suse.com>, <tytso@mit.edu>, <adilger.kernel@dilger.ca>, <jlayton@kernel.org>, <idryomov@gmail.com>, <danil.kipnis@cloud.ionos.com>, <ebiggers@google.com>, <jinpu.wang@cloud.ionos.com>, Chaitanya Kulkarni <kch@nvidia.com> Subject: [PATCH 4/8] nvmet: add Verify command support for bdev-ns Date: Wed, 3 Nov 2021 23:46:30 -0700 [thread overview] Message-ID: <20211104064634.4481-5-chaitanyak@nvidia.com> (raw) In-Reply-To: <20211104064634.4481-1-chaitanyak@nvidia.com> From: Chaitanya Kulkarni <kch@nvidia.com> Add support for handling verify command on target. Call into __blkdev_issue_verify, which the block layer expands into the REQ_OP_VERIFY LBAs. Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com> --- drivers/nvme/target/admin-cmd.c | 3 ++- drivers/nvme/target/io-cmd-bdev.c | 39 +++++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c index 613a4d8feac1..87cad64895e6 100644 --- a/drivers/nvme/target/admin-cmd.c +++ b/drivers/nvme/target/admin-cmd.c @@ -408,7 +408,8 @@ static void nvmet_execute_identify_ctrl(struct nvmet_req *req) id->nn = cpu_to_le32(ctrl->subsys->max_nsid); id->mnan = cpu_to_le32(NVMET_MAX_NAMESPACES); id->oncs = cpu_to_le16(NVME_CTRL_ONCS_DSM | - NVME_CTRL_ONCS_WRITE_ZEROES); + NVME_CTRL_ONCS_WRITE_ZEROES | + NVME_CTRL_ONCS_VERIFY); /* XXX: don't report vwc if the underlying device is write through */ id->vwc = NVME_CTRL_VWC_PRESENT; diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c index ec45e597084b..5a888cdadfea 100644 --- a/drivers/nvme/target/io-cmd-bdev.c +++ b/drivers/nvme/target/io-cmd-bdev.c @@ -128,6 +128,7 @@ static u16 blk_to_nvme_status(struct nvmet_req *req, blk_status_t blk_sts) switch (req->cmd->common.opcode) { case nvme_cmd_dsm: case nvme_cmd_write_zeroes: + case nvme_cmd_verify: status = NVME_SC_ONCS_NOT_SUPPORTED | NVME_SC_DNR; break; default: @@ -153,6 +154,10 @@ static u16 blk_to_nvme_status(struct nvmet_req *req, blk_status_t blk_sts) req->error_slba = le64_to_cpu(req->cmd->write_zeroes.slba); break; + case nvme_cmd_verify: + req->error_slba = + le64_to_cpu(req->cmd->verify.slba); + break; default: req->error_slba = 0; } @@ -428,6 +433,37 @@ static void nvmet_bdev_execute_write_zeroes(struct nvmet_req *req) } } +static void nvmet_bdev_execute_verify(struct nvmet_req *req) +{ + struct nvme_verify_cmd *verify = &req->cmd->verify; + struct bio *bio = NULL; + sector_t nr_sector; + sector_t sector; + int ret; + + if (!nvmet_check_transfer_len(req, 0)) + return; + + if (!bdev_verify_sectors(req->ns->bdev)) { + nvmet_req_complete(req, NVME_SC_INTERNAL | NVME_SC_DNR); + return; + } + + sector = le64_to_cpu(verify->slba) << (req->ns->blksize_shift - 9); + nr_sector = (((sector_t)le16_to_cpu(verify->length) + 1) << + (req->ns->blksize_shift - 9)); + + ret = __blkdev_issue_verify(req->ns->bdev, sector, nr_sector, + GFP_KERNEL, &bio); + if (bio) { + bio->bi_private = req; + bio->bi_end_io = nvmet_bio_done; + submit_bio(bio); + } else { + nvmet_req_complete(req, errno_to_nvme_status(req, ret)); + } +} + u16 nvmet_bdev_parse_io_cmd(struct nvmet_req *req) { struct nvme_command *cmd = req->cmd; @@ -448,6 +484,9 @@ u16 nvmet_bdev_parse_io_cmd(struct nvmet_req *req) case nvme_cmd_write_zeroes: req->execute = nvmet_bdev_execute_write_zeroes; return 0; + case nvme_cmd_verify: + req->execute = nvmet_bdev_execute_verify; + return 0; default: pr_err("unhandled cmd %d on qid %d\n", cmd->common.opcode, req->sq->qid); -- 2.22.1
WARNING: multiple messages have this Message-ID (diff)
From: Chaitanya Kulkarni <chaitanyak@nvidia.com> To: <linux-block@vger.kernel.org>, <linux-raid@vger.kernel.org>, <linux-nvme@lists.infradead.org>, <linux-scsi@vger.kernel.org>, <target-devel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>, <linux-xfs@vger.kernel.org>, <dm-devel@redhat.com> Cc: snitzer@redhat.com, ebiggers@google.com, djwong@kernel.org, clm@fb.com, adilger.kernel@dilger.ca, osandov@fb.com, agk@redhat.com, javier@javigon.com, sagi@grimberg.me, dongli.zhang@oracle.com, willy@infradead.org, hch@lst.de, danil.kipnis@cloud.ionos.com, idryomov@gmail.com, jinpu.wang@cloud.ionos.com, Chaitanya Kulkarni <kch@nvidia.com>, jejb@linux.ibm.com, josef@toxicpanda.com, ming.lei@redhat.com, dsterba@suse.com, viro@zeniv.linux.org.uk, jefflexu@linux.alibaba.com, bvanassche@acm.org, axboe@kernel.dk, tytso@mit.edu, martin.petersen@oracle.com, song@kernel.org, johannes.thumshirn@wdc.com, jlayton@kernel.org, kbusch@kernel.org, jack@suse.com Subject: [dm-devel] [PATCH 4/8] nvmet: add Verify command support for bdev-ns Date: Wed, 3 Nov 2021 23:46:30 -0700 [thread overview] Message-ID: <20211104064634.4481-5-chaitanyak@nvidia.com> (raw) In-Reply-To: <20211104064634.4481-1-chaitanyak@nvidia.com> From: Chaitanya Kulkarni <kch@nvidia.com> Add support for handling verify command on target. Call into __blkdev_issue_verify, which the block layer expands into the REQ_OP_VERIFY LBAs. Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com> --- drivers/nvme/target/admin-cmd.c | 3 ++- drivers/nvme/target/io-cmd-bdev.c | 39 +++++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c index 613a4d8feac1..87cad64895e6 100644 --- a/drivers/nvme/target/admin-cmd.c +++ b/drivers/nvme/target/admin-cmd.c @@ -408,7 +408,8 @@ static void nvmet_execute_identify_ctrl(struct nvmet_req *req) id->nn = cpu_to_le32(ctrl->subsys->max_nsid); id->mnan = cpu_to_le32(NVMET_MAX_NAMESPACES); id->oncs = cpu_to_le16(NVME_CTRL_ONCS_DSM | - NVME_CTRL_ONCS_WRITE_ZEROES); + NVME_CTRL_ONCS_WRITE_ZEROES | + NVME_CTRL_ONCS_VERIFY); /* XXX: don't report vwc if the underlying device is write through */ id->vwc = NVME_CTRL_VWC_PRESENT; diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c index ec45e597084b..5a888cdadfea 100644 --- a/drivers/nvme/target/io-cmd-bdev.c +++ b/drivers/nvme/target/io-cmd-bdev.c @@ -128,6 +128,7 @@ static u16 blk_to_nvme_status(struct nvmet_req *req, blk_status_t blk_sts) switch (req->cmd->common.opcode) { case nvme_cmd_dsm: case nvme_cmd_write_zeroes: + case nvme_cmd_verify: status = NVME_SC_ONCS_NOT_SUPPORTED | NVME_SC_DNR; break; default: @@ -153,6 +154,10 @@ static u16 blk_to_nvme_status(struct nvmet_req *req, blk_status_t blk_sts) req->error_slba = le64_to_cpu(req->cmd->write_zeroes.slba); break; + case nvme_cmd_verify: + req->error_slba = + le64_to_cpu(req->cmd->verify.slba); + break; default: req->error_slba = 0; } @@ -428,6 +433,37 @@ static void nvmet_bdev_execute_write_zeroes(struct nvmet_req *req) } } +static void nvmet_bdev_execute_verify(struct nvmet_req *req) +{ + struct nvme_verify_cmd *verify = &req->cmd->verify; + struct bio *bio = NULL; + sector_t nr_sector; + sector_t sector; + int ret; + + if (!nvmet_check_transfer_len(req, 0)) + return; + + if (!bdev_verify_sectors(req->ns->bdev)) { + nvmet_req_complete(req, NVME_SC_INTERNAL | NVME_SC_DNR); + return; + } + + sector = le64_to_cpu(verify->slba) << (req->ns->blksize_shift - 9); + nr_sector = (((sector_t)le16_to_cpu(verify->length) + 1) << + (req->ns->blksize_shift - 9)); + + ret = __blkdev_issue_verify(req->ns->bdev, sector, nr_sector, + GFP_KERNEL, &bio); + if (bio) { + bio->bi_private = req; + bio->bi_end_io = nvmet_bio_done; + submit_bio(bio); + } else { + nvmet_req_complete(req, errno_to_nvme_status(req, ret)); + } +} + u16 nvmet_bdev_parse_io_cmd(struct nvmet_req *req) { struct nvme_command *cmd = req->cmd; @@ -448,6 +484,9 @@ u16 nvmet_bdev_parse_io_cmd(struct nvmet_req *req) case nvme_cmd_write_zeroes: req->execute = nvmet_bdev_execute_write_zeroes; return 0; + case nvme_cmd_verify: + req->execute = nvmet_bdev_execute_verify; + return 0; default: pr_err("unhandled cmd %d on qid %d\n", cmd->common.opcode, req->sq->qid); -- 2.22.1 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-11-04 6:48 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-04 6:46 [RFC PATCH 0/8] block: add support for REQ_OP_VERIFY Chaitanya Kulkarni 2021-11-04 6:46 ` [dm-devel] " Chaitanya Kulkarni 2021-11-04 6:46 ` [RFC PATCH 1/8] " Chaitanya Kulkarni 2021-11-04 6:46 ` [dm-devel] " Chaitanya Kulkarni 2021-11-04 17:25 ` Darrick J. Wong 2021-11-04 17:25 ` [dm-devel] " Darrick J. Wong 2021-11-11 8:01 ` Chaitanya Kulkarni 2021-11-11 8:01 ` [dm-devel] " Chaitanya Kulkarni 2021-11-04 6:46 ` [RFC PATCH 2/8] scsi: add REQ_OP_VERIFY support Chaitanya Kulkarni 2021-11-04 6:46 ` [dm-devel] " Chaitanya Kulkarni 2021-11-04 12:33 ` Damien Le Moal 2021-11-04 12:33 ` [dm-devel] " Damien Le Moal 2021-11-11 8:07 ` Chaitanya Kulkarni 2021-11-11 8:07 ` [dm-devel] " Chaitanya Kulkarni 2021-11-04 6:46 ` [RFC PATCH 3/8] nvme: add support for the Verify command Chaitanya Kulkarni 2021-11-04 6:46 ` [dm-devel] " Chaitanya Kulkarni 2021-11-04 22:44 ` Keith Busch 2021-11-04 22:44 ` [dm-devel] " Keith Busch 2021-11-11 8:09 ` Chaitanya Kulkarni 2021-11-11 8:09 ` [dm-devel] " Chaitanya Kulkarni 2021-11-04 6:46 ` Chaitanya Kulkarni [this message] 2021-11-04 6:46 ` [dm-devel] [PATCH 4/8] nvmet: add Verify command support for bdev-ns Chaitanya Kulkarni 2021-11-04 6:46 ` [RFC PATCH 5/8] nvmet: add Verify emulation " Chaitanya Kulkarni 2021-11-04 6:46 ` [dm-devel] " Chaitanya Kulkarni 2021-11-04 6:46 ` [RFC PATCH 6/8] nvmet: add verify emulation support for file-ns Chaitanya Kulkarni 2021-11-04 6:46 ` [dm-devel] " Chaitanya Kulkarni 2021-11-04 6:46 ` [RFC PATCH 7/8] null_blk: add REQ_OP_VERIFY support Chaitanya Kulkarni 2021-11-04 6:46 ` [dm-devel] " Chaitanya Kulkarni 2021-11-04 6:46 ` [RFC PATCH 8/8] md: add support for REQ_OP_VERIFY Chaitanya Kulkarni 2021-11-04 6:46 ` [dm-devel] " Chaitanya Kulkarni 2021-11-11 8:13 ` Chaitanya Kulkarni 2021-11-11 8:13 ` [dm-devel] " Chaitanya Kulkarni 2021-11-12 15:19 ` Mike Snitzer 2021-11-12 15:19 ` [dm-devel] " Mike Snitzer 2021-11-04 7:14 ` [RFC PATCH 0/8] block: " Christoph Hellwig 2021-11-04 7:14 ` [dm-devel] " Christoph Hellwig 2021-11-04 9:27 ` Chaitanya Kulkarni 2021-11-04 9:27 ` [dm-devel] " Chaitanya Kulkarni 2021-11-04 17:32 ` Darrick J. Wong 2021-11-04 17:32 ` [dm-devel] " Darrick J. Wong 2021-11-04 17:34 ` Christoph Hellwig 2021-11-04 17:34 ` [dm-devel] " Christoph Hellwig 2021-11-04 22:37 ` Keith Busch 2021-11-04 22:37 ` [dm-devel] " Keith Busch 2021-11-05 8:25 ` javier 2021-11-05 8:25 ` [dm-devel] " javier 2021-11-11 8:18 ` Chaitanya Kulkarni 2021-11-11 8:18 ` [dm-devel] " Chaitanya Kulkarni 2021-11-04 15:16 ` Douglas Gilbert 2021-11-04 15:16 ` [dm-devel] " Douglas Gilbert 2021-11-11 8:27 ` Chaitanya Kulkarni 2021-11-11 8:27 ` [dm-devel] " Chaitanya Kulkarni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211104064634.4481-5-chaitanyak@nvidia.com \ --to=chaitanyak@nvidia.com \ --cc=adilger.kernel@dilger.ca \ --cc=agk@redhat.com \ --cc=axboe@kernel.dk \ --cc=bvanassche@acm.org \ --cc=clm@fb.com \ --cc=danil.kipnis@cloud.ionos.com \ --cc=djwong@kernel.org \ --cc=dm-devel@redhat.com \ --cc=dongli.zhang@oracle.com \ --cc=dsterba@suse.com \ --cc=ebiggers@google.com \ --cc=hch@lst.de \ --cc=idryomov@gmail.com \ --cc=jack@suse.com \ --cc=javier@javigon.com \ --cc=jefflexu@linux.alibaba.com \ --cc=jejb@linux.ibm.com \ --cc=jinpu.wang@cloud.ionos.com \ --cc=jlayton@kernel.org \ --cc=johannes.thumshirn@wdc.com \ --cc=josef@toxicpanda.com \ --cc=kbusch@kernel.org \ --cc=kch@nvidia.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=linux-raid@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=ming.lei@redhat.com \ --cc=osandov@fb.com \ --cc=sagi@grimberg.me \ --cc=snitzer@redhat.com \ --cc=song@kernel.org \ --cc=target-devel@vger.kernel.org \ --cc=tytso@mit.edu \ --cc=viro@zeniv.linux.org.uk \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.