All of lore.kernel.org
 help / color / mirror / Atom feed
From: Warner Losh <imp@bsdimp.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Kyle Evans <kevans@freebsd.org>,
	Michael Tokarev <mjt@tls.msk.ru>,
	Laurent Vivier <laurent@vivier.eu>,
	Philippe Mathieu-Daude <f4bug@amsat.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	Warner Losh <imp@bsdimp.com>
Subject: [PATCH v5 11/37] bsd-user/x86_64: Move functions into signal.c
Date: Sun,  7 Nov 2021 20:51:10 -0700	[thread overview]
Message-ID: <20211108035136.43687-12-imp@bsdimp.com> (raw)
In-Reply-To: <20211108035136.43687-1-imp@bsdimp.com>

Move the current inline functions into sigal.c. This will increate the
flexibility of implementation in the future.

Signed-off-by: Warner Losh <imp@bsdimp.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
 bsd-user/x86_64/signal.c             | 56 +++++++++++++++++++++++++++-
 bsd-user/x86_64/target_arch_signal.h | 43 ++++-----------------
 2 files changed, 63 insertions(+), 36 deletions(-)

diff --git a/bsd-user/x86_64/signal.c b/bsd-user/x86_64/signal.c
index ac90323365..8885152a7d 100644
--- a/bsd-user/x86_64/signal.c
+++ b/bsd-user/x86_64/signal.c
@@ -1 +1,55 @@
-/* Placeholder for signal.c */
+/*
+ *  x86_64 signal definitions
+ *
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 2 of the License, or
+ *  (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "qemu.h"
+
+/*
+ * Compare to amd64/amd64/machdep.c sendsig()
+ * Assumes that target stack frame memory is locked.
+ */
+abi_long set_sigtramp_args(CPUX86State *regs,
+        int sig, struct target_sigframe *frame, abi_ulong frame_addr,
+        struct target_sigaction *ka)
+{
+    /* XXX return -TARGET_EOPNOTSUPP; */
+    return 0;
+}
+
+/* Compare to amd64/amd64/machdep.c get_mcontext() */
+abi_long get_mcontext(CPUX86State *regs,
+                target_mcontext_t *mcp, int flags)
+{
+    /* XXX */
+    return -TARGET_EOPNOTSUPP;
+}
+
+/* Compare to amd64/amd64/machdep.c set_mcontext() */
+abi_long set_mcontext(CPUX86State *regs,
+        target_mcontext_t *mcp, int srflag)
+{
+    /* XXX */
+    return -TARGET_EOPNOTSUPP;
+}
+
+abi_long get_ucontext_sigreturn(CPUX86State *regs,
+        abi_ulong target_sf, abi_ulong *target_uc)
+{
+    /* XXX */
+    *target_uc = 0;
+    return -TARGET_EOPNOTSUPP;
+}
diff --git a/bsd-user/x86_64/target_arch_signal.h b/bsd-user/x86_64/target_arch_signal.h
index 720e3939c3..b39b70466e 100644
--- a/bsd-user/x86_64/target_arch_signal.h
+++ b/bsd-user/x86_64/target_arch_signal.h
@@ -96,40 +96,13 @@ struct target_sigframe {
     uint32_t    __spare__[2];
 };
 
-/*
- * Compare to amd64/amd64/machdep.c sendsig()
- * Assumes that target stack frame memory is locked.
- */
-static inline abi_long set_sigtramp_args(CPUX86State *regs,
-        int sig, struct target_sigframe *frame, abi_ulong frame_addr,
-        struct target_sigaction *ka)
-{
-    /* XXX return -TARGET_EOPNOTSUPP; */
-    return 0;
-}
-
-/* Compare to amd64/amd64/machdep.c get_mcontext() */
-static inline abi_long get_mcontext(CPUX86State *regs,
-                target_mcontext_t *mcp, int flags)
-{
-    /* XXX */
-    return -TARGET_EOPNOTSUPP;
-}
-
-/* Compare to amd64/amd64/machdep.c set_mcontext() */
-static inline abi_long set_mcontext(CPUX86State *regs,
-        target_mcontext_t *mcp, int srflag)
-{
-    /* XXX */
-    return -TARGET_EOPNOTSUPP;
-}
-
-static inline abi_long get_ucontext_sigreturn(CPUX86State *regs,
-        abi_ulong target_sf, abi_ulong *target_uc)
-{
-    /* XXX */
-    *target_uc = 0;
-    return -TARGET_EOPNOTSUPP;
-}
+abi_long set_sigtramp_args(CPUX86State *env, int sig,
+                           struct target_sigframe *frame,
+                           abi_ulong frame_addr,
+                           struct target_sigaction *ka);
+abi_long get_mcontext(CPUX86State *regs, target_mcontext_t *mcp, int flags);
+abi_long set_mcontext(CPUX86State *regs, target_mcontext_t *mcp, int srflag);
+abi_long get_ucontext_sigreturn(CPUX86State *regs, abi_ulong target_sf,
+                                abi_ulong *target_uc);
 
 #endif /* !TARGET_ARCH_SIGNAL_H_ */
-- 
2.33.0



  parent reply	other threads:[~2021-11-08  3:58 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08  3:50 [PATCH v5 00/37] bsd-user: arm (32-bit) support Warner Losh
2021-11-08  3:51 ` [PATCH v5 01/37] bsd-user/mips*: Remove mips support Warner Losh
2021-12-13 10:11   ` Philippe Mathieu-Daudé
2021-11-08  3:51 ` [PATCH v5 02/37] bsd-user/freebsd: Create common target_os_ucontext.h file Warner Losh
2021-11-08  3:51 ` [PATCH v5 03/37] bsd-user: create a per-arch signal.c file Warner Losh
2021-11-08  3:51 ` [PATCH v5 04/37] bsd-user/i386/target_arch_signal.h: Remove target_sigcontext Warner Losh
2021-11-08  3:51 ` [PATCH v5 05/37] bsd-user/i386/target_arch_signal.h: use new target_os_ucontext.h Warner Losh
2021-11-08  3:51 ` [PATCH v5 06/37] bsd-user/i386/target_arch_signal.h: Update mcontext_t to match FreeBSD Warner Losh
2021-11-08  3:51 ` [PATCH v5 07/37] bsd-user/i386: Move the inlines into signal.c Warner Losh
2021-11-08  3:51 ` [PATCH v5 08/37] bsd-user/x86_64/target_arch_signal.h: Remove target_sigcontext Warner Losh
2021-11-08  3:51 ` [PATCH v5 09/37] bsd-user/x86_64/target_arch_signal.h: use new target_os_ucontext.h Warner Losh
2021-11-08  3:51 ` [PATCH v5 10/37] bsd-user/x86_64/target_arch_signal.h: Fill in mcontext_t Warner Losh
2021-11-08  3:51 ` Warner Losh [this message]
2021-11-08  3:51 ` [PATCH v5 12/37] bsd-user/target_os_signal.h: Move signal prototypes to target_os_ucontext.h Warner Losh
2021-11-08  3:51 ` [PATCH v5 13/37] bsd-user/arm/target_arch_sysarch.h: Use consistent include guards Warner Losh
2021-11-08  3:51 ` [PATCH v5 14/37] bsd-user/arm/target_syscall.h: Add copyright and update name Warner Losh
2021-11-08  3:51 ` [PATCH v5 15/37] bsd-user/arm/target_arch_cpu.c: Target specific TLS routines Warner Losh
2021-11-08  3:51 ` [PATCH v5 16/37] bsd-user/arm/target_arch_cpu.h: CPU Loop definitions Warner Losh
2021-11-08  3:51 ` [PATCH v5 17/37] bsd-user/arm/target_arch_cpu.h: Implement target_cpu_clone_regs Warner Losh
2021-11-08  3:51 ` [PATCH v5 18/37] bsd-user/arm/target_arch_cpu.h: Dummy target_cpu_loop implementation Warner Losh
2021-11-08  3:51 ` [PATCH v5 19/37] bsd-user/arm/target_arch_cpu.h: Implement trivial EXCP exceptions Warner Losh
2021-11-08  3:51 ` [PATCH v5 20/37] bsd-user/arm/target_arch_cpu.h: Implement data abort exceptions Warner Losh
2021-11-08  3:51 ` [PATCH v5 21/37] bsd-user/arm/target_arch_cpu.h: Implement system call dispatch Warner Losh
2021-11-08  3:51 ` [PATCH v5 22/37] bsd-user/arm/target_arch_reg.h: Implement core dump register copying Warner Losh
2021-11-08  3:51 ` [PATCH v5 23/37] bsd-user/arm/target_arch_vmparam.h: Parameters for arm address space Warner Losh
2021-11-08  3:51 ` [PATCH v5 24/37] bsd-user/arm/target_arch_sigtramp.h: Signal Trampoline for arm Warner Losh
2021-11-08  3:51 ` [PATCH v5 25/37] bsd-user/arm/target_arch_thread.h: Routines to create and switch to a thread Warner Losh
2021-11-08  3:51 ` [PATCH v5 26/37] bsd-user/arm/target_arch_elf.h: arm defines for ELF Warner Losh
2021-11-08  3:51 ` [PATCH v5 27/37] bsd-user/arm/target_arch_elf.h: arm get hwcap Warner Losh
2021-11-08  3:51 ` [PATCH v5 28/37] bsd-user/arm/target_arch_elf.h: arm get_hwcap2 impl Warner Losh
2021-11-08  3:51 ` [PATCH v5 29/37] bsd-user/arm/target_arch_signal.h: arm specific signal registers and stack Warner Losh
2021-11-08  3:51 ` [PATCH v5 30/37] bsd-user/arm/target_arch_signal.h: arm machine context and trapframe for signals Warner Losh
2021-11-08  3:51 ` [PATCH v5 31/37] bsd-user/arm/target_arch_signal.h: Define size of *context_t Warner Losh
2021-11-08  3:51 ` [PATCH v5 32/37] bsd-user/arm/signal.c: arm set_sigtramp_args Warner Losh
2021-11-08  3:51 ` [PATCH v5 33/37] bsd-user/arm/signal.c: arm get_mcontext Warner Losh
2021-11-08  3:51 ` [PATCH v5 34/37] bsd-user/arm/signal.c: arm set_mcontext Warner Losh
2021-11-08 15:42   ` Richard Henderson
2021-11-08  3:51 ` [PATCH v5 35/37] bsd-user/arm/signal.c: arm get_ucontext_sigreturn Warner Losh
2021-11-08  3:51 ` [PATCH v5 36/37] bsd-user/freebsd/target_os_ucontext.h: Require TARGET_*CONTEXT_SIZE Warner Losh
2021-11-08  3:51 ` [PATCH v5 37/37] bsd-user: add arm target build Warner Losh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211108035136.43687-12-imp@bsdimp.com \
    --to=imp@bsdimp.com \
    --cc=f4bug@amsat.org \
    --cc=kevans@freebsd.org \
    --cc=laurent@vivier.eu \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.