From: jae.hyun.yoo@intel.com To: Rob Herring <robh+dt@kernel.org>, Corey Minyard <minyard@acm.org>, Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>, Cedric Le Goater <clg@kaod.org>, Haiyue Wang <haiyue.wang@linux.intel.com>, ChiaWei Wang <chiawei_wang@aspeedtech.com>, Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openipmi-developer@lists.sourceforge.net Subject: [PATCH v3 5/6] dt-bindings: ipmi: aspeed,kcs-bmc: add 'clocks' as a required property Date: Mon, 8 Nov 2021 11:01:59 -0800 [thread overview] Message-ID: <20211108190200.290957-6-jae.hyun.yoo@intel.com> (raw) In-Reply-To: <20211108190200.290957-1-jae.hyun.yoo@intel.com> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> If LPC KCS driver is registered ahead of lpc-ctrl module, LPC KCS hardware block will be enabled without heart beating of LCLK until lpc-ctrl enables the LCLK. This issue causes improper handling on host interrupts when the host sends interrupts in that time frame. Then kernel eventually forcibly disables the interrupt with dumping stack and printing a 'nobody cared this irq' message out. To prevent this issue, all LPC sub drivers should enable LCLK individually so this patch adds 'clocks' property as one of required properties to enable the LCLK by the LPC KCS driver. Note: dtsi change in this patch series should be applied along with, and dtbs should be re-compiled after applying this series since it's adding a new required property otherwise the driver will not be probed correctly. Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> --- v2 -> v3: * Made commit message more descriptive. v1 -> v2: Changes sinve v1: * Added 'clocks' property into kcs-bmc bindings using 'aspeed,ast2400-kcs-bmc.yaml' because it's not merged into 'aspeed-lpc.yaml' yet. The bindings merging could be done using a separate patch later. .../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml index 4ff6fabfcb30..92ec0da047f4 100644 --- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml +++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml @@ -71,9 +71,14 @@ properties: $ref: '/schemas/types.yaml#/definitions/uint32' description: The host CPU IO map address + clocks: + maxItems: 1 + description: Reference clock for the LPC controller + required: - compatible - interrupts + - clocks additionalProperties: false @@ -96,6 +101,7 @@ allOf: examples: - | + #include <dt-bindings/clock/aspeed-clock.h> #include <dt-bindings/interrupt-controller/irq.h> kcs3: kcs@24 { compatible = "aspeed,ast2600-kcs-bmc"; @@ -103,4 +109,5 @@ examples: aspeed,lpc-io-reg = <0xca2>; aspeed,lpc-interrupts = <11 IRQ_TYPE_LEVEL_LOW>; interrupts = <8>; + clocks = <&syscon ASPEED_CLK_GATE_LCLK>; }; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: jae.hyun.yoo@intel.com To: Rob Herring <robh+dt@kernel.org>, Corey Minyard <minyard@acm.org>, Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>, Cedric Le Goater <clg@kaod.org>, Haiyue Wang <haiyue.wang@linux.intel.com>, ChiaWei Wang <chiawei_wang@aspeedtech.com>, Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openipmi-developer@lists.sourceforge.net Subject: [PATCH v3 5/6] dt-bindings: ipmi: aspeed, kcs-bmc: add 'clocks' as a required property Date: Mon, 8 Nov 2021 11:01:59 -0800 [thread overview] Message-ID: <20211108190200.290957-6-jae.hyun.yoo@intel.com> (raw) In-Reply-To: <20211108190200.290957-1-jae.hyun.yoo@intel.com> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> If LPC KCS driver is registered ahead of lpc-ctrl module, LPC KCS hardware block will be enabled without heart beating of LCLK until lpc-ctrl enables the LCLK. This issue causes improper handling on host interrupts when the host sends interrupts in that time frame. Then kernel eventually forcibly disables the interrupt with dumping stack and printing a 'nobody cared this irq' message out. To prevent this issue, all LPC sub drivers should enable LCLK individually so this patch adds 'clocks' property as one of required properties to enable the LCLK by the LPC KCS driver. Note: dtsi change in this patch series should be applied along with, and dtbs should be re-compiled after applying this series since it's adding a new required property otherwise the driver will not be probed correctly. Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> --- v2 -> v3: * Made commit message more descriptive. v1 -> v2: Changes sinve v1: * Added 'clocks' property into kcs-bmc bindings using 'aspeed,ast2400-kcs-bmc.yaml' because it's not merged into 'aspeed-lpc.yaml' yet. The bindings merging could be done using a separate patch later. .../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml index 4ff6fabfcb30..92ec0da047f4 100644 --- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml +++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml @@ -71,9 +71,14 @@ properties: $ref: '/schemas/types.yaml#/definitions/uint32' description: The host CPU IO map address + clocks: + maxItems: 1 + description: Reference clock for the LPC controller + required: - compatible - interrupts + - clocks additionalProperties: false @@ -96,6 +101,7 @@ allOf: examples: - | + #include <dt-bindings/clock/aspeed-clock.h> #include <dt-bindings/interrupt-controller/irq.h> kcs3: kcs@24 { compatible = "aspeed,ast2600-kcs-bmc"; @@ -103,4 +109,5 @@ examples: aspeed,lpc-io-reg = <0xca2>; aspeed,lpc-interrupts = <11 IRQ_TYPE_LEVEL_LOW>; interrupts = <8>; + clocks = <&syscon ASPEED_CLK_GATE_LCLK>; }; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-08 18:42 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-08 19:01 [PATCH v3 0/6] Add LCLK control into Aspeed LPC sub drivers jae.hyun.yoo 2021-11-08 19:01 ` jae.hyun.yoo 2021-11-08 19:01 ` [PATCH v3 1/6] ARM: dts: aspeed: add LCLK setting into LPC IBT node jae.hyun.yoo 2021-11-08 19:01 ` jae.hyun.yoo 2021-11-08 19:01 ` [PATCH v3 2/6] dt-bindings: ipmi: bt-bmc: add 'clocks' as a required property jae.hyun.yoo 2021-11-08 19:01 ` jae.hyun.yoo 2021-11-19 1:07 ` Rob Herring 2021-11-19 1:07 ` Rob Herring 2021-11-08 19:01 ` [PATCH v3 3/6] ipmi: bt: add clock control logic jae.hyun.yoo 2021-11-08 19:01 ` jae.hyun.yoo 2021-11-08 19:01 ` [PATCH v3 4/6] ARM: dts: aspeed: add LCLK setting into LPC KCS nodes jae.hyun.yoo 2021-11-08 19:01 ` jae.hyun.yoo 2021-11-08 19:01 ` jae.hyun.yoo [this message] 2021-11-08 19:01 ` [PATCH v3 5/6] dt-bindings: ipmi: aspeed, kcs-bmc: add 'clocks' as a required property jae.hyun.yoo 2021-11-19 1:08 ` [PATCH v3 5/6] dt-bindings: ipmi: aspeed,kcs-bmc: " Rob Herring 2021-11-19 1:08 ` Rob Herring 2021-11-08 19:02 ` [PATCH v3 6/6] ipmi: kcs_bmc_aspeed: add clock control logic jae.hyun.yoo 2021-11-08 19:02 ` jae.hyun.yoo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211108190200.290957-6-jae.hyun.yoo@intel.com \ --to=jae.hyun.yoo@intel.com \ --cc=andrew@aj.id.au \ --cc=chiawei_wang@aspeedtech.com \ --cc=clg@kaod.org \ --cc=devicetree@vger.kernel.org \ --cc=haiyue.wang@linux.intel.com \ --cc=jae.hyun.yoo@linux.intel.com \ --cc=joel@jms.id.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=minyard@acm.org \ --cc=openipmi-developer@lists.sourceforge.net \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.