From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: linux-trace-devel@vger.kernel.org
Cc: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH 2/5] kernel-shark: Fix a warning from 'KsUtils.cpp'
Date: Wed, 10 Nov 2021 16:37:44 +0200 [thread overview]
Message-ID: <20211110143747.32833-2-y.karadz@gmail.com> (raw)
In-Reply-To: <20211110143747.32833-1-y.karadz@gmail.com>
gcc 11.2.1 prints the following warning:
KsUtils.cpp:573:41: warning: loop variable 'task' creates a copy from
type 'const QString' [-Wrange-loop-construct]
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
src/KsUtils.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/KsUtils.cpp b/src/KsUtils.cpp
index 364c25d..a22c445 100644
--- a/src/KsUtils.cpp
+++ b/src/KsUtils.cpp
@@ -570,7 +570,7 @@ QMap<int, QVector<int>> parseTaskList(QString v_str)
if (name.isEmpty())
continue;
- for (auto const task: taskList) {
+ for (auto const &task: taskList) {
if(name == task)
ret[sd].append(pid);
}
--
2.33.1
next prev parent reply other threads:[~2021-11-10 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 14:37 [PATCH 1/5] kernel-shark: Silence a warning from 'cmake_clean.sh' Yordan Karadzhov (VMware)
2021-11-10 14:37 ` Yordan Karadzhov (VMware) [this message]
2021-11-10 14:37 ` [PATCH 3/5] kernel-shark: Update the README file Yordan Karadzhov (VMware)
2021-11-10 14:37 ` [PATCH 4/5] kernel-shark: Add 'Requires' to libkshark.pc Yordan Karadzhov (VMware)
2021-11-10 16:29 ` Steven Rostedt
2021-11-10 14:37 ` [PATCH 5/5] kernel-shark: Always run 'ldconfig' after installing libkshark Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110143747.32833-2-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.