All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: tomba@kernel.org
Cc: linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, khilman@baylibre.com,
	Benoit Parrot <bparrot@ti.com>,
	Neil Armstrong <narmstrong@baylibre.com>
Subject: [PATCH v7 8/9] drm/omap: add plane_atomic_print_state support
Date: Wed, 17 Nov 2021 15:19:27 +0100	[thread overview]
Message-ID: <20211117141928.771082-9-narmstrong@baylibre.com> (raw)
In-Reply-To: <20211117141928.771082-1-narmstrong@baylibre.com>

From: Benoit Parrot <bparrot@ti.com>

Now that we added specific item to our subclassed drm_plane_state
we can add omap_plane_atomic_print_state() helper to dump out our own
driver specific plane state.

Signed-off-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/gpu/drm/omapdrm/omap_plane.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/omapdrm/omap_plane.c
index ce5ed45401fb..23b752d837a4 100644
--- a/drivers/gpu/drm/omapdrm/omap_plane.c
+++ b/drivers/gpu/drm/omapdrm/omap_plane.c
@@ -348,6 +348,19 @@ omap_plane_atomic_duplicate_state(struct drm_plane *plane)
 	return &state->base;
 }
 
+static void omap_plane_atomic_print_state(struct drm_printer *p,
+					  const struct drm_plane_state *state)
+{
+	struct omap_plane_state *omap_state = to_omap_plane_state(state);
+
+	if (omap_state->overlay)
+		drm_printf(p, "\toverlay=%s (caps=0x%x)\n",
+			   omap_state->overlay->name,
+			   omap_state->overlay->caps);
+	else
+		drm_printf(p, "\toverlay=None\n");
+}
+
 static int omap_plane_atomic_set_property(struct drm_plane *plane,
 					  struct drm_plane_state *state,
 					  struct drm_property *property,
@@ -387,6 +400,7 @@ static const struct drm_plane_funcs omap_plane_funcs = {
 	.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
 	.atomic_set_property = omap_plane_atomic_set_property,
 	.atomic_get_property = omap_plane_atomic_get_property,
+	.atomic_print_state = omap_plane_atomic_print_state,
 };
 
 static bool omap_plane_supports_yuv(struct drm_plane *plane)
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: tomba@kernel.org
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	khilman@baylibre.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org
Subject: [PATCH v7 8/9] drm/omap: add plane_atomic_print_state support
Date: Wed, 17 Nov 2021 15:19:27 +0100	[thread overview]
Message-ID: <20211117141928.771082-9-narmstrong@baylibre.com> (raw)
In-Reply-To: <20211117141928.771082-1-narmstrong@baylibre.com>

From: Benoit Parrot <bparrot@ti.com>

Now that we added specific item to our subclassed drm_plane_state
we can add omap_plane_atomic_print_state() helper to dump out our own
driver specific plane state.

Signed-off-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/gpu/drm/omapdrm/omap_plane.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/omapdrm/omap_plane.c
index ce5ed45401fb..23b752d837a4 100644
--- a/drivers/gpu/drm/omapdrm/omap_plane.c
+++ b/drivers/gpu/drm/omapdrm/omap_plane.c
@@ -348,6 +348,19 @@ omap_plane_atomic_duplicate_state(struct drm_plane *plane)
 	return &state->base;
 }
 
+static void omap_plane_atomic_print_state(struct drm_printer *p,
+					  const struct drm_plane_state *state)
+{
+	struct omap_plane_state *omap_state = to_omap_plane_state(state);
+
+	if (omap_state->overlay)
+		drm_printf(p, "\toverlay=%s (caps=0x%x)\n",
+			   omap_state->overlay->name,
+			   omap_state->overlay->caps);
+	else
+		drm_printf(p, "\toverlay=None\n");
+}
+
 static int omap_plane_atomic_set_property(struct drm_plane *plane,
 					  struct drm_plane_state *state,
 					  struct drm_property *property,
@@ -387,6 +400,7 @@ static const struct drm_plane_funcs omap_plane_funcs = {
 	.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
 	.atomic_set_property = omap_plane_atomic_set_property,
 	.atomic_get_property = omap_plane_atomic_get_property,
+	.atomic_print_state = omap_plane_atomic_print_state,
 };
 
 static bool omap_plane_supports_yuv(struct drm_plane *plane)
-- 
2.25.1


  parent reply	other threads:[~2021-11-17 14:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 14:19 [PATCH v7 0/9] drm/omap: Add virtual-planes support Neil Armstrong
2021-11-17 14:19 ` Neil Armstrong
2021-11-17 14:19 ` [PATCH v7 1/9] drm/omap: add sanity plane state check Neil Armstrong
2021-11-17 14:19   ` Neil Armstrong
2021-11-17 14:19 ` [PATCH v7 2/9] drm/omap: Add ability to check if requested plane modes can be supported Neil Armstrong
2021-11-17 14:19   ` Neil Armstrong
2021-11-17 14:19 ` [PATCH v7 3/9] drm/omap: Add ovl checking funcs to dispc_ops Neil Armstrong
2021-11-17 14:19   ` Neil Armstrong
2021-11-17 14:19 ` [PATCH v7 4/9] drm/omap: introduce omap_hw_overlay Neil Armstrong
2021-11-17 14:19   ` Neil Armstrong
2021-11-17 14:19 ` [PATCH v7 5/9] drm/omap: omap_plane: subclass drm_plane_state Neil Armstrong
2021-11-17 14:19   ` Neil Armstrong
2021-11-17 14:19 ` [PATCH v7 6/9] drm/omap: Add global state as a private atomic object Neil Armstrong
2021-11-17 14:19   ` Neil Armstrong
2021-11-17 14:19 ` [PATCH v7 7/9] drm/omap: dynamically assign hw overlays to planes Neil Armstrong
2021-11-17 14:19   ` Neil Armstrong
2021-11-17 14:19 ` Neil Armstrong [this message]
2021-11-17 14:19   ` [PATCH v7 8/9] drm/omap: add plane_atomic_print_state support Neil Armstrong
2021-11-17 14:19 ` [PATCH v7 9/9] drm/omap: Add a 'right overlay' to plane state Neil Armstrong
2021-11-17 14:19   ` Neil Armstrong
2021-11-30 16:34 ` [PATCH v7 0/9] drm/omap: Add virtual-planes support Neil Armstrong
2021-11-30 16:34   ` Neil Armstrong
2021-12-03 11:31 ` Tomi Valkeinen
2021-12-03 11:31   ` Tomi Valkeinen
2021-12-03 15:09   ` Neil Armstrong
2021-12-03 15:09     ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211117141928.771082-9-narmstrong@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=bparrot@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=khilman@baylibre.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomba@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.