All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
	"Ivan T . Ivanov" <iivanov@suse.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] ARM: socfpga: Fix crash with CONFIG_FORTIRY_SOURCE
Date: Wed, 17 Nov 2021 20:32:44 +0100	[thread overview]
Message-ID: <20211117193244.31162-1-tiwai@suse.de> (raw)

When CONFIG_FORTIFY_SOURCE is set, memcpy() checks the potential
buffer overflow and panics.  The code in sofcpga bootstrapping
contains the memcpy() calls are mistakenly translated as the shorter
size, hence it triggers a panic as if it were overflowing.

This patch adds the __NO_FORTIFY define for avoiding the
false-positive crash.

Buglink: https://bugzilla.suse.com/show_bug.cgi?id=1192473
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

I took an easier path for now, as the attempt with a foced cast
failed.  If there is a better way to handle, let me know, I'd happily
resubmit.  Thanks!

 arch/arm/mach-socfpga/platsmp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-socfpga/platsmp.c b/arch/arm/mach-socfpga/platsmp.c
index fbb80b883e5d..d46b1af96a8a 100644
--- a/arch/arm/mach-socfpga/platsmp.c
+++ b/arch/arm/mach-socfpga/platsmp.c
@@ -5,6 +5,9 @@
  * Based on platsmp.c, Copyright (C) 2002 ARM Ltd.
  * Copyright (C) 2012 Altera Corporation
  */
+
+#define __NO_FORTIFY /* need to avoid the crash with memcpy() calls */
+
 #include <linux/delay.h>
 #include <linux/init.h>
 #include <linux/smp.h>
-- 
2.26.2


WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
	"Ivan T . Ivanov" <iivanov@suse.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] ARM: socfpga: Fix crash with CONFIG_FORTIRY_SOURCE
Date: Wed, 17 Nov 2021 20:32:44 +0100	[thread overview]
Message-ID: <20211117193244.31162-1-tiwai@suse.de> (raw)

When CONFIG_FORTIFY_SOURCE is set, memcpy() checks the potential
buffer overflow and panics.  The code in sofcpga bootstrapping
contains the memcpy() calls are mistakenly translated as the shorter
size, hence it triggers a panic as if it were overflowing.

This patch adds the __NO_FORTIFY define for avoiding the
false-positive crash.

Buglink: https://bugzilla.suse.com/show_bug.cgi?id=1192473
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

I took an easier path for now, as the attempt with a foced cast
failed.  If there is a better way to handle, let me know, I'd happily
resubmit.  Thanks!

 arch/arm/mach-socfpga/platsmp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-socfpga/platsmp.c b/arch/arm/mach-socfpga/platsmp.c
index fbb80b883e5d..d46b1af96a8a 100644
--- a/arch/arm/mach-socfpga/platsmp.c
+++ b/arch/arm/mach-socfpga/platsmp.c
@@ -5,6 +5,9 @@
  * Based on platsmp.c, Copyright (C) 2002 ARM Ltd.
  * Copyright (C) 2012 Altera Corporation
  */
+
+#define __NO_FORTIFY /* need to avoid the crash with memcpy() calls */
+
 #include <linux/delay.h>
 #include <linux/init.h>
 #include <linux/smp.h>
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2021-11-17 19:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 19:32 Takashi Iwai [this message]
2021-11-17 19:32 ` [PATCH] ARM: socfpga: Fix crash with CONFIG_FORTIRY_SOURCE Takashi Iwai
2021-11-17 22:01 ` Kees Cook
2021-11-17 22:01   ` Kees Cook
2021-11-18  7:27   ` Takashi Iwai
2021-11-18  7:27     ` Takashi Iwai
2021-11-18 14:23     ` Takashi Iwai
2021-11-18 14:23       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211117193244.31162-1-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=dinguyen@kernel.org \
    --cc=iivanov@suse.de \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.