All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	linux-scsi@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
	Ming Lei <ming.lei@redhat.com>
Subject: [PATCH 3/5] blk-mq: add helper of blk_mq_global_quiesce_wait()
Date: Fri, 19 Nov 2021 10:18:47 +0800	[thread overview]
Message-ID: <20211119021849.2259254-4-ming.lei@redhat.com> (raw)
In-Reply-To: <20211119021849.2259254-1-ming.lei@redhat.com>

Add helper of blk_mq_global_quiesce_wait() for supporting to quiesce
queues in parallel, then we can just wait once if global quiesce wait
is allowed.

Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
 include/linux/blk-mq.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index 5cc7fc1ea863..a9fecda2507e 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -777,6 +777,19 @@ static inline bool blk_mq_add_to_batch(struct request *req,
 	return true;
 }
 
+/*
+ * If the queue has allocated & used srcu to quiesce queue, quiesce wait is
+ * done via the synchronize_srcu(q->rcu), otherwise it is done via global
+ * synchronize_rcu().
+ *
+ * This helper can help us to support quiescing queue in parallel, so just
+ * one quiesce wait is enough if global quiesce wait is allowed.
+ */
+static inline bool blk_mq_global_quiesce_wait(struct request_queue *q)
+{
+	return !q->alloc_srcu;
+}
+
 void blk_mq_requeue_request(struct request *rq, bool kick_requeue_list);
 void blk_mq_kick_requeue_list(struct request_queue *q);
 void blk_mq_delay_kick_requeue_list(struct request_queue *q, unsigned long msecs);
-- 
2.31.1


  parent reply	other threads:[~2021-11-19  2:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  2:18 [PATCH 0/5] blk-mq: quiesce improvement Ming Lei
2021-11-19  2:18 ` [PATCH 1/5] blk-mq: move srcu from blk_mq_hw_ctx to request_queue Ming Lei
2021-11-19  4:30   ` Bart Van Assche
2021-11-19  8:10     ` Ming Lei
2021-11-22  7:48       ` Sagi Grimberg
2021-11-22 13:08         ` Ming Lei
2021-11-22 13:47           ` Sagi Grimberg
2021-11-19  2:18 ` [PATCH 2/5] blk-mq: rename hctx_lock & hctx_unlock Ming Lei
2021-11-22  7:53   ` Sagi Grimberg
2021-11-22 13:20     ` Ming Lei
2021-11-22 13:50       ` Sagi Grimberg
2021-11-23  0:08         ` Ming Lei
2021-11-23  8:54           ` Sagi Grimberg
2021-11-22  9:00   ` Christoph Hellwig
2021-11-19  2:18 ` Ming Lei [this message]
2021-11-22  7:56   ` [PATCH 3/5] blk-mq: add helper of blk_mq_global_quiesce_wait() Sagi Grimberg
2021-11-22  8:00     ` Sagi Grimberg
2021-11-22 13:26     ` Ming Lei
2021-11-22 13:55       ` Sagi Grimberg
2021-11-23  0:17         ` Ming Lei
2021-11-23  9:00           ` Sagi Grimberg
2021-11-30  2:33             ` Ming Lei
2021-12-08 12:49               ` Sagi Grimberg
2021-12-10  2:02                 ` Ming Lei
2021-11-19  2:18 ` [PATCH 4/5] nvme: quiesce namespace queue in parallel Ming Lei
2021-11-22  8:07   ` Sagi Grimberg
2021-11-23  0:13     ` Ming Lei
2021-11-19  2:18 ` [PATCH 5/5] scsi: use blk-mq quiesce APIs to implement scsi_host_block Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211119021849.2259254-4-ming.lei@redhat.com \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.