From: Tudor Ambarus <tudor.ambarus@microchip.com> To: <ludovic.desroches@microchip.com>, <vkoul@kernel.org>, <richard.genoud@gmail.com>, <gregkh@linuxfoundation.org>, <jirislaby@kernel.org> Cc: <nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <mripard@kernel.org>, <linux-arm-kernel@lists.infradead.org>, <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>, Tudor Ambarus <tudor.ambarus@microchip.com> Subject: [PATCH v2 02/13] tty: serial: atmel: Check return code of dmaengine_submit() Date: Thu, 25 Nov 2021 11:00:17 +0200 [thread overview] Message-ID: <20211125090028.786832-3-tudor.ambarus@microchip.com> (raw) In-Reply-To: <20211125090028.786832-1-tudor.ambarus@microchip.com> The tx_submit() method of struct dma_async_tx_descriptor is entitled to do sanity checks and return errors if encountered. It's not the case for the DMA controller drivers that this client is using (at_h/xdmac), because they currently don't do sanity checks and always return a positive cookie at tx_submit() method. In case the controller drivers will implement sanity checks and return errors, print a message so that the client will be informed that something went wrong at tx_submit() level. Fixes: 08f738be88bb ("serial: at91: add tx dma support") Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> Acked-by: Richard Genoud <richard.genoud@gmail.com> --- drivers/tty/serial/atmel_serial.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c index 2c99a47a2535..376f7a9c2868 100644 --- a/drivers/tty/serial/atmel_serial.c +++ b/drivers/tty/serial/atmel_serial.c @@ -1004,6 +1004,11 @@ static void atmel_tx_dma(struct uart_port *port) desc->callback = atmel_complete_tx_dma; desc->callback_param = atmel_port; atmel_port->cookie_tx = dmaengine_submit(desc); + if (dma_submit_error(atmel_port->cookie_tx)) { + dev_err(port->dev, "dma_submit_error %d\n", + atmel_port->cookie_tx); + return; + } } if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) @@ -1258,6 +1263,11 @@ static int atmel_prepare_rx_dma(struct uart_port *port) desc->callback_param = port; atmel_port->desc_rx = desc; atmel_port->cookie_rx = dmaengine_submit(desc); + if (dma_submit_error(atmel_port->cookie_rx)) { + dev_err(port->dev, "dma_submit_error %d\n", + atmel_port->cookie_rx); + goto chan_err; + } return 0; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Tudor Ambarus <tudor.ambarus@microchip.com> To: <ludovic.desroches@microchip.com>, <vkoul@kernel.org>, <richard.genoud@gmail.com>, <gregkh@linuxfoundation.org>, <jirislaby@kernel.org> Cc: alexandre.belloni@bootlin.com, Tudor Ambarus <tudor.ambarus@microchip.com>, mripard@kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 02/13] tty: serial: atmel: Check return code of dmaengine_submit() Date: Thu, 25 Nov 2021 11:00:17 +0200 [thread overview] Message-ID: <20211125090028.786832-3-tudor.ambarus@microchip.com> (raw) In-Reply-To: <20211125090028.786832-1-tudor.ambarus@microchip.com> The tx_submit() method of struct dma_async_tx_descriptor is entitled to do sanity checks and return errors if encountered. It's not the case for the DMA controller drivers that this client is using (at_h/xdmac), because they currently don't do sanity checks and always return a positive cookie at tx_submit() method. In case the controller drivers will implement sanity checks and return errors, print a message so that the client will be informed that something went wrong at tx_submit() level. Fixes: 08f738be88bb ("serial: at91: add tx dma support") Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> Acked-by: Richard Genoud <richard.genoud@gmail.com> --- drivers/tty/serial/atmel_serial.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c index 2c99a47a2535..376f7a9c2868 100644 --- a/drivers/tty/serial/atmel_serial.c +++ b/drivers/tty/serial/atmel_serial.c @@ -1004,6 +1004,11 @@ static void atmel_tx_dma(struct uart_port *port) desc->callback = atmel_complete_tx_dma; desc->callback_param = atmel_port; atmel_port->cookie_tx = dmaengine_submit(desc); + if (dma_submit_error(atmel_port->cookie_tx)) { + dev_err(port->dev, "dma_submit_error %d\n", + atmel_port->cookie_tx); + return; + } } if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) @@ -1258,6 +1263,11 @@ static int atmel_prepare_rx_dma(struct uart_port *port) desc->callback_param = port; atmel_port->desc_rx = desc; atmel_port->cookie_rx = dmaengine_submit(desc); + if (dma_submit_error(atmel_port->cookie_rx)) { + dev_err(port->dev, "dma_submit_error %d\n", + atmel_port->cookie_rx); + goto chan_err; + } return 0; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-25 9:02 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-25 9:00 [PATCH v2 00/13] dmaengine: at_xdmac: Various fixes Tudor Ambarus 2021-11-25 9:00 ` Tudor Ambarus 2021-11-25 9:00 ` [PATCH v2 01/13] dmaengine: at_xdmac: Don't start transactions at tx_submit level Tudor Ambarus 2021-11-25 9:00 ` Tudor Ambarus 2021-11-25 9:00 ` Tudor Ambarus [this message] 2021-11-25 9:00 ` [PATCH v2 02/13] tty: serial: atmel: Check return code of dmaengine_submit() Tudor Ambarus 2021-11-25 9:00 ` [PATCH v2 03/13] tty: serial: atmel: Call dma_async_issue_pending() Tudor Ambarus 2021-11-25 9:00 ` Tudor Ambarus 2021-11-25 9:00 ` [PATCH v2 04/13] dmaengine: at_xdmac: Start transfer for cyclic channels in issue_pending Tudor Ambarus 2021-11-25 9:00 ` Tudor Ambarus 2021-11-25 9:00 ` [PATCH v2 05/13] dmaengine: at_xdmac: Print debug message after realeasing the lock Tudor Ambarus 2021-11-25 9:00 ` Tudor Ambarus 2021-11-25 9:00 ` [PATCH v2 06/13] dmaengine: at_xdmac: Fix concurrency over chan's completed_cookie Tudor Ambarus 2021-11-25 9:00 ` Tudor Ambarus 2021-11-25 9:00 ` [PATCH v2 07/13] dmaengine: at_xdmac: Fix race for the tx desc callback Tudor Ambarus 2021-11-25 9:00 ` Tudor Ambarus 2021-11-25 9:00 ` [PATCH v2 08/13] dmaengine: at_xdmac: Move the free desc to the tail of the desc list Tudor Ambarus 2021-11-25 9:00 ` Tudor Ambarus 2021-12-13 8:07 ` Vinod Koul 2021-12-13 8:07 ` Vinod Koul 2021-12-13 8:51 ` Tudor.Ambarus 2021-12-13 8:51 ` Tudor.Ambarus 2021-12-13 8:59 ` Vinod Koul 2021-12-13 8:59 ` Vinod Koul 2021-12-13 9:00 ` Vinod Koul 2021-12-13 9:00 ` Vinod Koul 2021-12-13 9:22 ` Tudor.Ambarus 2021-12-13 9:22 ` Tudor.Ambarus 2021-12-13 9:27 ` Tudor.Ambarus 2021-12-13 9:27 ` Tudor.Ambarus 2021-11-25 9:00 ` [PATCH v2 09/13] dmaengine: at_xdmac: Fix concurrency over xfers_list Tudor Ambarus 2021-11-25 9:00 ` Tudor Ambarus 2021-11-25 9:00 ` [PATCH v2 10/13] dmaengine: at_xdmac: Remove a level of indentation in at_xdmac_advance_work() Tudor Ambarus 2021-11-25 9:00 ` Tudor Ambarus 2021-11-25 9:00 ` [PATCH v2 11/13] dmaengine: at_xdmac: Fix lld view setting Tudor Ambarus 2021-11-25 9:00 ` Tudor Ambarus 2021-11-25 9:00 ` [PATCH v2 12/13] dmaengine: at_xdmac: Fix at_xdmac_lld struct definition Tudor Ambarus 2021-11-25 9:00 ` Tudor Ambarus 2021-11-25 9:00 ` [PATCH v2 13/13] dmaengine: at_xdmac: Fix race over irq_status Tudor Ambarus 2021-11-25 9:00 ` Tudor Ambarus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211125090028.786832-3-tudor.ambarus@microchip.com \ --to=tudor.ambarus@microchip.com \ --cc=alexandre.belloni@bootlin.com \ --cc=dmaengine@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jirislaby@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=ludovic.desroches@microchip.com \ --cc=mripard@kernel.org \ --cc=nicolas.ferre@microchip.com \ --cc=richard.genoud@gmail.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.