All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai3@huawei.com>
To: <tj@kernel.org>, <axboe@kernel.dk>, <paolo.valente@linaro.org>
Cc: <cgroups@vger.kernel.org>, <linux-block@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <yukuai3@huawei.com>,
	<yi.zhang@huawei.com>
Subject: [PATCH RFC 8/9] block, bfq: move forward __bfq_weights_tree_remove()
Date: Sat, 27 Nov 2021 18:11:31 +0800	[thread overview]
Message-ID: <20211127101132.486806-9-yukuai3@huawei.com> (raw)
In-Reply-To: <20211127101132.486806-1-yukuai3@huawei.com>

Prepare to decrease 'num_groups_with_pending_reqs' earlier.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
 block/bfq-iosched.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index e3c31db4bffb..4239b3996e23 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -882,6 +882,10 @@ void bfq_weights_tree_remove(struct bfq_data *bfqd,
 {
 	struct bfq_entity *entity = bfqq->entity.parent;
 
+	bfqq->ref++;
+	__bfq_weights_tree_remove(bfqd, bfqq,
+				  &bfqd->queue_weights_tree);
+
 	for_each_entity(entity) {
 		struct bfq_sched_data *sd = entity->my_sched_data;
 
@@ -916,14 +920,7 @@ void bfq_weights_tree_remove(struct bfq_data *bfqd,
 		}
 	}
 
-	/*
-	 * Next function is invoked last, because it causes bfqq to be
-	 * freed if the following holds: bfqq is not in service and
-	 * has no dispatched request. DO NOT use bfqq after the next
-	 * function invocation.
-	 */
-	__bfq_weights_tree_remove(bfqd, bfqq,
-				  &bfqd->queue_weights_tree);
+	bfq_put_queue(bfqq);
 }
 
 /*
-- 
2.31.1


WARNING: multiple messages have this Message-ID (diff)
From: Yu Kuai <yukuai3@huawei.com>
To: tj@kernel.org, axboe@kernel.dk, paolo.valente@linaro.org
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, yukuai3@huawei.com,
	yi.zhang@huawei.com
Subject: [PATCH RFC 8/9] block, bfq: move forward __bfq_weights_tree_remove()
Date: Sat, 27 Nov 2021 18:11:31 +0800	[thread overview]
Message-ID: <20211127101132.486806-9-yukuai3@huawei.com> (raw)
In-Reply-To: <20211127101132.486806-1-yukuai3@huawei.com>

Prepare to decrease 'num_groups_with_pending_reqs' earlier.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
 block/bfq-iosched.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index e3c31db4bffb..4239b3996e23 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -882,6 +882,10 @@ void bfq_weights_tree_remove(struct bfq_data *bfqd,
 {
 	struct bfq_entity *entity = bfqq->entity.parent;
 
+	bfqq->ref++;
+	__bfq_weights_tree_remove(bfqd, bfqq,
+				  &bfqd->queue_weights_tree);
+
 	for_each_entity(entity) {
 		struct bfq_sched_data *sd = entity->my_sched_data;
 
@@ -916,14 +920,7 @@ void bfq_weights_tree_remove(struct bfq_data *bfqd,
 		}
 	}
 
-	/*
-	 * Next function is invoked last, because it causes bfqq to be
-	 * freed if the following holds: bfqq is not in service and
-	 * has no dispatched request. DO NOT use bfqq after the next
-	 * function invocation.
-	 */
-	__bfq_weights_tree_remove(bfqd, bfqq,
-				  &bfqd->queue_weights_tree);
+	bfq_put_queue(bfqq);
 }
 
 /*
-- 
2.31.1


  parent reply	other threads:[~2021-11-27 10:01 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-27 10:11 [PATCH RFC 0/9] support concurrent sync io for bfq on a specail occasion Yu Kuai
2021-11-27 10:11 ` Yu Kuai
2021-11-27 10:11 ` [PATCH RFC 1/9] block, bfq: add new apis to iterate bfq entities Yu Kuai
2021-11-27 10:11   ` Yu Kuai
2021-11-27 10:11 ` [PATCH RFC 2/9] block, bfq: apply news apis where root group is not expected Yu Kuai
2021-11-27 10:11   ` Yu Kuai
2021-11-27 10:11 ` [PATCH RFC 3/9] block, bfq: handle the case when for_each_entity() access root group Yu Kuai
2021-11-27 10:11   ` Yu Kuai
2021-12-10 10:06   ` Paolo Valente
2021-12-10 10:06     ` Paolo Valente
2021-11-27 10:11 ` [PATCH RFC 4/9] block, bfq: count root group into 'num_groups_with_pending_reqs' Yu Kuai
2021-11-27 10:11   ` Yu Kuai
2021-11-27 10:11 ` [PATCH RFC 5/9] block, bfq: do not idle if only one cgroup is activated Yu Kuai
2021-11-27 10:11   ` Yu Kuai
2021-11-27 10:11 ` [PATCH RFC 6/9] block, bfq: only count group that the bfq_queue belongs to Yu Kuai
2021-11-27 10:11   ` Yu Kuai
2021-11-27 10:11 ` [PATCH RFC 7/9] block, bfq: record how many queues have pending requests in bfq_group Yu Kuai
2021-11-27 10:11   ` Yu Kuai
2021-11-27 10:11 ` Yu Kuai [this message]
2021-11-27 10:11   ` [PATCH RFC 8/9] block, bfq: move forward __bfq_weights_tree_remove() Yu Kuai
2021-12-10 10:00   ` Paolo Valente
2021-12-11  2:18     ` yukuai (C)
2021-12-11  2:18       ` yukuai (C)
2021-11-27 10:11 ` [PATCH RFC 9/9] block, bfq: decrease 'num_groups_with_pending_reqs' earlier Yu Kuai
2021-11-27 10:11   ` Yu Kuai
2021-12-10 10:21   ` Paolo Valente
2021-12-10 10:21     ` Paolo Valente
2021-12-11  2:10     ` yukuai (C)
2021-12-11  2:10       ` yukuai (C)
2021-12-16 16:34       ` Paolo Valente
2021-12-17  2:53         ` yukuai (C)
2021-12-17  2:53           ` yukuai (C)
2021-12-10  8:20 ` [PATCH RFC 0/9] support concurrent sync io for bfq on a specail occasion yukuai (C)
2021-12-10  8:20   ` yukuai (C)
2021-12-10  9:20 ` Paolo Valente
2021-12-10  9:20   ` Paolo Valente
2021-12-10  9:50   ` yukuai (C)
2021-12-10  9:50     ` yukuai (C)
2021-12-10 10:23     ` Paolo Valente

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211127101132.486806-9-yukuai3@huawei.com \
    --to=yukuai3@huawei.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.valente@linaro.org \
    --cc=tj@kernel.org \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.