All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
	david@fromorbit.com, linux-kernel@vger.kernel.org,
	sandeen@sandeen.net, hch@lst.de, agruenba@redhat.com
Subject: [GIT PULL] iomap: bug fixes and doc improvements for 5.16-rc2
Date: Sat, 27 Nov 2021 12:04:26 -0800	[thread overview]
Message-ID: <20211127200426.GA8467@magnolia> (raw)

Hi Linus,

Please pull this branch containing a single iomap bug fix and a cleanup
for 5.16-rc2.  The bug fix changes how iomap deals with reading from an
inline data region -- whereas the current code (incorrectly) lets the
iomap read iter try for more bytes after reading the inline region
(which zeroes the rest of the page!) and hopes the next iteration
terminates, we surveyed the inlinedata implementations and realized that
all inlinedata implementations also require that the inlinedata region
end at EOF, so we can simply terminate the read.

The second patch documents these assumptions in the code so that they're
not subtle implications anymore, and cleans up some of the grosser parts
of that function.

The branch merges cleanly against upstream as of a few minutes ago.
Please let me know if anything else strange happens during the merge
process.

--D

The following changes since commit 136057256686de39cc3a07c2e39ef6bc43003ff6:

  Linux 5.16-rc2 (2021-11-21 13:47:39 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/iomap-5.16-fixes-1

for you to fetch changes up to 5ad448ce2976f829d95dcae5e6e91f6686b0e4de:

  iomap: iomap_read_inline_data cleanup (2021-11-24 10:15:47 -0800)

----------------------------------------------------------------
Fixes for 5.16-rc2:
 - Fix an accounting problem where unaligned inline data reads can run
   off the end of the read iomap iterator.  iomap has historically
   required that inline data mappings only exist at the end of a file,
   though this wasn't documented anywhere.
 - Document iomap_read_inline_data and change its return type to be
   appropriate for the information that it's actually returning.

----------------------------------------------------------------
Andreas Gruenbacher (2):
      iomap: Fix inline extent handling in iomap_readpage
      iomap: iomap_read_inline_data cleanup

 fs/iomap/buffered-io.c | 26 ++++++++++++++++----------
 1 file changed, 16 insertions(+), 10 deletions(-)

             reply	other threads:[~2021-11-27 20:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-27 20:04 Darrick J. Wong [this message]
2021-11-27 21:03 ` [GIT PULL] iomap: bug fixes and doc improvements for 5.16-rc2 pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211127200426.GA8467@magnolia \
    --to=djwong@kernel.org \
    --cc=agruenba@redhat.com \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.