All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: linux-kernel@vger.kernel.org
Cc: benh@kernel.crashing.org, boqun.feng@gmail.com, bp@alien8.de,
	catalin.marinas@arm.com, dvyukov@google.com, efuller@redhat.com,
	elver@google.com, ink@jurassic.park.msu.ru, jonas@southpole.se,
	juri.lelli@redhat.com, linux@armlinux.org.uk, luto@kernel.org,
	mark.rutland@arm.com, mattst88@gmail.com,
	michal.simek@xilinx.com, mingo@redhat.com, mpe@ellerman.id.au,
	npiggin@gmail.com, paulmck@kernel.org, paulus@samba.org,
	peterz@infradead.org, rth@twiddle.net, shorne@gmail.com,
	stefan.kristiansson@saunalahti.fi, tglx@linutronix.de,
	vincent.guittot@linaro.org, will@kernel.org
Subject: [PATCH v8 07/11] microblaze: snapshot thread flags
Date: Mon, 29 Nov 2021 13:06:49 +0000	[thread overview]
Message-ID: <20211129130653.2037928-8-mark.rutland@arm.com> (raw)
In-Reply-To: <20211129130653.2037928-1-mark.rutland@arm.com>

Some thread flags can be set remotely, and so even when IRQs are
disabled, the flags can change under our feet. Generally this is
unlikely to cause a problem in practice, but it is somewhat unsound, and
KCSAN will legitimately warn that there is a data race.

To avoid such issues, a snapshot of the flags has to be taken prior to
using them. Some places already use READ_ONCE() for that, others do not.

Convert them all to the new flag accessor helpers.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Tested-by: Michal Simek <michal.simek@xilinx.com>
---
 arch/microblaze/kernel/signal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/microblaze/kernel/signal.c b/arch/microblaze/kernel/signal.c
index fc61eb0eb8dd..23e8a9336a29 100644
--- a/arch/microblaze/kernel/signal.c
+++ b/arch/microblaze/kernel/signal.c
@@ -283,7 +283,7 @@ static void do_signal(struct pt_regs *regs, int in_syscall)
 #ifdef DEBUG_SIG
 	pr_info("do signal: %p %d\n", regs, in_syscall);
 	pr_info("do signal2: %lx %lx %ld [%lx]\n", regs->pc, regs->r1,
-			regs->r12, current_thread_info()->flags);
+			regs->r12, read_thread_flags());
 #endif
 
 	if (get_signal(&ksig)) {
-- 
2.30.2


  parent reply	other threads:[~2021-11-29 13:11 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 13:06 [PATCH v8 00/11] thread_info: use helpers to snapshot thread flags Mark Rutland
2021-11-29 13:06 ` [PATCH v8 01/11] thread_info: add " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] thread_info: Add " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 02/11] entry: " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] entry: Snapshot " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 03/11] sched: snapshot " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] sched: Snapshot " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 04/11] alpha: snapshot " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] alpha: Snapshot " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 05/11] arm: snapshot " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] ARM: Snapshot " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 06/11] arm64: snapshot " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] arm64: Snapshot " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` Mark Rutland [this message]
2021-11-30 23:08   ` [tip: core/entry] microblaze: " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 08/11] openrisc: snapshot " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] openrisc: Snapshot " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 09/11] powerpc: avoid discarding flags in system_call_exception() Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] powerpc: Avoid " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 10/11] powerpc: snapshot thread flags Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] powerpc: Snapshot " tip-bot2 for Mark Rutland
2021-11-29 13:06 ` [PATCH v8 11/11] x86: snapshot " Mark Rutland
2021-11-30 23:08   ` [tip: core/entry] x86: Snapshot " tip-bot2 for Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211129130653.2037928-8-mark.rutland@arm.com \
    --to=mark.rutland@arm.com \
    --cc=benh@kernel.crashing.org \
    --cc=boqun.feng@gmail.com \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=dvyukov@google.com \
    --cc=efuller@redhat.com \
    --cc=elver@google.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=jonas@southpole.se \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=luto@kernel.org \
    --cc=mattst88@gmail.com \
    --cc=michal.simek@xilinx.com \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=rth@twiddle.net \
    --cc=shorne@gmail.com \
    --cc=stefan.kristiansson@saunalahti.fi \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.