All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Pankaj Gupta" <pankaj.gupta.linux@gmail.com>,
	"Gavin Shan" <gshan@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Michal Prívozník" <mprivozn@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	"Sebastien Boeuf" <sebastien.boeuf@intel.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Hui Zhu" <teawater@gmail.com>
Subject: [PATCH v1 0/8] virtio-mem: Support "prealloc=on"
Date: Tue, 30 Nov 2021 11:41:28 +0100	[thread overview]
Message-ID: <20211130104136.40927-1-david@redhat.com> (raw)

Based-on: <20211130092838.24224-1-david@redhat.com>

Patch #1 - #7 are fully reviewed [1] but did not get picked up yet, so I'm
sending them along here, as they are required to use os_mem_prealloc() in
a safe way once the VM is running.

Support preallocation of memory to make virtio-mem safe to use with
scarce memory resources such as hugetlb. Before acknowledging a plug
request from the guest, we'll try preallcoating memory. If that fails,
we'll fail the request gracefully and warn the usr once.

To fully support huge pages for shared memory, we'll have to adjust shared
memory users, such as virtiofsd, to map guest memory via MAP_NORESERVE as
well, because otherwise, they'll end up overwriting the "reserve=off"
decision made by QEMU and try reserving huge pages for the sparse memory
region.

In the future, we might want to process guest requests, including
preallocating memory, asynchronously via a dedicated iothread.

[1] https://lkml.kernel.org/r/20211004120208.7409-1-david@redhat.com

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Daniel P. Berrangé <berrange@redhat.com>
Cc: Gavin Shan <gshan@redhat.com>
Cc: Hui Zhu <teawater@gmail.com>
Cc: Sebastien Boeuf <sebastien.boeuf@intel.com>
Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Cc: Michal Prívozník <mprivozn@redhat.com>

David Hildenbrand (8):
  util/oslib-posix: Let touch_all_pages() return an error
  util/oslib-posix: Support MADV_POPULATE_WRITE for os_mem_prealloc()
  util/oslib-posix: Introduce and use MemsetContext for
    touch_all_pages()
  util/oslib-posix: Don't create too many threads with small memory or
    little pages
  util/oslib-posix: Avoid creating a single thread with
    MADV_POPULATE_WRITE
  util/oslib-posix: Support concurrent os_mem_prealloc() invocation
  util/oslib-posix: Forward SIGBUS to MCE handler under Linux
  virtio-mem: Support "prealloc=on" option

 hw/virtio/virtio-mem.c         |  39 +++++-
 include/hw/virtio/virtio-mem.h |   4 +
 include/qemu/osdep.h           |   7 +
 softmmu/cpus.c                 |   4 +
 util/oslib-posix.c             | 231 +++++++++++++++++++++++++--------
 5 files changed, 226 insertions(+), 59 deletions(-)

-- 
2.31.1



             reply	other threads:[~2021-11-30 10:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30 10:41 David Hildenbrand [this message]
2021-11-30 10:41 ` [PATCH v1 1/8] util/oslib-posix: Let touch_all_pages() return an error David Hildenbrand
2021-11-30 10:41 ` [PATCH v1 2/8] util/oslib-posix: Support MADV_POPULATE_WRITE for os_mem_prealloc() David Hildenbrand
2021-11-30 10:41 ` [PATCH v1 3/8] util/oslib-posix: Introduce and use MemsetContext for touch_all_pages() David Hildenbrand
2021-11-30 10:41 ` [PATCH v1 4/8] util/oslib-posix: Don't create too many threads with small memory or little pages David Hildenbrand
2021-11-30 10:41 ` [PATCH v1 5/8] util/oslib-posix: Avoid creating a single thread with MADV_POPULATE_WRITE David Hildenbrand
2021-11-30 10:41 ` [PATCH v1 6/8] util/oslib-posix: Support concurrent os_mem_prealloc() invocation David Hildenbrand
2021-11-30 10:41 ` [PATCH v1 7/8] util/oslib-posix: Forward SIGBUS to MCE handler under Linux David Hildenbrand
2021-11-30 10:41 ` [PATCH v1 8/8] virtio-mem: Support "prealloc=on" option David Hildenbrand
2021-11-30 16:32 ` [PATCH v1 0/8] virtio-mem: Support "prealloc=on" Michal Prívozník

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211130104136.40927-1-david@redhat.com \
    --to=david@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=gshan@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mprivozn@redhat.com \
    --cc=mst@redhat.com \
    --cc=pankaj.gupta.linux@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sebastien.boeuf@intel.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.