All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: airlied@linux.ie, daniel.vetter@ffwll.ch, arnd@arndb.de,
	gregkh@linuxfoundation.org,
	James.Bottomley@HansenPartnership.com, deller@gmx.de
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 6/7] agp/sworks: Remove unused variable 'current_size'
Date: Wed,  1 Dec 2021 12:46:44 +0100	[thread overview]
Message-ID: <20211201114645.15384-7-tzimmermann@suse.de> (raw)
In-Reply-To: <20211201114645.15384-1-tzimmermann@suse.de>

Fix the compiler warning

  drivers/char/agp/sworks-agp.c: In function 'serverworks_configure':
  drivers/char/agp/sworks-agp.c:265:37: warning: variable 'current_size' set but not used [-Wunused-but-set-variable]
    265 |         struct aper_size_info_lvl2 *current_size;

by removing the variable.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Helge Deller <deller@gmx.de>
---
 drivers/char/agp/sworks-agp.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/char/agp/sworks-agp.c b/drivers/char/agp/sworks-agp.c
index b15d3d4f71d5..b91da5998dd7 100644
--- a/drivers/char/agp/sworks-agp.c
+++ b/drivers/char/agp/sworks-agp.c
@@ -262,13 +262,10 @@ static void serverworks_tlbflush(struct agp_memory *temp)
 
 static int serverworks_configure(void)
 {
-	struct aper_size_info_lvl2 *current_size;
 	u32 temp;
 	u8 enable_reg;
 	u16 cap_reg;
 
-	current_size = A_SIZE_LVL2(agp_bridge->current_size);
-
 	/* Get the memory mapped registers */
 	pci_read_config_dword(agp_bridge->dev, serverworks_private.mm_addr_ofs, &temp);
 	temp = (temp & PCI_BASE_ADDRESS_MEM_MASK);
-- 
2.34.0


WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: airlied@linux.ie, daniel.vetter@ffwll.ch, arnd@arndb.de,
	gregkh@linuxfoundation.org,
	James.Bottomley@HansenPartnership.com, deller@gmx.de
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH v2 6/7] agp/sworks: Remove unused variable 'current_size'
Date: Wed,  1 Dec 2021 12:46:44 +0100	[thread overview]
Message-ID: <20211201114645.15384-7-tzimmermann@suse.de> (raw)
In-Reply-To: <20211201114645.15384-1-tzimmermann@suse.de>

Fix the compiler warning

  drivers/char/agp/sworks-agp.c: In function 'serverworks_configure':
  drivers/char/agp/sworks-agp.c:265:37: warning: variable 'current_size' set but not used [-Wunused-but-set-variable]
    265 |         struct aper_size_info_lvl2 *current_size;

by removing the variable.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Helge Deller <deller@gmx.de>
---
 drivers/char/agp/sworks-agp.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/char/agp/sworks-agp.c b/drivers/char/agp/sworks-agp.c
index b15d3d4f71d5..b91da5998dd7 100644
--- a/drivers/char/agp/sworks-agp.c
+++ b/drivers/char/agp/sworks-agp.c
@@ -262,13 +262,10 @@ static void serverworks_tlbflush(struct agp_memory *temp)
 
 static int serverworks_configure(void)
 {
-	struct aper_size_info_lvl2 *current_size;
 	u32 temp;
 	u8 enable_reg;
 	u16 cap_reg;
 
-	current_size = A_SIZE_LVL2(agp_bridge->current_size);
-
 	/* Get the memory mapped registers */
 	pci_read_config_dword(agp_bridge->dev, serverworks_private.mm_addr_ofs, &temp);
 	temp = (temp & PCI_BASE_ADDRESS_MEM_MASK);
-- 
2.34.0


  parent reply	other threads:[~2021-12-01 11:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-01 11:46 [PATCH v2 0/7] agp: Various minor fixes Thomas Zimmermann
2021-12-01 11:46 ` Thomas Zimmermann
2021-12-01 11:46 ` [PATCH v2 1/7] agp: Remove trailing whitespaces Thomas Zimmermann
2021-12-01 11:46   ` Thomas Zimmermann
2021-12-01 11:46 ` [PATCH v2 2/7] agp: Include "compat_ioctl.h" where necessary Thomas Zimmermann
2021-12-01 11:46   ` Thomas Zimmermann
2021-12-01 11:46 ` [PATCH v2 3/7] agp: Documentation fixes Thomas Zimmermann
2021-12-01 11:46   ` Thomas Zimmermann
2021-12-01 11:46 ` [PATCH v2 4/7] agp/ati: Return error from ati_create_page_map() Thomas Zimmermann
2021-12-01 11:46   ` Thomas Zimmermann
2021-12-01 11:46 ` [PATCH v2 5/7] agp/nvidia: Declare value returned by readl() as unused Thomas Zimmermann
2021-12-01 11:46   ` Thomas Zimmermann
2021-12-01 11:46 ` Thomas Zimmermann [this message]
2021-12-01 11:46   ` [PATCH v2 6/7] agp/sworks: Remove unused variable 'current_size' Thomas Zimmermann
2021-12-01 11:46 ` [PATCH v2 7/7] agp/via: " Thomas Zimmermann
2021-12-01 11:46   ` Thomas Zimmermann
2022-01-13  8:51 ` [PATCH v2 0/7] agp: Various minor fixes Thomas Zimmermann
2022-01-13  8:51   ` Thomas Zimmermann
2022-01-13 16:42   ` Helge Deller
2022-01-13 16:42     ` Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211201114645.15384-7-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=airlied@linux.ie \
    --cc=arnd@arndb.de \
    --cc=daniel.vetter@ffwll.ch \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.