From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Jiri Kosina <jikos@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: [PATCH 2/4] HID: bigbenff: prevent null pointer dereference
Date: Thu, 2 Dec 2021 10:53:32 +0100 [thread overview]
Message-ID: <20211202095334.14399-3-benjamin.tissoires@redhat.com> (raw)
In-Reply-To: <20211202095334.14399-1-benjamin.tissoires@redhat.com>
When emulating the device through uhid, there is a chance we don't have
output reports and so report_field is null.
Cc: stable@vger.kernel.org
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/hid/hid-bigbenff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-bigbenff.c b/drivers/hid/hid-bigbenff.c
index db6da21ade06..74ad8bf98bfd 100644
--- a/drivers/hid/hid-bigbenff.c
+++ b/drivers/hid/hid-bigbenff.c
@@ -191,7 +191,7 @@ static void bigben_worker(struct work_struct *work)
struct bigben_device, worker);
struct hid_field *report_field = bigben->report->field[0];
- if (bigben->removed)
+ if (bigben->removed || !report_field)
return;
if (bigben->work_led) {
--
2.33.1
next prev parent reply other threads:[~2021-12-02 9:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 9:53 [PATCH 0/4] HID: followup of uhid crashes, and couple of core Benjamin Tissoires
2021-12-02 9:53 ` [PATCH 1/4] HID: sony: fix error path in probe Benjamin Tissoires
2021-12-02 9:53 ` Benjamin Tissoires [this message]
2021-12-02 9:53 ` [PATCH 3/4] HID: add suspend/resume helpers Benjamin Tissoires
2021-12-02 9:53 ` [PATCH 4/4] HID: do not inline some hid_hw_ functions Benjamin Tissoires
2021-12-02 11:48 ` [PATCH 0/4] HID: followup of uhid crashes, and couple of core Greg Kroah-Hartman
2021-12-02 16:48 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202095334.14399-3-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.