From: mwilck@suse.com
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@redhat.com, Martin Wilck <mwilck@suse.com>
Subject: [dm-devel] [PATCH] multipathd.service: add dependency on systemd-udevd-kernel.socket
Date: Thu, 2 Dec 2021 11:48:12 +0100 [thread overview]
Message-ID: <20211202104812.27529-1-mwilck@suse.com> (raw)
From: Martin Wilck <mwilck@suse.com>
Since f42d918 ("multipathd: Remove dependency on
systemd-udev-settle.service"), multipathd has no dependencies on
udev any more. In reality, multipathd depends quite heavily on udev.
multipathd startup succeeds indeed if udevd isn't running. Connecting to the
udev monitor netlink socket works, too, and if udevd is started later on,
multipathd will receive events over this socket. multipathd doesn't connect to
the udev control socket, but it does attempt to trigger uevents using
sysfs. For these events to be processed, the udev kernel socket must be
listening. For that, it's sufficient to depend on systemd-udevd-kernel.socket,
which will start udevd on demand if it isn't running.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
Note: I'd like to get this merged into the current upstream PR.
---
multipathd/multipathd.service | 2 ++
1 file changed, 2 insertions(+)
diff --git a/multipathd/multipathd.service b/multipathd/multipathd.service
index 87cb534..1919b38 100644
--- a/multipathd/multipathd.service
+++ b/multipathd/multipathd.service
@@ -2,6 +2,8 @@
Description=Device-Mapper Multipath Device Controller
Before=iscsi.service iscsid.service lvm2-activation-early.service
Before=local-fs-pre.target blk-availability.service shutdown.target
+Wants=systemd-udevd-kernel.socket
+After=systemd-udevd-kernel.socket
After=multipathd.socket systemd-remount-fs.service
DefaultDependencies=no
Conflicts=shutdown.target
--
2.34.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next reply other threads:[~2021-12-02 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 10:48 mwilck [this message]
2021-12-02 17:16 ` [dm-devel] [PATCH] multipathd.service: add dependency on systemd-udevd-kernel.socket Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202104812.27529-1-mwilck@suse.com \
--to=mwilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.