All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: <qemu-ppc@nongnu.org>, <qemu-devel@nongnu.org>
Cc: "Frederic Barrat" <fbarrat@linux.ibm.com>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"Greg Kurz" <groug@kaod.org>, "Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH 11/14] ppc/pnv: Compute the PHB index from the PHB4 PEC model
Date: Thu, 2 Dec 2021 15:42:32 +0100	[thread overview]
Message-ID: <20211202144235.1276352-12-clg@kaod.org> (raw)
In-Reply-To: <20211202144235.1276352-1-clg@kaod.org>

Use the num_stacks class attribute to compute the PHB index depending
on the PEC index :

  * PEC0 provides 1 PHB  (PHB0)
  * PEC1 provides 2 PHBs (PHB1 and PHB2)
  * PEC2 provides 3 PHBs (PHB3, PHB4 and PHB5)

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/pci-host/pnv_phb4_pec.c | 16 ++++++++++++++++
 hw/ppc/pnv.c               |  4 +---
 2 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/hw/pci-host/pnv_phb4_pec.c b/hw/pci-host/pnv_phb4_pec.c
index 293909b5cb90..a7dd4173d598 100644
--- a/hw/pci-host/pnv_phb4_pec.c
+++ b/hw/pci-host/pnv_phb4_pec.c
@@ -374,6 +374,19 @@ static void pnv_pec_instance_init(Object *obj)
     }
 }
 
+static int pnv_pec_phb_offset(PnvPhb4PecState *pec)
+{
+    PnvPhb4PecClass *pecc = PNV_PHB4_PEC_GET_CLASS(pec);
+    int index = pec->index;
+    int offset = 0;
+
+    while (index--) {
+        offset += pecc->num_stacks[index];
+    }
+
+    return offset;
+}
+
 static void pnv_pec_realize(DeviceState *dev, Error **errp)
 {
     PnvPhb4PecState *pec = PNV_PHB4_PEC(dev);
@@ -394,8 +407,10 @@ static void pnv_pec_realize(DeviceState *dev, Error **errp)
     for (i = 0; i < pec->num_stacks; i++) {
         PnvPhb4PecStack *stack = &pec->stacks[i];
         Object *stk_obj = OBJECT(stack);
+        int phb_id = pnv_pec_phb_offset(pec) + i;
 
         object_property_set_int(stk_obj, "stack-no", i, &error_abort);
+        object_property_set_int(stk_obj, "phb-id", phb_id, &error_abort);
         object_property_set_link(stk_obj, "pec", OBJECT(pec), &error_abort);
         if (!qdev_realize(DEVICE(stk_obj), NULL, errp)) {
             return;
@@ -538,6 +553,7 @@ static void pnv_pec_stk_instance_init(Object *obj)
     PnvPhb4PecStack *stack = PNV_PHB4_PEC_STACK(obj);
 
     object_initialize_child(obj, "phb", &stack->phb, TYPE_PNV_PHB4);
+    object_property_add_alias(obj, "phb-id", OBJECT(&stack->phb), "index");
 }
 
 static void pnv_pec_stk_realize(DeviceState *dev, Error **errp)
diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 957f0bdfaa6b..f8b0b2a28383 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -1371,7 +1371,6 @@ static void pnv_chip_power9_phb_realize(PnvChip *chip, Error **errp)
 {
     Pnv9Chip *chip9 = PNV9_CHIP(chip);
     int i, j;
-    int phb_id = 0;
 
     for (i = 0; i < chip->num_pecs; i++) {
         PnvPhb4PecState *pec = &chip9->pecs[i];
@@ -1396,11 +1395,10 @@ static void pnv_chip_power9_phb_realize(PnvChip *chip, Error **errp)
         pnv_xscom_add_subregion(chip, pec_nest_base, &pec->nest_regs_mr);
         pnv_xscom_add_subregion(chip, pec_pci_base, &pec->pci_regs_mr);
 
-        for (j = 0; j < pec->num_stacks; j++, phb_id++) {
+        for (j = 0; j < pec->num_stacks; j++) {
             PnvPhb4PecStack *stack = &pec->stacks[j];
             Object *obj = OBJECT(&stack->phb);
 
-            object_property_set_int(obj, "index", phb_id, &error_fatal);
             object_property_set_int(obj, "chip-id", chip->chip_id,
                                     &error_fatal);
             object_property_set_int(obj, "version", pecc->version,
-- 
2.31.1



  parent reply	other threads:[~2021-12-02 14:53 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02 14:42 [PATCH 00/14] ppc/pnv: Add support for user created PHB3/PHB4 devices Cédric Le Goater
2021-12-02 14:42 ` [PATCH 01/14] ppc/pnv: Reduce the maximum of PHB3 devices Cédric Le Goater
2021-12-02 17:27   ` Daniel Henrique Barboza
2021-12-02 17:34     ` Cédric Le Goater
2021-12-07  9:40   ` Frederic Barrat
2021-12-07 10:10     ` Cédric Le Goater
2021-12-02 14:42 ` [PATCH 02/14] ppc/pnv: Drop the "num-phbs" property Cédric Le Goater
2021-12-02 17:27   ` Daniel Henrique Barboza
2021-12-07  9:41   ` Frederic Barrat
2021-12-02 14:42 ` [PATCH 03/14] ppc/pnv: Move mapping of the PHB3 CQ regions under pnv_pbcq_realize() Cédric Le Goater
2021-12-02 17:29   ` Daniel Henrique Barboza
2021-12-07  9:41   ` Frederic Barrat
2021-12-02 14:42 ` [PATCH 04/14] ppc/pnv: Introduce support for user created PHB3 devices Cédric Le Goater
2021-12-02 17:31   ` Daniel Henrique Barboza
2021-12-07  9:47   ` Frederic Barrat
2021-12-07 10:17     ` Cédric Le Goater
2021-12-02 14:42 ` [PATCH 05/14] ppc/pnv: Reparent user created PHB3 devices to the PnvChip Cédric Le Goater
2021-12-02 17:32   ` Daniel Henrique Barboza
2021-12-07  9:51   ` Frederic Barrat
2021-12-02 14:42 ` [PATCH 06/14] ppc/pnv: Complete user created PHB3 devices Cédric Le Goater
2021-12-02 17:33   ` Daniel Henrique Barboza
2021-12-07  9:53   ` Frederic Barrat
2021-12-07 10:19     ` Cédric Le Goater
2021-12-02 14:42 ` [PATCH 07/14] ppc/pnv: Introduce a num_pecs class attribute for PHB4 PEC devices Cédric Le Goater
2021-12-02 17:34   ` Daniel Henrique Barboza
2021-12-07 10:00   ` Frederic Barrat
2021-12-07 10:45     ` Cédric Le Goater
2021-12-07 14:03       ` Frederic Barrat
2021-12-07 14:34         ` Cédric Le Goater
2021-12-02 14:42 ` [PATCH 08/14] ppc/pnv: Introduce version and device_id class atributes for PHB4 devices Cédric Le Goater
2021-12-02 17:37   ` Daniel Henrique Barboza
2021-12-07 10:01   ` Frederic Barrat
2021-12-07 10:21     ` Cédric Le Goater
2021-12-02 14:42 ` [PATCH 09/14] ppc/pnv: Introduce a "chip" property under the PHB4 model Cédric Le Goater
2021-12-02 17:37   ` Daniel Henrique Barboza
2021-12-07 10:01   ` Frederic Barrat
2021-12-02 14:42 ` [PATCH 10/14] ppc/pnv: Introduce a num_stack class attribute Cédric Le Goater
2021-12-02 17:44   ` Daniel Henrique Barboza
2021-12-07 10:04   ` Frederic Barrat
2021-12-02 14:42 ` Cédric Le Goater [this message]
2021-12-02 17:47   ` [PATCH 11/14] ppc/pnv: Compute the PHB index from the PHB4 PEC model Daniel Henrique Barboza
2021-12-07 10:06   ` Frederic Barrat
2021-12-07 10:24     ` Cédric Le Goater
2021-12-02 14:42 ` [PATCH 12/14] ppc/pnv: Remove "system-memory" property for he " Cédric Le Goater
2021-12-02 17:47   ` Daniel Henrique Barboza
2021-12-07 10:08   ` Frederic Barrat
2021-12-07 10:29     ` Cédric Le Goater
2021-12-07 10:11   ` Frederic Barrat
2021-12-02 14:42 ` [PATCH 13/14] ppc/pnv: Move realize of PEC stacks under the " Cédric Le Goater
2021-12-02 17:49   ` Daniel Henrique Barboza
2021-12-07 10:10   ` Frederic Barrat
2021-12-07 10:30     ` Cédric Le Goater
2021-12-02 14:42 ` [PATCH 14/14] ppc/pnv: Introduce support for user created PHB4 devices Cédric Le Goater
2021-12-02 17:49   ` Daniel Henrique Barboza
2021-12-07 10:12   ` Frederic Barrat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211202144235.1276352-12-clg@kaod.org \
    --to=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=fbarrat@linux.ibm.com \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.