All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Subject: [PATCH 5/8] drm/i915/migrate: fix length calculation
Date: Thu,  2 Dec 2021 18:15:12 +0000	[thread overview]
Message-ID: <20211202181515.2794397-5-matthew.auld@intel.com> (raw)
In-Reply-To: <20211202181515.2794397-1-matthew.auld@intel.com>

No need to insert PTEs for the PTE window itself, also foreach expects a
length not an end offset, which could be gigantic here with a second
engine.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Ramalingam C <ramalingam.c@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
index cb0bb3b94644..2076e24e0489 100644
--- a/drivers/gpu/drm/i915/gt/intel_migrate.c
+++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
@@ -136,7 +136,7 @@ static struct i915_address_space *migrate_vm(struct intel_gt *gt)
 			goto err_vm;
 
 		/* Now allow the GPU to rewrite the PTE via its own ppGTT */
-		vm->vm.foreach(&vm->vm, base, base + sz, insert_pte, &d);
+		vm->vm.foreach(&vm->vm, base, d.offset - base, insert_pte, &d);
 	}
 
 	return &vm->vm;
-- 
2.31.1


WARNING: multiple messages have this Message-ID (diff)
From: Matthew Auld <matthew.auld@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 5/8] drm/i915/migrate: fix length calculation
Date: Thu,  2 Dec 2021 18:15:12 +0000	[thread overview]
Message-ID: <20211202181515.2794397-5-matthew.auld@intel.com> (raw)
In-Reply-To: <20211202181515.2794397-1-matthew.auld@intel.com>

No need to insert PTEs for the PTE window itself, also foreach expects a
length not an end offset, which could be gigantic here with a second
engine.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Ramalingam C <ramalingam.c@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
index cb0bb3b94644..2076e24e0489 100644
--- a/drivers/gpu/drm/i915/gt/intel_migrate.c
+++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
@@ -136,7 +136,7 @@ static struct i915_address_space *migrate_vm(struct intel_gt *gt)
 			goto err_vm;
 
 		/* Now allow the GPU to rewrite the PTE via its own ppGTT */
-		vm->vm.foreach(&vm->vm, base, base + sz, insert_pte, &d);
+		vm->vm.foreach(&vm->vm, base, d.offset - base, insert_pte, &d);
 	}
 
 	return &vm->vm;
-- 
2.31.1


  parent reply	other threads:[~2021-12-02 18:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02 18:15 [PATCH 1/8] drm/i915/migrate: don't check the scratch page Matthew Auld
2021-12-02 18:15 ` [Intel-gfx] " Matthew Auld
2021-12-02 18:15 ` [PATCH 2/8] drm/i915/gtt: add xehpsdv_ppgtt_insert_entry Matthew Auld
2021-12-02 18:15   ` [Intel-gfx] " Matthew Auld
2021-12-02 18:15 ` [PATCH 3/8] drm/i915/gtt: add gtt mappable plumbing Matthew Auld
2021-12-02 18:15   ` [Intel-gfx] " Matthew Auld
2021-12-02 18:15 ` [PATCH 4/8] drm/i915/migrate: fix offset calculation Matthew Auld
2021-12-02 18:15   ` [Intel-gfx] " Matthew Auld
2021-12-02 18:15 ` Matthew Auld [this message]
2021-12-02 18:15   ` [Intel-gfx] [PATCH 5/8] drm/i915/migrate: fix length calculation Matthew Auld
2021-12-02 18:15 ` [PATCH 6/8] drm/i915/selftests: handle object rounding Matthew Auld
2021-12-02 18:15   ` [Intel-gfx] " Matthew Auld
2021-12-02 18:15 ` [PATCH 7/8] drm/i915/migrate: add acceleration support for DG2 Matthew Auld
2021-12-02 18:15   ` [Intel-gfx] " Matthew Auld
2021-12-02 18:15 ` [PATCH 8/8] drm/i915/migrate: turn on acceleration " Matthew Auld
2021-12-02 18:15   ` [Intel-gfx] " Matthew Auld
2021-12-02 18:54 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/8] drm/i915/migrate: don't check the scratch page Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211202181515.2794397-5-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.