All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: [PATCH v2 net-next 15/23] net: add net device refcount tracker to struct neigh_parms
Date: Thu,  2 Dec 2021 18:46:32 -0800	[thread overview]
Message-ID: <20211203024640.1180745-16-eric.dumazet@gmail.com> (raw)
In-Reply-To: <20211203024640.1180745-1-eric.dumazet@gmail.com>

From: Eric Dumazet <edumazet@google.com>

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 include/net/neighbour.h | 1 +
 net/core/neighbour.c    | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/include/net/neighbour.h b/include/net/neighbour.h
index 5fffb783670a6d2432896a06d3044f6ac83feaf4..937389e04c8e26b6f5a4c1362a90930145671889 100644
--- a/include/net/neighbour.h
+++ b/include/net/neighbour.h
@@ -70,6 +70,7 @@ enum {
 struct neigh_parms {
 	possible_net_t net;
 	struct net_device *dev;
+	netdevice_tracker dev_tracker;
 	struct list_head list;
 	int	(*neigh_setup)(struct neighbour *);
 	struct neigh_table *tbl;
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 56de74f8d2b1c896c478ded2c659b0207d7b5c75..dd271ffedf11cdd3a1b6bf5fad7b0ddcc5d41e80 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -1666,13 +1666,13 @@ struct neigh_parms *neigh_parms_alloc(struct net_device *dev,
 		refcount_set(&p->refcnt, 1);
 		p->reachable_time =
 				neigh_rand_reach_time(NEIGH_VAR(p, BASE_REACHABLE_TIME));
-		dev_hold(dev);
+		dev_hold_track(dev, &p->dev_tracker, GFP_KERNEL);
 		p->dev = dev;
 		write_pnet(&p->net, net);
 		p->sysctl_table = NULL;
 
 		if (ops->ndo_neigh_setup && ops->ndo_neigh_setup(dev, p)) {
-			dev_put(dev);
+			dev_put_track(dev, &p->dev_tracker);
 			kfree(p);
 			return NULL;
 		}
@@ -1703,7 +1703,7 @@ void neigh_parms_release(struct neigh_table *tbl, struct neigh_parms *parms)
 	list_del(&parms->list);
 	parms->dead = 1;
 	write_unlock_bh(&tbl->lock);
-	dev_put(parms->dev);
+	dev_put_track(parms->dev, &parms->dev_tracker);
 	call_rcu(&parms->rcu_head, neigh_rcu_free_parms);
 }
 EXPORT_SYMBOL(neigh_parms_release);
-- 
2.34.1.400.ga245620fadb-goog


  parent reply	other threads:[~2021-12-03  2:48 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03  2:46 [PATCH v2 net-next 00/23] net: add preliminary netdev refcount tracking Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 01/23] lib: add reference counting tracking infrastructure Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 02/23] lib: add tests for reference tracker Eric Dumazet
2021-12-04 23:39   ` kernel test robot
2021-12-04 23:39     ` kernel test robot
2021-12-05  0:45     ` Eric Dumazet
2021-12-05  0:45       ` Eric Dumazet
2021-12-05  3:14       ` Eric Dumazet
2021-12-05  3:14         ` Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 03/23] net: add dev_hold_track() and dev_put_track() helpers Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 04/23] net: add net device refcount tracker to struct netdev_rx_queue Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 05/23] net: add net device refcount tracker to struct netdev_queue Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 06/23] net: add net device refcount tracker to ethtool_phys_id() Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 07/23] net: add net device refcount tracker to dev_ifsioc() Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 08/23] drop_monitor: add net device refcount tracker Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 09/23] net: dst: add net device refcount tracking to dst_entry Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 10/23] ipv6: add net device refcount tracker to rt6_probe_deferred() Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 11/23] sit: add net device refcount tracking to ip_tunnel Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 12/23] ipv6: add net device refcount tracker to struct ip6_tnl Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 13/23] net: add net device refcount tracker to struct neighbour Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 14/23] net: add net device refcount tracker to struct pneigh_entry Eric Dumazet
2021-12-03  2:46 ` Eric Dumazet [this message]
2021-12-03  2:46 ` [PATCH v2 net-next 16/23] net: add net device refcount tracker to struct netdev_adjacent Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 17/23] ipv6: add net device refcount tracker to struct inet6_dev Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 18/23] ipv4: add net device refcount tracker to struct in_device Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 19/23] net/sched: add net device refcount tracker to struct Qdisc Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 20/23] net: linkwatch: add net device refcount tracker Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 21/23] net: failover: " Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 22/23] ipmr, ip6mr: add net device refcount tracker to struct vif_device Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 23/23] netpoll: add net device refcount tracker to struct netpoll Eric Dumazet
2021-12-04  0:47 ` [PATCH v2 net-next 00/23] net: add preliminary netdev refcount tracking Jakub Kicinski
2021-12-04  1:00   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211203024640.1180745-16-eric.dumazet@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dvyukov@google.com \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.