All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: [PATCH v2 net-next 16/23] net: add net device refcount tracker to struct netdev_adjacent
Date: Thu,  2 Dec 2021 18:46:33 -0800	[thread overview]
Message-ID: <20211203024640.1180745-17-eric.dumazet@gmail.com> (raw)
In-Reply-To: <20211203024640.1180745-1-eric.dumazet@gmail.com>

From: Eric Dumazet <edumazet@google.com>

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 net/core/dev.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 1740d6cfe86b58359cceaec7ee9cc015a3843723..4420086f3aeb34614fc8222206dff2b2caa31d02 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6537,6 +6537,7 @@ static __latent_entropy void net_rx_action(struct softirq_action *h)
 
 struct netdev_adjacent {
 	struct net_device *dev;
+	netdevice_tracker dev_tracker;
 
 	/* upper master flag, there can only be one master device per list */
 	bool master;
@@ -7301,7 +7302,7 @@ static int __netdev_adjacent_dev_insert(struct net_device *dev,
 	adj->ref_nr = 1;
 	adj->private = private;
 	adj->ignore = false;
-	dev_hold(adj_dev);
+	dev_hold_track(adj_dev, &adj->dev_tracker, GFP_KERNEL);
 
 	pr_debug("Insert adjacency: dev %s adj_dev %s adj->ref_nr %d; dev_hold on %s\n",
 		 dev->name, adj_dev->name, adj->ref_nr, adj_dev->name);
@@ -7330,8 +7331,8 @@ static int __netdev_adjacent_dev_insert(struct net_device *dev,
 	if (netdev_adjacent_is_neigh_list(dev, adj_dev, dev_list))
 		netdev_adjacent_sysfs_del(dev, adj_dev->name, dev_list);
 free_adj:
+	dev_put_track(adj_dev, &adj->dev_tracker);
 	kfree(adj);
-	dev_put(adj_dev);
 
 	return ret;
 }
@@ -7372,7 +7373,7 @@ static void __netdev_adjacent_dev_remove(struct net_device *dev,
 	list_del_rcu(&adj->list);
 	pr_debug("adjacency: dev_put for %s, because link removed from %s to %s\n",
 		 adj_dev->name, dev->name, adj_dev->name);
-	dev_put(adj_dev);
+	dev_put_track(adj_dev, &adj->dev_tracker);
 	kfree_rcu(adj, rcu);
 }
 
-- 
2.34.1.400.ga245620fadb-goog


  parent reply	other threads:[~2021-12-03  2:48 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03  2:46 [PATCH v2 net-next 00/23] net: add preliminary netdev refcount tracking Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 01/23] lib: add reference counting tracking infrastructure Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 02/23] lib: add tests for reference tracker Eric Dumazet
2021-12-04 23:39   ` kernel test robot
2021-12-04 23:39     ` kernel test robot
2021-12-05  0:45     ` Eric Dumazet
2021-12-05  0:45       ` Eric Dumazet
2021-12-05  3:14       ` Eric Dumazet
2021-12-05  3:14         ` Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 03/23] net: add dev_hold_track() and dev_put_track() helpers Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 04/23] net: add net device refcount tracker to struct netdev_rx_queue Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 05/23] net: add net device refcount tracker to struct netdev_queue Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 06/23] net: add net device refcount tracker to ethtool_phys_id() Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 07/23] net: add net device refcount tracker to dev_ifsioc() Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 08/23] drop_monitor: add net device refcount tracker Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 09/23] net: dst: add net device refcount tracking to dst_entry Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 10/23] ipv6: add net device refcount tracker to rt6_probe_deferred() Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 11/23] sit: add net device refcount tracking to ip_tunnel Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 12/23] ipv6: add net device refcount tracker to struct ip6_tnl Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 13/23] net: add net device refcount tracker to struct neighbour Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 14/23] net: add net device refcount tracker to struct pneigh_entry Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 15/23] net: add net device refcount tracker to struct neigh_parms Eric Dumazet
2021-12-03  2:46 ` Eric Dumazet [this message]
2021-12-03  2:46 ` [PATCH v2 net-next 17/23] ipv6: add net device refcount tracker to struct inet6_dev Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 18/23] ipv4: add net device refcount tracker to struct in_device Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 19/23] net/sched: add net device refcount tracker to struct Qdisc Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 20/23] net: linkwatch: add net device refcount tracker Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 21/23] net: failover: " Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 22/23] ipmr, ip6mr: add net device refcount tracker to struct vif_device Eric Dumazet
2021-12-03  2:46 ` [PATCH v2 net-next 23/23] netpoll: add net device refcount tracker to struct netpoll Eric Dumazet
2021-12-04  0:47 ` [PATCH v2 net-next 00/23] net: add preliminary netdev refcount tracking Jakub Kicinski
2021-12-04  1:00   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211203024640.1180745-17-eric.dumazet@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dvyukov@google.com \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.