From: "Marek Behún" <kabel@kernel.org>
To: Vinod Koul <vkoul@kernel.org>, pali@kernel.org
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
linux-phy@lists.infradead.org,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH phy 2/6] phy: marvell: phy-mvebu-a3700-comphy: Add native kernel implementation
Date: Fri, 3 Dec 2021 21:58:37 +0100 [thread overview]
Message-ID: <20211203215837.53d2bbc4@thinkpad> (raw)
In-Reply-To: <YZyXoAofmLeqzNBh@matsya>
On Tue, 23 Nov 2021 12:56:24 +0530
Vinod Koul <vkoul@kernel.org> wrote:
> > +#define COMPHY_SYNC_MASK_GEN_REG 0x25
> > +#define PHY_GEN_MAX_OFFSET 10
> > +#define PHY_GEN_MAX_MASK (3 << PHY_GEN_MAX_OFFSET)
>
> Pls use GENMASK()
Dear Vinor, Pali,
I have refactored this driver thoroughly to kernel standards (without
functional changes) and fixed a lot of register name definitions (they
didn't align with Functional Specification). (I have also prepared
this fixes for TF-A, but will need to rebase them.)
I have also applied one functional change to fix a bug I found, but
still need to fix another bug.
Hopefully I will have a solution tomorrow or on Sunday.
Marek
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-12-03 20:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 18:42 [PATCH phy 0/6] Armada 3720 comphy native implementation Marek Behún
2021-10-28 18:42 ` [PATCH phy 1/6] phy: marvell: phy-mvebu-a3700-comphy: Remove port from driver configuration Marek Behún
2021-11-09 9:55 ` Miquel Raynal
2021-10-28 18:42 ` [PATCH phy 2/6] phy: marvell: phy-mvebu-a3700-comphy: Add native kernel implementation Marek Behún
2021-11-09 10:09 ` Miquel Raynal
2021-11-23 7:26 ` Vinod Koul
2021-11-25 10:58 ` Pali Rohár
2021-12-03 20:58 ` Marek Behún [this message]
2021-10-28 18:42 ` [PATCH phy 3/6] arm64: dts: marvell: armada-37xx: Add xtal clock to comphy node Marek Behún
2021-10-28 18:42 ` [PATCH phy 4/6] Revert "ata: ahci: mvebu: Make SATA PHY optional for Armada 3720" Marek Behún
2021-11-09 10:10 ` Miquel Raynal
2021-10-28 18:42 ` [PATCH phy 5/6] Revert "usb: host: xhci: mvebu: make USB 3.0 " Marek Behún
2021-11-09 10:10 ` Miquel Raynal
2021-10-28 18:42 ` [PATCH phy 6/6] Revert "PCI: aardvark: Fix initialization with old Marvell's Arm Trusted Firmware" Marek Behún
2021-11-09 10:10 ` Miquel Raynal
2021-11-10 19:45 ` [PATCH phy 0/6] Armada 3720 comphy native implementation Marek Behún
2021-11-11 14:25 ` Vinod Koul
2021-11-11 14:32 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211203215837.53d2bbc4@thinkpad \
--to=kabel@kernel.org \
--cc=kishon@ti.com \
--cc=linux-phy@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pali@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.