From: Ameer Hamza <amhamza.mgc@gmail.com>
To: vkuznets@redhat.com
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
pbonzini@redhat.com, seanjc@google.com, wanpengli@tencent.com,
jmattson@google.com, joro@8bytes.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com,
Ameer Hamza <amhamza.mgc@gmail.com>
Subject: [PATCH v3] KVM: x86: fix for missing initialization of return status variable
Date: Mon, 6 Dec 2021 21:45:03 +0500 [thread overview]
Message-ID: <20211206164503.135917-1-amhamza.mgc@gmail.com> (raw)
In-Reply-To: <20211206160813.GA37599@hamza-OptiPlex-7040>
If undefined ioctl number is passed to the kvm_vcpu_ioctl_device_attr
ioctl, we should trigger KVM_BUG_ON() and return with EIO to silent
coverity warning.
Addresses-Coverity: 1494124 ("Uninitialized scalar variable")
Signed-off-by: Ameer Hamza <amhamza.mgc@gmail.com>
---
Changes in v3:
Added KVM_BUG_ON() as default case and returned -EIO
---
arch/x86/kvm/x86.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index e0aa4dd53c7f..b37068f847ff 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -5019,6 +5019,9 @@ static int kvm_vcpu_ioctl_device_attr(struct kvm_vcpu *vcpu,
case KVM_SET_DEVICE_ATTR:
r = kvm_arch_tsc_set_attr(vcpu, &attr);
break;
+ default:
+ KVM_BUG_ON(1, vcpu->kvm);
+ r = -EIO;
}
return r;
--
2.25.1
next prev parent reply other threads:[~2021-12-06 16:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 19:47 [PATCH] KVM: x86: fix for missing initialization of return status variable Ameer Hamza
2021-12-06 9:06 ` Vitaly Kuznetsov
2021-12-06 9:32 ` Ameer Hamza
2021-12-06 10:24 ` [PATCH v2] " Ameer Hamza
2021-12-06 15:37 ` Sean Christopherson
2021-12-06 16:08 ` Ameer Hamza
2021-12-06 16:45 ` Ameer Hamza [this message]
2021-12-06 17:02 ` [PATCH v3] " Sean Christopherson
2021-12-06 17:27 ` Ameer Hamza
2021-12-06 18:01 ` Sean Christopherson
2021-12-06 18:40 ` Ameer Hamza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206164503.135917-1-amhamza.mgc@gmail.com \
--to=amhamza.mgc@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.