All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mateusz Jończyk" <mat.jonczyk@o2.pl>
To: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Mateusz Jończyk" <mat.jonczyk@o2.pl>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: [PATCH v4 2/9] rtc: change return values of mc146818_get_time()
Date: Fri, 10 Dec 2021 21:01:24 +0100	[thread overview]
Message-ID: <20211210200131.153887-3-mat.jonczyk@o2.pl> (raw)
In-Reply-To: <20211210200131.153887-1-mat.jonczyk@o2.pl>

No function is checking mc146818_get_time() return values yet, so
correct them to make them more customary.

Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>

---

v4: Added this patch

 drivers/rtc/rtc-mc146818-lib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-mc146818-lib.c b/drivers/rtc/rtc-mc146818-lib.c
index dcfaf09946ee..c186c8c4982b 100644
--- a/drivers/rtc/rtc-mc146818-lib.c
+++ b/drivers/rtc/rtc-mc146818-lib.c
@@ -25,7 +25,7 @@ unsigned int mc146818_get_time(struct rtc_time *time)
 	if (WARN_ON_ONCE((CMOS_READ(RTC_VALID) & 0x40) != 0)) {
 		spin_unlock_irqrestore(&rtc_lock, flags);
 		memset(time, 0xff, sizeof(*time));
-		return 0;
+		return -EIO;
 	}
 
 	/*
@@ -116,7 +116,7 @@ unsigned int mc146818_get_time(struct rtc_time *time)
 
 	time->tm_mon--;
 
-	return RTC_24H;
+	return 0;
 }
 EXPORT_SYMBOL_GPL(mc146818_get_time);
 
-- 
2.25.1


  parent reply	other threads:[~2021-12-10 20:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 20:01 [PATCH v4 0/9] rtc-cmos,rtc-mc146818-lib: fixes Mateusz Jończyk
2021-12-10 20:01 ` [PATCH v4 1/9] rtc-cmos: take rtc_lock while reading from CMOS Mateusz Jończyk
2021-12-10 20:01 ` Mateusz Jończyk [this message]
2021-12-10 20:01 ` [PATCH v4 3/9] Check return value from mc146818_get_time() Mateusz Jończyk
2021-12-10 20:01   ` Mateusz Jończyk
2021-12-10 20:01 ` [PATCH v4 4/9] rtc-mc146818-lib: fix RTC presence check Mateusz Jończyk
2021-12-10 20:01 ` [PATCH v4 5/9] rtc-mc146818-lib: extract mc146818_avoid_UIP Mateusz Jończyk
2021-12-10 20:01 ` [PATCH v4 6/9] rtc-mc146818-lib: refactor mc146818_get_time Mateusz Jończyk
2021-12-10 20:01 ` [PATCH v4 7/9] rtc-mc146818-lib: refactor mc146818_does_rtc_work Mateusz Jończyk
2021-12-10 20:01 ` [PATCH v4 8/9] rtc-cmos: avoid UIP when reading alarm time Mateusz Jończyk
2021-12-10 20:03   ` [DEBUG PATCH v4] rtc-cmos: cmos_read_alarm bug demonstration Mateusz Jończyk
2021-12-10 20:01 ` [PATCH v4 9/9] rtc-cmos: avoid UIP when writing alarm time Mateusz Jończyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211210200131.153887-3-mat.jonczyk@o2.pl \
    --to=mat.jonczyk@o2.pl \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.