From: Amjad Ouled-Ameur <aouledameur@baylibre.com> To: khilman@baylibre.com Cc: Amjad Ouled-Ameur <aouledameur@baylibre.com>, p.zabel@pengutronix.de, balbi@kernel.org, jbrunet@baylibre.com, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, martin.blumenstingl@googlemail.com Subject: [PATCH v5 2/3] phy: amlogic: meson8b-usb2: Use dev_err_probe() Date: Sun, 12 Dec 2021 21:18:43 +0100 [thread overview] Message-ID: <20211212201844.114949-3-aouledameur@baylibre.com> (raw) In-Reply-To: <20211212201844.114949-1-aouledameur@baylibre.com> Use the existing dev_err_probe() helper instead of open-coding the same operation. Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com> Reported-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/phy/amlogic/phy-meson8b-usb2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c index cf10bed40528..77e7e9b1428c 100644 --- a/drivers/phy/amlogic/phy-meson8b-usb2.c +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c @@ -265,8 +265,9 @@ static int phy_meson8b_usb2_probe(struct platform_device *pdev) return PTR_ERR(priv->clk_usb); priv->reset = devm_reset_control_get_optional_shared(&pdev->dev, NULL); - if (PTR_ERR(priv->reset) == -EPROBE_DEFER) - return PTR_ERR(priv->reset); + if (IS_ERR(priv->reset)) + return dev_err_probe(&pdev->dev, PTR_ERR(priv->reset), + "Failed to get the reset line"); priv->dr_mode = of_usb_get_dr_mode_by_phy(pdev->dev.of_node, -1); if (priv->dr_mode == USB_DR_MODE_UNKNOWN) { -- 2.25.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Amjad Ouled-Ameur <aouledameur@baylibre.com> To: khilman@baylibre.com Cc: Amjad Ouled-Ameur <aouledameur@baylibre.com>, p.zabel@pengutronix.de, balbi@kernel.org, jbrunet@baylibre.com, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, martin.blumenstingl@googlemail.com Subject: [PATCH v5 2/3] phy: amlogic: meson8b-usb2: Use dev_err_probe() Date: Sun, 12 Dec 2021 21:18:43 +0100 [thread overview] Message-ID: <20211212201844.114949-3-aouledameur@baylibre.com> (raw) In-Reply-To: <20211212201844.114949-1-aouledameur@baylibre.com> Use the existing dev_err_probe() helper instead of open-coding the same operation. Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com> Reported-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/phy/amlogic/phy-meson8b-usb2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c index cf10bed40528..77e7e9b1428c 100644 --- a/drivers/phy/amlogic/phy-meson8b-usb2.c +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c @@ -265,8 +265,9 @@ static int phy_meson8b_usb2_probe(struct platform_device *pdev) return PTR_ERR(priv->clk_usb); priv->reset = devm_reset_control_get_optional_shared(&pdev->dev, NULL); - if (PTR_ERR(priv->reset) == -EPROBE_DEFER) - return PTR_ERR(priv->reset); + if (IS_ERR(priv->reset)) + return dev_err_probe(&pdev->dev, PTR_ERR(priv->reset), + "Failed to get the reset line"); priv->dr_mode = of_usb_get_dr_mode_by_phy(pdev->dev.of_node, -1); if (priv->dr_mode == USB_DR_MODE_UNKNOWN) { -- 2.25.1
next prev parent reply other threads:[~2021-12-12 20:19 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-12 20:18 [PATCH v5 0/3] usb: meson: fix shared reset control use Amjad Ouled-Ameur 2021-12-12 20:18 ` Amjad Ouled-Ameur 2021-12-12 20:18 ` [PATCH v5 1/3] phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use Amjad Ouled-Ameur 2021-12-12 20:18 ` Amjad Ouled-Ameur 2021-12-12 20:44 ` Martin Blumenstingl 2021-12-12 20:44 ` Martin Blumenstingl 2021-12-13 9:16 ` Philipp Zabel 2021-12-13 9:16 ` Philipp Zabel 2021-12-12 20:18 ` Amjad Ouled-Ameur [this message] 2021-12-12 20:18 ` [PATCH v5 2/3] phy: amlogic: meson8b-usb2: Use dev_err_probe() Amjad Ouled-Ameur 2021-12-12 20:43 ` Martin Blumenstingl 2021-12-12 20:43 ` Martin Blumenstingl 2021-12-12 20:18 ` [PATCH v5 3/3] phy: amlogic: meson8b-usb2: fix shared reset control use Amjad Ouled-Ameur 2021-12-12 20:18 ` Amjad Ouled-Ameur 2021-12-12 20:44 ` Martin Blumenstingl 2021-12-12 20:44 ` Martin Blumenstingl 2021-12-13 13:30 ` [PATCH v5 0/3] usb: meson: " Neil Armstrong 2021-12-13 13:30 ` Neil Armstrong 2022-01-06 19:06 ` Kevin Hilman 2022-01-06 19:06 ` Kevin Hilman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211212201844.114949-3-aouledameur@baylibre.com \ --to=aouledameur@baylibre.com \ --cc=balbi@kernel.org \ --cc=jbrunet@baylibre.com \ --cc=khilman@baylibre.com \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=martin.blumenstingl@googlemail.com \ --cc=p.zabel@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.