From: Miquel Raynal <miquel.raynal@bootlin.com> To: Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Tudor Ambarus <Tudor.Ambarus@microchip.com>, Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>, <linux-mtd@lists.infradead.org>, Mark Brown <broonie@kernel.org>, <linux-spi@vger.kernel.org> Cc: Julien Su <juliensu@mxic.com.tw>, Jaime Liao <jaimeliao@mxic.com.tw>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Boris Brezillon <boris.brezillon@collabora.com>, Xiangsheng Hou <xiangsheng.hou@mediatek.com>, Miquel Raynal <miquel.raynal@bootlin.com> Subject: [PATCH v5 00/13] Pipelined ECC engines & Macronix support Date: Tue, 14 Dec 2021 12:41:27 +0100 [thread overview] Message-ID: <20211214114140.54629-1-miquel.raynal@bootlin.com> (raw) Hello all, This is a second version of the second half of the "External ECC engines & Macronix support" series, focusing on the pipelined support. Cheers, Miquèl Changes in v5: * Moved a helper in the core as it seems that it will be useful for other ECC engines as well (Xiangsheng Hou for Mediatek will need it). * Changed the parameters of the spi_mem_generic_supports_op() function in order to take a structure as input instead of a list of arguments, which will be much easier to complement in the future if ever needed. Changes in v4: * The first half of the series has been left aside (all the binding changes + the external mode in the Macronix driver), now let's focus on the pipelined mode. * Added the ecc_en spi_mem_op structure parameter in a dedicated commit. * Introduced a new helper for supporting generically the supported ops. * Used this new helper in the macronix driver. * By default all the other drivers would refuse a spi_mem_op with ecc_en enabled. Changes in v3: * Added Mark's R-by. * Added a commit changing the initialization order between the dirmaps and the ECC engine so that the core might now if we are using a pipelined engine or not. * Stopped creating additional dirmaps with ECC if the engine is not a pipelined engine. * Solved the kernel test robot reports. In particular, I added a dependency on MTD_NAND_ECC to Macronix SPI controller driver. * Added a patch to clean the NAND controller yaml file before moving some bits to nand-chip.yaml. This addresses the comments made by Rob about the useless allOf's. * Used platform_get_irq_byname_optional() in order to avoid useless warnings when there is no IRQ. Changes in v2: * Fixed the bindings and added Rob's acks when relevant. * Added locking in the ECC engine driver. * Brought more changes in the core in order to bring the ECC information into the spi_mem_op structure with the idea of avoiding any races between parallel calls on the same engine. * Reorganized the ECC driver entirely in order to have a per-engine mxic structure plus a per-NAND context. This lead to a number of changes internally which cannot all be listed. Changes since the RFC: * Rebased on top of v5.15-rc1. * Fixed the dirmap configuration. * Added the various tags received. * Fixed the bindings as reported by the robots. * Fixed the return value of the helper counting bitflips. * Included a fix from Jaime Liao in the external pattern logic. * Added the yaml conversion of Macronix SPI controller description. * Added the yaml conversion of the SPI-NAND description. * Created a nand-chip.yaml file to share properties between SPI-NAND and raw NAND. Miquel Raynal (13): mtd: nand: ecc: Provide a helper to retrieve a pilelined engine device mtd: nand: mxic-ecc: Support SPI pipelined mode mtd: spinand: Delay a little bit the dirmap creation spi: spi-mem: Create a helper to gather all the supports_op checks spi: spi-mem: Export the spi_mem_generic_supports_op() helper spi: spi-mem: Add an ecc_en parameter to the spi_mem_op structure mtd: spinand: Create direct mapping descriptors for ECC operations spi: mxic: Fix the transmit path spi: mxic: Create a helper to configure the controller before an operation spi: mxic: Create a helper to ease the start of an operation spi: mxic: Add support for direct mapping spi: mxic: Use spi_mem_generic_supports_op() spi: mxic: Add support for pipelined ECC operations drivers/mtd/nand/ecc-mxic.c | 181 +++++++++++++++- drivers/mtd/nand/ecc.c | 31 +++ drivers/mtd/nand/spi/core.c | 51 ++++- drivers/spi/Kconfig | 2 +- drivers/spi/spi-mem.c | 40 +++- drivers/spi/spi-mxic.c | 337 ++++++++++++++++++++++++------ include/linux/mtd/nand-ecc-mxic.h | 49 +++++ include/linux/mtd/nand.h | 1 + include/linux/mtd/spinand.h | 2 + include/linux/spi/spi-mem.h | 25 +++ 10 files changed, 639 insertions(+), 80 deletions(-) create mode 100644 include/linux/mtd/nand-ecc-mxic.h -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Tudor Ambarus <Tudor.Ambarus@microchip.com>, Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>, <linux-mtd@lists.infradead.org>, Mark Brown <broonie@kernel.org>, <linux-spi@vger.kernel.org> Cc: Julien Su <juliensu@mxic.com.tw>, Jaime Liao <jaimeliao@mxic.com.tw>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Boris Brezillon <boris.brezillon@collabora.com>, Xiangsheng Hou <xiangsheng.hou@mediatek.com>, Miquel Raynal <miquel.raynal@bootlin.com> Subject: [PATCH v5 00/13] Pipelined ECC engines & Macronix support Date: Tue, 14 Dec 2021 12:41:27 +0100 [thread overview] Message-ID: <20211214114140.54629-1-miquel.raynal@bootlin.com> (raw) Hello all, This is a second version of the second half of the "External ECC engines & Macronix support" series, focusing on the pipelined support. Cheers, Miquèl Changes in v5: * Moved a helper in the core as it seems that it will be useful for other ECC engines as well (Xiangsheng Hou for Mediatek will need it). * Changed the parameters of the spi_mem_generic_supports_op() function in order to take a structure as input instead of a list of arguments, which will be much easier to complement in the future if ever needed. Changes in v4: * The first half of the series has been left aside (all the binding changes + the external mode in the Macronix driver), now let's focus on the pipelined mode. * Added the ecc_en spi_mem_op structure parameter in a dedicated commit. * Introduced a new helper for supporting generically the supported ops. * Used this new helper in the macronix driver. * By default all the other drivers would refuse a spi_mem_op with ecc_en enabled. Changes in v3: * Added Mark's R-by. * Added a commit changing the initialization order between the dirmaps and the ECC engine so that the core might now if we are using a pipelined engine or not. * Stopped creating additional dirmaps with ECC if the engine is not a pipelined engine. * Solved the kernel test robot reports. In particular, I added a dependency on MTD_NAND_ECC to Macronix SPI controller driver. * Added a patch to clean the NAND controller yaml file before moving some bits to nand-chip.yaml. This addresses the comments made by Rob about the useless allOf's. * Used platform_get_irq_byname_optional() in order to avoid useless warnings when there is no IRQ. Changes in v2: * Fixed the bindings and added Rob's acks when relevant. * Added locking in the ECC engine driver. * Brought more changes in the core in order to bring the ECC information into the spi_mem_op structure with the idea of avoiding any races between parallel calls on the same engine. * Reorganized the ECC driver entirely in order to have a per-engine mxic structure plus a per-NAND context. This lead to a number of changes internally which cannot all be listed. Changes since the RFC: * Rebased on top of v5.15-rc1. * Fixed the dirmap configuration. * Added the various tags received. * Fixed the bindings as reported by the robots. * Fixed the return value of the helper counting bitflips. * Included a fix from Jaime Liao in the external pattern logic. * Added the yaml conversion of Macronix SPI controller description. * Added the yaml conversion of the SPI-NAND description. * Created a nand-chip.yaml file to share properties between SPI-NAND and raw NAND. Miquel Raynal (13): mtd: nand: ecc: Provide a helper to retrieve a pilelined engine device mtd: nand: mxic-ecc: Support SPI pipelined mode mtd: spinand: Delay a little bit the dirmap creation spi: spi-mem: Create a helper to gather all the supports_op checks spi: spi-mem: Export the spi_mem_generic_supports_op() helper spi: spi-mem: Add an ecc_en parameter to the spi_mem_op structure mtd: spinand: Create direct mapping descriptors for ECC operations spi: mxic: Fix the transmit path spi: mxic: Create a helper to configure the controller before an operation spi: mxic: Create a helper to ease the start of an operation spi: mxic: Add support for direct mapping spi: mxic: Use spi_mem_generic_supports_op() spi: mxic: Add support for pipelined ECC operations drivers/mtd/nand/ecc-mxic.c | 181 +++++++++++++++- drivers/mtd/nand/ecc.c | 31 +++ drivers/mtd/nand/spi/core.c | 51 ++++- drivers/spi/Kconfig | 2 +- drivers/spi/spi-mem.c | 40 +++- drivers/spi/spi-mxic.c | 337 ++++++++++++++++++++++++------ include/linux/mtd/nand-ecc-mxic.h | 49 +++++ include/linux/mtd/nand.h | 1 + include/linux/mtd/spinand.h | 2 + include/linux/spi/spi-mem.h | 25 +++ 10 files changed, 639 insertions(+), 80 deletions(-) create mode 100644 include/linux/mtd/nand-ecc-mxic.h -- 2.27.0 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next reply other threads:[~2021-12-14 11:41 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-14 11:41 Miquel Raynal [this message] 2021-12-14 11:41 ` [PATCH v5 00/13] Pipelined ECC engines & Macronix support Miquel Raynal 2021-12-14 11:41 ` [PATCH v5 01/13] mtd: nand: ecc: Provide a helper to retrieve a pilelined engine device Miquel Raynal 2021-12-14 11:41 ` Miquel Raynal 2021-12-14 11:41 ` [PATCH v5 02/13] mtd: nand: mxic-ecc: Support SPI pipelined mode Miquel Raynal 2021-12-14 11:41 ` Miquel Raynal 2021-12-14 11:41 ` [PATCH v5 03/13] mtd: spinand: Delay a little bit the dirmap creation Miquel Raynal 2021-12-14 11:41 ` Miquel Raynal 2021-12-14 11:41 ` [PATCH v5 04/13] spi: spi-mem: Create a helper to gather all the supports_op checks Miquel Raynal 2021-12-14 11:41 ` Miquel Raynal 2021-12-14 19:53 ` Pratyush Yadav 2021-12-14 19:53 ` Pratyush Yadav 2021-12-15 16:11 ` Miquel Raynal 2021-12-15 16:11 ` Miquel Raynal 2021-12-14 11:41 ` [PATCH v5 05/13] spi: spi-mem: Export the spi_mem_generic_supports_op() helper Miquel Raynal 2021-12-14 11:41 ` Miquel Raynal 2021-12-14 11:41 ` [PATCH v5 06/13] spi: spi-mem: Add an ecc_en parameter to the spi_mem_op structure Miquel Raynal 2021-12-14 11:41 ` Miquel Raynal 2021-12-14 16:29 ` Boris Brezillon 2021-12-14 16:29 ` Boris Brezillon 2021-12-14 11:41 ` [PATCH v5 07/13] mtd: spinand: Create direct mapping descriptors for ECC operations Miquel Raynal 2021-12-14 11:41 ` Miquel Raynal 2021-12-14 11:41 ` [PATCH v5 08/13] spi: mxic: Fix the transmit path Miquel Raynal 2021-12-14 11:41 ` Miquel Raynal 2021-12-14 11:41 ` [PATCH v5 09/13] spi: mxic: Create a helper to configure the controller before an operation Miquel Raynal 2021-12-14 11:41 ` Miquel Raynal 2021-12-14 11:41 ` [PATCH v5 10/13] spi: mxic: Create a helper to ease the start of " Miquel Raynal 2021-12-14 11:41 ` Miquel Raynal 2021-12-14 11:41 ` [PATCH v5 11/13] spi: mxic: Add support for direct mapping Miquel Raynal 2021-12-14 11:41 ` Miquel Raynal 2021-12-14 11:41 ` [PATCH v5 12/13] spi: mxic: Use spi_mem_generic_supports_op() Miquel Raynal 2021-12-14 11:41 ` Miquel Raynal 2021-12-14 16:24 ` Boris Brezillon 2021-12-14 16:24 ` Boris Brezillon 2021-12-15 17:44 ` Miquel Raynal 2021-12-15 17:44 ` Miquel Raynal 2021-12-15 18:45 ` Boris Brezillon 2021-12-15 18:45 ` Boris Brezillon 2021-12-16 8:11 ` Miquel Raynal 2021-12-16 8:11 ` Miquel Raynal 2021-12-15 18:52 ` Boris Brezillon 2021-12-15 18:52 ` Boris Brezillon 2021-12-16 8:14 ` Miquel Raynal 2021-12-16 8:14 ` Miquel Raynal 2021-12-15 19:05 ` Boris Brezillon 2021-12-15 19:05 ` Boris Brezillon 2021-12-15 19:19 ` Mark Brown 2021-12-15 19:19 ` Mark Brown 2021-12-16 8:07 ` Miquel Raynal 2021-12-16 8:07 ` Miquel Raynal 2021-12-16 9:01 ` Miquel Raynal 2021-12-16 9:01 ` Miquel Raynal 2021-12-16 9:57 ` Miquel Raynal 2021-12-16 9:57 ` Miquel Raynal 2021-12-16 14:04 ` Mark Brown 2021-12-16 14:04 ` Mark Brown 2021-12-16 14:27 ` Miquel Raynal 2021-12-16 14:27 ` Miquel Raynal 2021-12-14 11:41 ` [PATCH v5 13/13] spi: mxic: Add support for pipelined ECC operations Miquel Raynal 2021-12-14 11:41 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211214114140.54629-1-miquel.raynal@bootlin.com \ --to=miquel.raynal@bootlin.com \ --cc=Tudor.Ambarus@microchip.com \ --cc=boris.brezillon@collabora.com \ --cc=broonie@kernel.org \ --cc=jaimeliao@mxic.com.tw \ --cc=juliensu@mxic.com.tw \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=michael@walle.cc \ --cc=p.yadav@ti.com \ --cc=richard@nod.at \ --cc=thomas.petazzoni@bootlin.com \ --cc=vigneshr@ti.com \ --cc=xiangsheng.hou@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.