All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@denx.de>
To: broonie@kernel.org
Cc: alsa-devel@alsa-project.org, Fabio Estevam <festevam@denx.de>,
	ckeepax@opensource.cirrus.com, Paul.Handrigan@cirrus.com,
	james.schulman@cirrus.com
Subject: [PATCH 2/2] ASoC: cs4265: Move reset_gpio to local scope
Date: Wed, 22 Dec 2021 11:16:45 -0300	[thread overview]
Message-ID: <20211222141645.1482267-2-festevam@denx.de> (raw)
In-Reply-To: <20211222141645.1482267-1-festevam@denx.de>

There is no need to keep 'struct gpio_desc *reset_gpio' inside
the private structure becase reset_gpio is only used inside the
probe() function.

Move it to a local scope.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 sound/soc/codecs/cs4265.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/sound/soc/codecs/cs4265.c b/sound/soc/codecs/cs4265.c
index b89002189a2b..88d89366f816 100644
--- a/sound/soc/codecs/cs4265.c
+++ b/sound/soc/codecs/cs4265.c
@@ -29,7 +29,6 @@
 
 struct cs4265_private {
 	struct regmap *regmap;
-	struct gpio_desc *reset_gpio;
 	u8 format;
 	u32 sysclk;
 };
@@ -573,6 +572,7 @@ static int cs4265_i2c_probe(struct i2c_client *i2c_client,
 			     const struct i2c_device_id *id)
 {
 	struct cs4265_private *cs4265;
+	struct gpio_desc *reset_gpio;
 	int ret;
 	unsigned int devid = 0;
 	unsigned int reg;
@@ -589,14 +589,14 @@ static int cs4265_i2c_probe(struct i2c_client *i2c_client,
 		return ret;
 	}
 
-	cs4265->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev,
-		"reset", GPIOD_OUT_LOW);
-	if (IS_ERR(cs4265->reset_gpio))
-		return PTR_ERR(cs4265->reset_gpio);
+	reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, "reset",
+					      GPIOD_OUT_LOW);
+	if (IS_ERR(reset_gpio))
+		return PTR_ERR(reset_gpio);
 
-	if (cs4265->reset_gpio) {
+	if (reset_gpio) {
 		mdelay(1);
-		gpiod_set_value_cansleep(cs4265->reset_gpio, 1);
+		gpiod_set_value_cansleep(reset_gpio, 1);
 	}
 
 	i2c_set_clientdata(i2c_client, cs4265);
-- 
2.25.1


      reply	other threads:[~2021-12-26  8:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-22 14:16 [PATCH 1/2] ASoC: cs4265: Fix part number ID error message Fabio Estevam
2021-12-22 14:16 ` Fabio Estevam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211222141645.1482267-2-festevam@denx.de \
    --to=festevam@denx.de \
    --cc=Paul.Handrigan@cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=james.schulman@cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.