From: Miaoqian Lin <linmq006@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: linmq006@gmail.com, Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] remoteproc: Fix NULL vs IS_ERR() checking in rproc_create_trace_file
Date: Mon, 27 Dec 2021 09:06:45 +0000 [thread overview]
Message-ID: <20211227090645.18600-1-linmq006@gmail.com> (raw)
The debugfs_create_file() function doesn't return NULL.
It returns error pointers.
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/remoteproc/remoteproc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
index b5a1e3b697d9..a2409fe2f57b 100644
--- a/drivers/remoteproc/remoteproc_debugfs.c
+++ b/drivers/remoteproc/remoteproc_debugfs.c
@@ -390,7 +390,7 @@ struct dentry *rproc_create_trace_file(const char *name, struct rproc *rproc,
tfile = debugfs_create_file(name, 0400, rproc->dbg_dir, trace,
&trace_rproc_ops);
- if (!tfile) {
+ if (IS_ERR(tfile)) {
dev_err(&rproc->dev, "failed to create debugfs trace entry\n");
return NULL;
}
--
2.17.1
next reply other threads:[~2021-12-27 9:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 9:06 Miaoqian Lin [this message]
2022-01-04 17:46 ` [PATCH] remoteproc: Fix NULL vs IS_ERR() checking in rproc_create_trace_file Mathieu Poirier
2022-01-05 6:42 ` [PATCH v2] " Miaoqian Lin
2022-01-05 13:10 ` [PATCH v3] " Miaoqian Lin
2022-01-17 17:06 ` Mathieu Poirier
2022-01-17 22:31 ` Bjorn Andersson
2022-01-18 16:56 ` Mathieu Poirier
2022-01-18 19:17 ` Bjorn Andersson
2022-01-20 20:05 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211227090645.18600-1-linmq006@gmail.com \
--to=linmq006@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.