All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yunfei Dong <yunfei.dong@mediatek.com>
To: Yunfei Dong <yunfei.dong@mediatek.com>,
	Alexandre Courbot <acourbot@chromium.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Tzung-Bi Shih <tzungbi@chromium.org>,
	Tiffany Lin <tiffany.lin@mediatek.com>,
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Tomasz Figa <tfiga@google.com>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>,
	Fritz Koenig <frkoenig@chromium.org>,
	Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Irui Wang <irui.wang@mediatek.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	Steve Cho <stevecho@chromium.org>, <linux-media@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<srv_heupstream@mediatek.com>,
	<linux-mediatek@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: [PATCH v2, 10/12] media: mtk-vcodec: Fix v4l2-compliance fail
Date: Tue, 28 Dec 2021 17:41:44 +0800	[thread overview]
Message-ID: <20211228094146.20505-11-yunfei.dong@mediatek.com> (raw)
In-Reply-To: <20211228094146.20505-1-yunfei.dong@mediatek.com>

From: Yunfei Dong <yunfei.dong@mediatek.corp-partner.google.com>

Need to use default pic info when get pic info fail from scp side.

Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
---
 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
index 0317a9930de1..4533cb44551d 100644
--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
+++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
@@ -480,11 +480,14 @@ static int vidioc_vdec_s_fmt(struct file *file, void *priv,
 		ctx->picinfo.pic_w = pix_mp->width;
 		ctx->picinfo.pic_h = pix_mp->height;
 
+		/*
+		 * If get pic info fail, need to use the default pic info params, or
+		 * v4l2-compliance will fail
+		 */
 		ret = vdec_if_get_param(ctx, GET_PARAM_PIC_INFO, &ctx->picinfo);
 		if (ret) {
 			mtk_v4l2_err("[%d]Error!! Get GET_PARAM_PICTURE_INFO Fail",
 				     ctx->id);
-			return -EINVAL;
 		}
 
 		ctx->last_decoded_picinfo = ctx->picinfo;
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Yunfei Dong <yunfei.dong@mediatek.com>
To: Yunfei Dong <yunfei.dong@mediatek.com>,
	Alexandre Courbot <acourbot@chromium.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Tzung-Bi Shih <tzungbi@chromium.org>,
	Tiffany Lin <tiffany.lin@mediatek.com>,
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Tomasz Figa <tfiga@google.com>
Cc: Irui Wang <irui.wang@mediatek.com>,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	linux-mediatek@lists.infradead.org,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	Fritz Koenig <frkoenig@chromium.org>,
	Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
	Steve Cho <stevecho@chromium.org>,
	linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>
Subject: [PATCH v2, 10/12] media: mtk-vcodec: Fix v4l2-compliance fail
Date: Tue, 28 Dec 2021 17:41:44 +0800	[thread overview]
Message-ID: <20211228094146.20505-11-yunfei.dong@mediatek.com> (raw)
In-Reply-To: <20211228094146.20505-1-yunfei.dong@mediatek.com>

From: Yunfei Dong <yunfei.dong@mediatek.corp-partner.google.com>

Need to use default pic info when get pic info fail from scp side.

Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
---
 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
index 0317a9930de1..4533cb44551d 100644
--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
+++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
@@ -480,11 +480,14 @@ static int vidioc_vdec_s_fmt(struct file *file, void *priv,
 		ctx->picinfo.pic_w = pix_mp->width;
 		ctx->picinfo.pic_h = pix_mp->height;
 
+		/*
+		 * If get pic info fail, need to use the default pic info params, or
+		 * v4l2-compliance will fail
+		 */
 		ret = vdec_if_get_param(ctx, GET_PARAM_PIC_INFO, &ctx->picinfo);
 		if (ret) {
 			mtk_v4l2_err("[%d]Error!! Get GET_PARAM_PICTURE_INFO Fail",
 				     ctx->id);
-			return -EINVAL;
 		}
 
 		ctx->last_decoded_picinfo = ctx->picinfo;
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Yunfei Dong <yunfei.dong@mediatek.com>
To: Yunfei Dong <yunfei.dong@mediatek.com>,
	Alexandre Courbot <acourbot@chromium.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	"Tzung-Bi Shih" <tzungbi@chromium.org>,
	Tiffany Lin <tiffany.lin@mediatek.com>,
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Tomasz Figa <tfiga@google.com>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>,
	Fritz Koenig <frkoenig@chromium.org>,
	 Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Irui Wang <irui.wang@mediatek.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	"Steve Cho" <stevecho@chromium.org>,
	<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<srv_heupstream@mediatek.com>,
	<linux-mediatek@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: [PATCH v2, 10/12] media: mtk-vcodec: Fix v4l2-compliance fail
Date: Tue, 28 Dec 2021 17:41:44 +0800	[thread overview]
Message-ID: <20211228094146.20505-11-yunfei.dong@mediatek.com> (raw)
In-Reply-To: <20211228094146.20505-1-yunfei.dong@mediatek.com>

From: Yunfei Dong <yunfei.dong@mediatek.corp-partner.google.com>

Need to use default pic info when get pic info fail from scp side.

Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
---
 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
index 0317a9930de1..4533cb44551d 100644
--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
+++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
@@ -480,11 +480,14 @@ static int vidioc_vdec_s_fmt(struct file *file, void *priv,
 		ctx->picinfo.pic_w = pix_mp->width;
 		ctx->picinfo.pic_h = pix_mp->height;
 
+		/*
+		 * If get pic info fail, need to use the default pic info params, or
+		 * v4l2-compliance will fail
+		 */
 		ret = vdec_if_get_param(ctx, GET_PARAM_PIC_INFO, &ctx->picinfo);
 		if (ret) {
 			mtk_v4l2_err("[%d]Error!! Get GET_PARAM_PICTURE_INFO Fail",
 				     ctx->id);
-			return -EINVAL;
 		}
 
 		ctx->last_decoded_picinfo = ctx->picinfo;
-- 
2.25.1


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Yunfei Dong <yunfei.dong@mediatek.com>
To: Yunfei Dong <yunfei.dong@mediatek.com>,
	Alexandre Courbot <acourbot@chromium.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	"Tzung-Bi Shih" <tzungbi@chromium.org>,
	Tiffany Lin <tiffany.lin@mediatek.com>,
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Tomasz Figa <tfiga@google.com>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>,
	Fritz Koenig <frkoenig@chromium.org>,
	 Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Irui Wang <irui.wang@mediatek.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	"Steve Cho" <stevecho@chromium.org>,
	<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<srv_heupstream@mediatek.com>,
	<linux-mediatek@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: [PATCH v2, 10/12] media: mtk-vcodec: Fix v4l2-compliance fail
Date: Tue, 28 Dec 2021 17:41:44 +0800	[thread overview]
Message-ID: <20211228094146.20505-11-yunfei.dong@mediatek.com> (raw)
In-Reply-To: <20211228094146.20505-1-yunfei.dong@mediatek.com>

From: Yunfei Dong <yunfei.dong@mediatek.corp-partner.google.com>

Need to use default pic info when get pic info fail from scp side.

Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
---
 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
index 0317a9930de1..4533cb44551d 100644
--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
+++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
@@ -480,11 +480,14 @@ static int vidioc_vdec_s_fmt(struct file *file, void *priv,
 		ctx->picinfo.pic_w = pix_mp->width;
 		ctx->picinfo.pic_h = pix_mp->height;
 
+		/*
+		 * If get pic info fail, need to use the default pic info params, or
+		 * v4l2-compliance will fail
+		 */
 		ret = vdec_if_get_param(ctx, GET_PARAM_PIC_INFO, &ctx->picinfo);
 		if (ret) {
 			mtk_v4l2_err("[%d]Error!! Get GET_PARAM_PICTURE_INFO Fail",
 				     ctx->id);
-			return -EINVAL;
 		}
 
 		ctx->last_decoded_picinfo = ctx->picinfo;
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-12-28  9:42 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-28  9:41 [PATCH v2, 00/12] media: mtk-vcodec: support for MT8192 decoder Yunfei Dong
2021-12-28  9:41 ` Yunfei Dong
2021-12-28  9:41 ` Yunfei Dong
2021-12-28  9:41 ` Yunfei Dong
2021-12-28  9:41 ` [PATCH v2, 01/12] media: mtk-vcodec: Add vdec enable/disable hardware helpers Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-29  5:35   ` Tzung-Bi Shih
2021-12-29  5:35     ` Tzung-Bi Shih
2021-12-29  5:35     ` Tzung-Bi Shih
2021-12-29  5:35     ` Tzung-Bi Shih
2021-12-28  9:41 ` [PATCH v2, 02/12] media: mtk-vcodec: Using firmware type to separate different firmware architecture Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-29  5:36   ` Tzung-Bi Shih
2021-12-29  5:36     ` Tzung-Bi Shih
2021-12-29  5:36     ` Tzung-Bi Shih
2021-12-29  5:36     ` Tzung-Bi Shih
2021-12-28  9:41 ` [PATCH v2, 03/12] media: mtk-vcodec: get capture queue buffer size from scp Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-29  5:36   ` Tzung-Bi Shih
2021-12-29  5:36     ` Tzung-Bi Shih
2021-12-29  5:36     ` Tzung-Bi Shih
2021-12-29  5:36     ` Tzung-Bi Shih
2021-12-29  6:52     ` yunfei.dong
2021-12-29  6:52       ` yunfei.dong
2021-12-29  6:52       ` yunfei.dong
2021-12-29  6:52       ` yunfei.dong
2021-12-29  7:27       ` Tzung-Bi Shih
2021-12-29  7:27         ` Tzung-Bi Shih
2021-12-29  7:27         ` Tzung-Bi Shih
2021-12-29  7:27         ` Tzung-Bi Shih
2021-12-28  9:41 ` [PATCH v2, 04/12] media: mtk-vcodec: Read max resolution from dec_capability Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-29  5:56   ` Tzung-Bi Shih
2021-12-29  5:56     ` Tzung-Bi Shih
2021-12-29  5:56     ` Tzung-Bi Shih
2021-12-29  5:56     ` Tzung-Bi Shih
2021-12-28  9:41 ` [PATCH v2, 05/12] media: mtk-vcodec: Call v4l2_m2m_set_dst_buffered() set capture buffer buffered Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-29  6:36   ` Tzung-Bi Shih
2021-12-29  6:36     ` Tzung-Bi Shih
2021-12-29  6:36     ` Tzung-Bi Shih
2021-12-29  6:36     ` Tzung-Bi Shih
2021-12-28  9:41 ` [PATCH v2, 06/12] media: mtk-vcodec: Refactor get and put capture buffer flow Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41 ` [PATCH v2, 07/12] media: mtk-vcodec: Refactor supported vdec formats and framesizes Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41 ` [PATCH v2, 08/12] media: mtk-vcodec: Add format to support MT21C Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41 ` [PATCH v2, 09/12] media: mtk-vcodec: disable vp8 4K capability Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41 ` Yunfei Dong [this message]
2021-12-28  9:41   ` [PATCH v2, 10/12] media: mtk-vcodec: Fix v4l2-compliance fail Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41 ` [PATCH v2, 11/12] media: mtk-vcodec: Extract H264 common code Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41 ` [PATCH v2, 12/12] media: mtk-vcodec: Add h264 decoder driver for mt8192 Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong
2021-12-28  9:41   ` Yunfei Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211228094146.20505-11-yunfei.dong@mediatek.com \
    --to=yunfei.dong@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=acourbot@chromium.org \
    --cc=andrew-ct.chen@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=benjamin.gaignard@collabora.com \
    --cc=dafna.hirschfeld@collabora.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frkoenig@chromium.org \
    --cc=hsinyi@chromium.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=irui.wang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=stevecho@chromium.org \
    --cc=tfiga@google.com \
    --cc=tiffany.lin@mediatek.com \
    --cc=tzungbi@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.