From: GitHub issues - edited <github@alsa-project.org>
To: alsa-devel@alsa-project.org
Subject: [patch] /usr/share/alsa/speaker-test/sample_map.csv is not accurate, which does not affect operation of speaker-test
Date: Wed, 29 Dec 2021 02:55:03 +0100 (CET) [thread overview]
Message-ID: <20211229015503.A2FA6F80224@alsa1.perex.cz> (raw)
In-Reply-To: <1640742900263111115-webhooks-bot@alsa-project.org>
alsa-project/alsa-utils issue #133 was edited from ZjYwMj:
With alsa-utils 1.2.6:
```
--- a/usr/share/alsa/speaker-test/sample_map.csv 2021-12-06 18:44:25.000000000 +0000
+++ b/usr/share/alsa/speaker-test/sample_map.csv 2021-12-28 19:48:02.390305957 +0000
@@ -1,2 +1,2 @@
-0, "Front Left", "/usr/share/alsa/samples/Front_Left.wav"
-1, "Front Right", "/usr/share/alsa/samples/Front_Right.wav"
+0, "Front Left", "/usr/share/sounds/alsa/Front_Left.wav"
+1, "Front Right", "/usr/share/sounds/alsa/Front_Right.wav"
```
The directory ``/usr/share/alsa/samples/`` does not exist. It sounds as if ``speaker-test -t wav`` plays the files mentioned in the diff. This inaccuracy does not affect the operation of ``speaker-test``. Do the paths to the wav files hard coded within ``speaker-test``? Does only their ``basename`` counts? Still, I find it a minor bug.
Why is ``/usr/share/alsa/speaker-test/sample_map.csv`` distributed anyway? Am I misunderstanding [Install sound samples to correct places](https://github.com/alsa-project/alsa-utils/commit/fb2f99f1f99c430d1ca263be84d919aa808601c3)? Is it for informational purposes? Was it used in the past, and no longer serves its purpose? Is it planed to be used in the future? Is it something else?
[speaker-test.c](https://github.com/alsa-project/alsa-utils/blob/00be486131129a6d209de62202d2a4974638127f/speaker-test/speaker-test.c):742 has the ``basename``s hardcoded. And there is also the default value for ``speaker-test --wavdir`` of ``/usr/share/sounds/alsa``.
Issue URL : https://github.com/alsa-project/alsa-utils/issues/133
Repository URL: https://github.com/alsa-project/alsa-utils
next parent reply other threads:[~2021-12-29 1:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1640742900263111115-webhooks-bot@alsa-project.org>
2021-12-29 1:55 ` GitHub issues - edited [this message]
[not found] <1640743072750150919-webhooks-bot@alsa-project.org>
2021-12-29 1:57 ` [patch] /usr/share/alsa/speaker-test/sample_map.csv is not accurate, which does not affect operation of speaker-test GitHub issues - edited
[not found] <1640742951735677004-webhooks-bot@alsa-project.org>
2021-12-29 1:55 ` GitHub issues - edited
[not found] <1640742708148356915-webhooks-bot@alsa-project.org>
2021-12-29 1:51 ` GitHub issues - edited
[not found] <1640742531472625971-webhooks-bot@alsa-project.org>
2021-12-29 1:49 ` GitHub issues - edited
[not found] <1640741543083658934-webhooks-bot@alsa-project.org>
2021-12-29 1:32 ` GitHub issues - edited
[not found] <1640740687076991081-webhooks-bot@alsa-project.org>
2021-12-29 1:18 ` GitHub issues - edited
[not found] <1640738536043701887-webhooks-bot@alsa-project.org>
2021-12-29 0:42 ` GitHub issues - edited
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211229015503.A2FA6F80224@alsa1.perex.cz \
--to=github@alsa-project.org \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.