All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dirk Müller" <dmueller@suse.de>
To: linux-scsi@vger.kernel.org
Cc: "Dirk Müller" <dmueller@suse.de>
Subject: [PATCH] qla2xxx: fix error status checking in qla24xx_modify_vp_config()
Date: Wed,  5 Jan 2022 14:03:37 +0100	[thread overview]
Message-ID: <20220105130337.31758-1-dmueller@suse.de> (raw)

The function was checking vpmod->comp_status and reported it as error
status, which is however already checked a few lines below.

Guessing from other occurrences it was supposed to check entry_status
instead.

Fixes: 2c3dfe3f6ad8 ("[SCSI] qla2xxx: add support for NPIV")
Signed-off-by: Dirk Müller <dmueller@suse.de>
---
 drivers/scsi/qla2xxx/qla_mbx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
index 10d2655ef676..e0dce38b65cf 100644
--- a/drivers/scsi/qla2xxx/qla_mbx.c
+++ b/drivers/scsi/qla2xxx/qla_mbx.c
@@ -4253,7 +4253,7 @@ qla24xx_modify_vp_config(scsi_qla_host_t *vha)
 	if (rval != QLA_SUCCESS) {
 		ql_dbg(ql_dbg_mbx, vha, 0x10bd,
 		    "Failed to issue VP config IOCB (%x).\n", rval);
-	} else if (vpmod->comp_status != 0) {
+	} else if (vpmod->entry_status != 0) {
 		ql_dbg(ql_dbg_mbx, vha, 0x10be,
 		    "Failed to complete IOCB -- error status (%x).\n",
 		    vpmod->comp_status);
-- 
2.34.1


             reply	other threads:[~2022-01-05 13:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05 13:03 Dirk Müller [this message]
2022-01-06 15:35 ` [PATCH] qla2xxx: fix error status checking in qla24xx_modify_vp_config() Martin Wilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220105130337.31758-1-dmueller@suse.de \
    --to=dmueller@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.