All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nancy.Lin <nancy.lin@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
	David Airlie <airlied@linux.ie>,
	"jason-jh . lin" <jason-jh.lin@mediatek.com>,
	singo.chang@mediatek.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	Yongqiang Niu <yongqiang.niu@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	"Nancy . Lin" <nancy.lin@mediatek.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 15/22] drm/mediatek: add display merge async reset control
Date: Mon, 10 Jan 2022 16:46:38 +0800	[thread overview]
Message-ID: <20220110084645.31191-16-nancy.lin@mediatek.com> (raw)
In-Reply-To: <20220110084645.31191-1-nancy.lin@mediatek.com>

Add merge async reset control in mtk_merge_stop. Async hw doesn't do self
reset on each sof signal(start of frame), so need to reset the async to
clear the hw status for the next merge start.

Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_disp_merge.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_disp_merge.c b/drivers/gpu/drm/mediatek/mtk_disp_merge.c
index 9dca145cfb71..177473fa8160 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_merge.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_merge.c
@@ -8,6 +8,7 @@
 #include <linux/of_device.h>
 #include <linux/of_irq.h>
 #include <linux/platform_device.h>
+#include <linux/reset.h>
 #include <linux/soc/mediatek/mtk-cmdq.h>
 
 #include "mtk_drm_ddp_comp.h"
@@ -79,6 +80,9 @@ void mtk_merge_stop(struct device *dev)
 	struct mtk_disp_merge *priv = dev_get_drvdata(dev);
 
 	mtk_merge_stop_cmdq(dev, NULL);
+
+	if (priv->async_clk)
+		device_reset_optional(dev);
 }
 
 void mtk_merge_start_cmdq(struct device *dev, struct cmdq_pkt *cmdq_pkt)
-- 
2.18.0


WARNING: multiple messages have this Message-ID (diff)
From: Nancy.Lin <nancy.lin@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	"jason-jh . lin" <jason-jh.lin@mediatek.com>,
	"Nancy . Lin" <nancy.lin@mediatek.com>,
	Yongqiang Niu <yongqiang.niu@mediatek.com>,
	<dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<singo.chang@mediatek.com>, <srv_heupstream@mediatek.com>
Subject: [PATCH v11 15/22] drm/mediatek: add display merge async reset control
Date: Mon, 10 Jan 2022 16:46:38 +0800	[thread overview]
Message-ID: <20220110084645.31191-16-nancy.lin@mediatek.com> (raw)
In-Reply-To: <20220110084645.31191-1-nancy.lin@mediatek.com>

Add merge async reset control in mtk_merge_stop. Async hw doesn't do self
reset on each sof signal(start of frame), so need to reset the async to
clear the hw status for the next merge start.

Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_disp_merge.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_disp_merge.c b/drivers/gpu/drm/mediatek/mtk_disp_merge.c
index 9dca145cfb71..177473fa8160 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_merge.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_merge.c
@@ -8,6 +8,7 @@
 #include <linux/of_device.h>
 #include <linux/of_irq.h>
 #include <linux/platform_device.h>
+#include <linux/reset.h>
 #include <linux/soc/mediatek/mtk-cmdq.h>
 
 #include "mtk_drm_ddp_comp.h"
@@ -79,6 +80,9 @@ void mtk_merge_stop(struct device *dev)
 	struct mtk_disp_merge *priv = dev_get_drvdata(dev);
 
 	mtk_merge_stop_cmdq(dev, NULL);
+
+	if (priv->async_clk)
+		device_reset_optional(dev);
 }
 
 void mtk_merge_start_cmdq(struct device *dev, struct cmdq_pkt *cmdq_pkt)
-- 
2.18.0


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Nancy.Lin <nancy.lin@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	"jason-jh . lin" <jason-jh.lin@mediatek.com>,
	"Nancy . Lin" <nancy.lin@mediatek.com>,
	Yongqiang Niu <yongqiang.niu@mediatek.com>,
	<dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<singo.chang@mediatek.com>, <srv_heupstream@mediatek.com>
Subject: [PATCH v11 15/22] drm/mediatek: add display merge async reset control
Date: Mon, 10 Jan 2022 16:46:38 +0800	[thread overview]
Message-ID: <20220110084645.31191-16-nancy.lin@mediatek.com> (raw)
In-Reply-To: <20220110084645.31191-1-nancy.lin@mediatek.com>

Add merge async reset control in mtk_merge_stop. Async hw doesn't do self
reset on each sof signal(start of frame), so need to reset the async to
clear the hw status for the next merge start.

Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_disp_merge.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_disp_merge.c b/drivers/gpu/drm/mediatek/mtk_disp_merge.c
index 9dca145cfb71..177473fa8160 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_merge.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_merge.c
@@ -8,6 +8,7 @@
 #include <linux/of_device.h>
 #include <linux/of_irq.h>
 #include <linux/platform_device.h>
+#include <linux/reset.h>
 #include <linux/soc/mediatek/mtk-cmdq.h>
 
 #include "mtk_drm_ddp_comp.h"
@@ -79,6 +80,9 @@ void mtk_merge_stop(struct device *dev)
 	struct mtk_disp_merge *priv = dev_get_drvdata(dev);
 
 	mtk_merge_stop_cmdq(dev, NULL);
+
+	if (priv->async_clk)
+		device_reset_optional(dev);
 }
 
 void mtk_merge_start_cmdq(struct device *dev, struct cmdq_pkt *cmdq_pkt)
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-01-10  8:46 UTC|newest]

Thread overview: 124+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10  8:46 [PATCH v11 00/22] Add MediaTek SoC DRM (vdosys1) support for mt8195 Nancy.Lin
2022-01-10  8:46 ` Nancy.Lin
2022-01-10  8:46 ` Nancy.Lin
2022-01-10  8:46 ` [PATCH v11 01/22] dt-bindings: mediatek: add vdosys1 RDMA definition " Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46 ` [PATCH v11 02/22] dt-bindings: mediatek: add vdosys1 MERGE property " Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-02-09 14:54   ` Chun-Kuang Hu
2022-02-09 14:54     ` Chun-Kuang Hu
2022-02-09 14:54     ` Chun-Kuang Hu
2022-02-09 14:54     ` Chun-Kuang Hu
2022-01-10  8:46 ` [PATCH v11 03/22] dt-bindings: mediatek: add ethdr definition " Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-02-09 14:55   ` Chun-Kuang Hu
2022-02-09 14:55     ` Chun-Kuang Hu
2022-02-09 14:55     ` Chun-Kuang Hu
2022-01-10  8:46 ` [PATCH v11 04/22] dt-bindings: reset: mt8195: add vdosys1 reset control bit Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46 ` [PATCH v11 05/22] soc: mediatek: add mtk-mmsys support for mt8195 vdosys1 Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-13 16:08   ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-10  8:46 ` [PATCH v11 06/22] soc: mediatek: add mtk-mmsys config API " Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-13 16:08   ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-10  8:46 ` [PATCH v11 07/22] soc: mediatek: add cmdq support of " Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-13 16:08   ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-10  8:46 ` [PATCH v11 08/22] soc: mediatek: mmsys: modify reset controller for MT8195 vdosys1 Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-13 16:08   ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-10  8:46 ` [PATCH v11 09/22] soc: mediatek: change the mutex defines and the mutex_mod type Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-13 16:08   ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-10  8:46 ` [PATCH v11 10/22] soc: mediatek: add mtk-mutex support for mt8195 vdosys1 Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-13 16:08   ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-10  8:46 ` [PATCH v11 11/22] drm/mediatek: add display MDP RDMA support for MT8195 Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46 ` [PATCH v11 12/22] drm/mediatek: add display merge advance config API " Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46 ` [PATCH v11 13/22] drm/mediatek: add display merge start/stop API for cmdq support Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46 ` [PATCH v11 14/22] drm/mediatek: add display merge mute/unmute support for MT8195 Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46 ` Nancy.Lin [this message]
2022-01-10  8:46   ` [PATCH v11 15/22] drm/mediatek: add display merge async reset control Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46 ` [PATCH v11 16/22] drm/mediatek: add ETHDR support for MT8195 Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46 ` [PATCH v11 17/22] drm/mediatek: add mediatek-drm plane color encoding info Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46 ` [PATCH v11 18/22] drm/mediatek: add ovl_adaptor support for MT8195 Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46 ` [PATCH v11 19/22] drm/mediatek: modify mediatek-drm for mt8195 multi mmsys support Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-13 16:08   ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-10  8:46 ` [PATCH v11 20/22] drm/mediatek: add drm ovl_adaptor sub driver for MT8195 Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-13 16:08   ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-14  5:47   ` CK Hu
2022-01-14  5:47     ` CK Hu
2022-01-14  5:47     ` CK Hu
2022-02-22  7:19     ` Nancy.Lin
2022-02-22  7:19       ` Nancy.Lin
2022-02-22  7:19       ` Nancy.Lin
2022-01-10  8:46 ` [PATCH v11 21/22] drm/mediatek: add mediatek-drm of vdosys1 support " Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-13 16:08   ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-13 16:08     ` AngeloGioacchino Del Regno
2022-01-24  7:18   ` CK Hu
2022-01-24  7:18     ` CK Hu
2022-01-24  7:18     ` CK Hu
2022-02-18  9:49     ` Nancy.Lin
2022-02-18  9:49       ` Nancy.Lin
2022-02-18  9:49       ` Nancy.Lin
2022-01-10  8:46 ` [PATCH v11 22/22] arm64: dts: mt8195: add display node for vdosys1 Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin
2022-01-10  8:46   ` Nancy.Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220110084645.31191-16-nancy.lin@mediatek.com \
    --to=nancy.lin@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=chunkuang.hu@kernel.org \
    --cc=ck.hu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jason-jh.lin@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=singo.chang@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=yongqiang.niu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.