All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
To: cip-dev@lists.cip-project.org,
	Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	Pavel Machek <pavel@denx.de>
Cc: Biju Das <biju.das.jz@bp.renesas.com>
Subject: [PATCH 5.10.y-cip 21/61] ravb: Add no_ptp_cfg_active to struct ravb_hw_info
Date: Mon, 10 Jan 2022 12:22:51 +0000	[thread overview]
Message-ID: <20220110122331.24114-22-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw)
In-Reply-To: <20220110122331.24114-1-prabhakar.mahadev-lad.rj@bp.renesas.com>

From: Biju Das <biju.das.jz@bp.renesas.com>

commit 8f27219a6191679333e703daf8bb66e5a1241aed upstream.

There are some H/W differences for the gPTP feature between
R-Car Gen3, R-Car Gen2, and RZ/G2L as below.

1) On R-Car Gen2, gPTP support is not active in config mode.
2) On R-Car Gen3, gPTP support is active in config mode.
3) RZ/G2L does not support the gPTP feature.

Add a no_ptp_cfg_active hw feature bit to struct ravb_hw_info for
handling gPTP for R-Car Gen2.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 drivers/net/ethernet/renesas/ravb.h      |  1 +
 drivers/net/ethernet/renesas/ravb_main.c | 20 ++++++++++++--------
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
index a74bd63ba3be..9d818c26bba5 100644
--- a/drivers/net/ethernet/renesas/ravb.h
+++ b/drivers/net/ethernet/renesas/ravb.h
@@ -999,6 +999,7 @@ struct ravb_hw_info {
 	unsigned internal_delay:1;	/* AVB-DMAC has internal delays */
 	unsigned tx_counters:1;		/* E-MAC has TX counters */
 	unsigned multi_irqs:1;		/* AVB-DMAC and E-MAC has multiple irqs */
+	unsigned no_ptp_cfg_active:1;	/* AVB-DMAC does not support gPTP active in config mode */
 };
 
 struct ravb_private {
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 5e41c2b04083..bdeb6a757559 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -1203,6 +1203,7 @@ static int ravb_set_ringparam(struct net_device *ndev,
 			      struct ethtool_ringparam *ring)
 {
 	struct ravb_private *priv = netdev_priv(ndev);
+	const struct ravb_hw_info *info = priv->info;
 	int error;
 
 	if (ring->tx_pending > BE_TX_RING_MAX ||
@@ -1216,7 +1217,7 @@ static int ravb_set_ringparam(struct net_device *ndev,
 	if (netif_running(ndev)) {
 		netif_device_detach(ndev);
 		/* Stop PTP Clock driver */
-		if (priv->chip_id == RCAR_GEN2)
+		if (info->no_ptp_cfg_active)
 			ravb_ptp_stop(ndev);
 		/* Wait for DMA stopping */
 		error = ravb_stop_dma(ndev);
@@ -1248,7 +1249,7 @@ static int ravb_set_ringparam(struct net_device *ndev,
 		ravb_emac_init(ndev);
 
 		/* Initialise PTP Clock driver */
-		if (priv->chip_id == RCAR_GEN2)
+		if (info->no_ptp_cfg_active)
 			ravb_ptp_init(ndev, priv->pdev);
 
 		netif_device_attach(ndev);
@@ -1388,7 +1389,7 @@ static int ravb_open(struct net_device *ndev)
 	ravb_emac_init(ndev);
 
 	/* Initialise PTP Clock driver */
-	if (priv->chip_id == RCAR_GEN2)
+	if (info->no_ptp_cfg_active)
 		ravb_ptp_init(ndev, priv->pdev);
 
 	netif_tx_start_all_queues(ndev);
@@ -1402,7 +1403,7 @@ static int ravb_open(struct net_device *ndev)
 
 out_ptp_stop:
 	/* Stop PTP Clock driver */
-	if (priv->chip_id == RCAR_GEN2)
+	if (info->no_ptp_cfg_active)
 		ravb_ptp_stop(ndev);
 out_free_irq_nc_tx:
 	if (!info->multi_irqs)
@@ -1443,13 +1444,14 @@ static void ravb_tx_timeout_work(struct work_struct *work)
 {
 	struct ravb_private *priv = container_of(work, struct ravb_private,
 						 work);
+	const struct ravb_hw_info *info = priv->info;
 	struct net_device *ndev = priv->ndev;
 	int error;
 
 	netif_tx_stop_all_queues(ndev);
 
 	/* Stop PTP Clock driver */
-	if (priv->chip_id == RCAR_GEN2)
+	if (info->no_ptp_cfg_active)
 		ravb_ptp_stop(ndev);
 
 	/* Wait for DMA stopping */
@@ -1484,7 +1486,7 @@ static void ravb_tx_timeout_work(struct work_struct *work)
 
 out:
 	/* Initialise PTP Clock driver */
-	if (priv->chip_id == RCAR_GEN2)
+	if (info->no_ptp_cfg_active)
 		ravb_ptp_init(ndev, priv->pdev);
 
 	netif_tx_start_all_queues(ndev);
@@ -1693,7 +1695,7 @@ static int ravb_close(struct net_device *ndev)
 	ravb_write(ndev, 0, TIC);
 
 	/* Stop PTP Clock driver */
-	if (priv->chip_id == RCAR_GEN2)
+	if (info->no_ptp_cfg_active)
 		ravb_ptp_stop(ndev);
 
 	/* Set the config mode to stop the AVB-DMAC's processes */
@@ -1954,6 +1956,7 @@ static const struct ravb_hw_info ravb_gen2_hw_info = {
 	.stats_len = ARRAY_SIZE(ravb_gstrings_stats),
 	.max_rx_len = RX_BUF_SZ + RAVB_ALIGN - 1,
 	.aligned_tx = 1,
+	.no_ptp_cfg_active = 1,
 };
 
 static const struct of_device_id ravb_match_table[] = {
@@ -1994,8 +1997,9 @@ static int ravb_set_gti(struct net_device *ndev)
 static void ravb_set_config_mode(struct net_device *ndev)
 {
 	struct ravb_private *priv = netdev_priv(ndev);
+	const struct ravb_hw_info *info = priv->info;
 
-	if (priv->chip_id == RCAR_GEN2) {
+	if (info->no_ptp_cfg_active) {
 		ravb_modify(ndev, CCC, CCC_OPC, CCC_OPC_CONFIG);
 		/* Set CSEL value */
 		ravb_modify(ndev, CCC, CCC_CSEL, CCC_CSEL_HPB);
-- 
2.17.1



  parent reply	other threads:[~2022-01-10 12:24 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10 12:22 [PATCH 5.10.y-cip 00/61] Add Ethernet support to RZ/G2L Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 01/61] dt-bindings: net: renesas,etheravb: Add additional clocks Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 02/61] dt-bindings: net: renesas,etheravb: Fix optional second clock name Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 03/61] dt-bindings: net: renesas,etheravb: Document Gigabit Ethernet IP Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 04/61] dt-bindings: net: renesas,etheravb: Drop "int_" prefix and "_n" suffix from interrupt names Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 05/61] net: ethernet: ravb: Enable optional refclk Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 06/61] net: ethernet: ravb: Fix release of refclk Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 07/61] net: ethernet: ravb: Use devm_platform_get_and_ioremap_resource() Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 08/61] ravb: Fix a typo in comment Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 09/61] ravb: Remove checks for unsupported internal delay modes Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 10/61] ravb: Use unsigned int for num_tx_desc variable in struct ravb_private Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 11/61] ravb: Add struct ravb_hw_info to driver data Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 12/61] ravb: Add aligned_tx to struct ravb_hw_info Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 13/61] ravb: Add max_rx_len " Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 14/61] ravb: Add stats_len " Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 15/61] ravb: Add gstrings_stats and gstrings_size " Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 16/61] ravb: Add net_features and net_hw_features " Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 17/61] ravb: Add internal delay hw feature " Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 18/61] ravb: Add tx_counters " Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 19/61] ravb: Remove the macros NUM_TX_DESC_GEN[23] Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 20/61] ravb: Add multi_irq to struct ravb_hw_info Lad Prabhakar
2022-01-10 12:22 ` Lad Prabhakar [this message]
2022-01-10 12:22 ` [PATCH 5.10.y-cip 22/61] ravb: Add ptp_cfg_active " Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 23/61] ravb: Factorise ravb_ring_free function Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 24/61] ravb: Factorise ravb_ring_format function Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 25/61] ravb: Factorise ravb_ring_init function Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 26/61] ravb: Factorise ravb_rx function Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 27/61] ravb: Factorise ravb_adjust_link function Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 28/61] ravb: Factorise ravb_set_features Lad Prabhakar
2022-01-10 12:22 ` [PATCH 5.10.y-cip 29/61] ravb: Factorise ravb_dmac_init function Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 30/61] ravb: Factorise ravb_emac_init function Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 31/61] ravb: Add reset support Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 32/61] ravb: Rename "ravb_set_features_rx_csum" function to "ravb_set_features_rcar" Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 33/61] ravb: Rename "no_ptp_cfg_active" and "ptp_cfg_active" variables Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 34/61] ravb: Add nc_queue to struct ravb_hw_info Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 35/61] ravb: Add support for RZ/G2L SoC Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 36/61] ravb: Initialize GbEthernet DMAC Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 37/61] ravb: remove APSR_DM Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 38/61] ravb: Exclude gPTP feature support for RZ/G2L Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 39/61] ravb: Add tsrq to struct ravb_hw_info Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 40/61] ravb: Add magic_pkt " Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 41/61] ravb: Add half_duplex " Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 42/61] ravb: update "undocumented" annotations Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 43/61] ravb: Remove extra TAB Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 44/61] ravb: Initialize GbEthernet E-MAC Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 45/61] ravb: Add rx_max_buf_size to struct ravb_hw_info Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 46/61] ravb: Use ALIGN macro for max_rx_len Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 47/61] ravb: Fillup ravb_alloc_rx_desc_gbeth() stub Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 48/61] ravb: Fillup ravb_rx_ring_free_gbeth() stub Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 49/61] ravb: Fillup ravb_rx_ring_format_gbeth() stub Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 50/61] ravb: Fillup ravb_rx_gbeth() stub Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 51/61] ravb: Add carrier_counters to struct ravb_hw_info Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 52/61] ravb: Add support to retrieve stats for GbEthernet Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 53/61] ravb: Rename "tsrq" variable Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 54/61] ravb: Optimize ravb_emac_init_gbeth function Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 55/61] ravb: Rename "nc_queue" feature bit Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 56/61] ravb: Update ravb_emac_init_gbeth() Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 57/61] ravb: Fix typo AVB->DMAC Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 58/61] clk: renesas: r9a07g044: Add ethernet clock sources Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 59/61] clk: renesas: r9a07g044: Add GbEthernet clock/reset Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 60/61] arm64: dts: renesas: r9a07g044: Add GbEthernet nodes Lad Prabhakar
2022-01-10 12:23 ` [PATCH 5.10.y-cip 61/61] arm64: dts: renesas: rzg2l-smarc-som: Enable Ethernet Lad Prabhakar
2022-01-11 11:54 ` [cip-dev] [PATCH 5.10.y-cip 00/61] Add Ethernet support to RZ/G2L Pavel Machek
     [not found] ` <16C93537A1693B9B.28404@lists.cip-project.org>
2022-01-12  9:45   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220110122331.24114-22-prabhakar.mahadev-lad.rj@bp.renesas.com \
    --to=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=cip-dev@lists.cip-project.org \
    --cc=nobuhiro1.iwamatsu@toshiba.co.jp \
    --cc=pavel@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.