All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tyler Hicks <tyhicks@linux.microsoft.com>
To: Lei Wang <lewan@microsoft.com>, Borislav Petkov <bp@alien8.de>,
	Tony Luck <tony.luck@intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Sinan Kaya <okaya@kernel.org>,
	Shiping Ji <shiping.linux@gmail.com>,
	James Morse <james.morse@arm.com>,
	Robert Richter <rric@kernel.org>,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] EDAC/dmc520: Don't print an error for each unconfigured interrupt line
Date: Tue, 11 Jan 2022 10:38:00 -0600	[thread overview]
Message-ID: <20220111163800.22362-1-tyhicks@linux.microsoft.com> (raw)

The dmc520 driver requires that at least one interrupt line, out of the ten
possible, is configured. The driver prints an error and returns -EINVAL
from its .probe function if there are no interrupt lines configured.

Don't print a KERN_ERR level message for each interrupt line that's
unconfigured as that can confuse users into thinking that there is an
error condition.

Before this change, the following KERN_ERR level messages would be
reported if only dram_ecc_errc and dram_ecc_errd were configured in the
device tree:

 dmc520 68000000.dmc: IRQ ram_ecc_errc not found
 dmc520 68000000.dmc: IRQ ram_ecc_errd not found
 dmc520 68000000.dmc: IRQ failed_access not found
 dmc520 68000000.dmc: IRQ failed_prog not found
 dmc520 68000000.dmc: IRQ link_err not
 dmc520 68000000.dmc: IRQ temperature_event not found
 dmc520 68000000.dmc: IRQ arch_fsm not found
 dmc520 68000000.dmc: IRQ phy_request not found

Fixes: 1088750d7839 ("EDAC: Add EDAC driver for DMC520")
Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>
Cc: <stable@vger.kernel.org>
Reported-by: Sinan Kaya <okaya@kernel.org>
---
 drivers/edac/dmc520_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/dmc520_edac.c b/drivers/edac/dmc520_edac.c
index b8a7d9594afd..1fa5ca57e9ec 100644
--- a/drivers/edac/dmc520_edac.c
+++ b/drivers/edac/dmc520_edac.c
@@ -489,7 +489,7 @@ static int dmc520_edac_probe(struct platform_device *pdev)
 	dev = &pdev->dev;
 
 	for (idx = 0; idx < NUMBER_OF_IRQS; idx++) {
-		irq = platform_get_irq_byname(pdev, dmc520_irq_configs[idx].name);
+		irq = platform_get_irq_byname_optional(pdev, dmc520_irq_configs[idx].name);
 		irqs[idx] = irq;
 		masks[idx] = dmc520_irq_configs[idx].mask;
 		if (irq >= 0) {
-- 
2.25.1


             reply	other threads:[~2022-01-11 16:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11 16:38 Tyler Hicks [this message]
2022-01-12 17:19 ` [PATCH] EDAC/dmc520: Don't print an error for each unconfigured interrupt line Lei Wang (DPLAT)
2022-01-16 18:29 ` Borislav Petkov
2022-01-18 15:28   ` Tyler Hicks
2022-01-18 17:28     ` Borislav Petkov
2022-01-18 19:54       ` Tyler Hicks
2022-01-18 21:04         ` Borislav Petkov
2022-01-19  9:17           ` Greg Kroah-Hartman
2022-01-19  9:37             ` Borislav Petkov
2022-01-19 10:28               ` Greg Kroah-Hartman
2022-04-04 21:56                 ` Tyler Hicks
2022-04-18 20:40                   ` Tyler Hicks
2022-04-18 21:13                     ` Borislav Petkov
2022-04-18 21:34                       ` Tyler Hicks
2022-04-19  9:36                         ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220111163800.22362-1-tyhicks@linux.microsoft.com \
    --to=tyhicks@linux.microsoft.com \
    --cc=bp@alien8.de \
    --cc=james.morse@arm.com \
    --cc=lewan@microsoft.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=okaya@kernel.org \
    --cc=rric@kernel.org \
    --cc=shiping.linux@gmail.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.