From: Maxime Ripard <maxime@cerno.tech> To: Mike Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org> Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, Dave Stevenson <dave.stevenson@raspberrypi.com>, Phil Elwell <phil@raspberrypi.com>, Tim Gover <tim.gover@raspberrypi.com>, Dom Cobley <dom@raspberrypi.com>, Maxime Ripard <maxime@cerno.tech> Subject: [PATCH v3 05/10] clk: Add clk_drop_range Date: Thu, 20 Jan 2022 15:34:12 +0100 [thread overview] Message-ID: <20220120143417.543744-6-maxime@cerno.tech> (raw) In-Reply-To: <20220120143417.543744-1-maxime@cerno.tech> In order to reset the range on a clock, we need to call clk_set_rate_range with a minimum of 0 and a maximum of ULONG_MAX. Since it's fairly inconvenient, let's introduce a clk_drop_range() function that will do just this. Suggested-by: Stephen Boyd <sboyd@kernel.org> Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/clk/clk-rate-test.c | 4 ++-- include/linux/clk.h | 11 +++++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-rate-test.c b/drivers/clk/clk-rate-test.c index baf0ea315322..9beed87f663c 100644 --- a/drivers/clk/clk-rate-test.c +++ b/drivers/clk/clk-rate-test.c @@ -458,7 +458,7 @@ static void clk_rate_range_test_multiple_set_range_rate_maximized(struct kunit * KUNIT_ASSERT_TRUE(test, rate > 0); KUNIT_ASSERT_EQ(test, rate, DUMMY_CLOCK_RATE_1); - ret = clk_set_rate_range(user2, 0, ULONG_MAX); + ret = clk_drop_range(user2); KUNIT_ASSERT_EQ(test, ret, 0); rate = clk_get_rate(clk); @@ -570,7 +570,7 @@ static void clk_rate_range_test_multiple_set_range_rate_minimized(struct kunit * KUNIT_ASSERT_TRUE(test, rate > 0); KUNIT_ASSERT_EQ(test, rate, DUMMY_CLOCK_RATE_2); - ret = clk_set_rate_range(user2, 0, ULONG_MAX); + ret = clk_drop_range(user2); KUNIT_ASSERT_EQ(test, ret, 0); rate = clk_get_rate(clk); diff --git a/include/linux/clk.h b/include/linux/clk.h index 266e8de3cb51..f365dac7be17 100644 --- a/include/linux/clk.h +++ b/include/linux/clk.h @@ -1005,6 +1005,17 @@ static inline struct clk *clk_get_optional(struct device *dev, const char *id) return clk; } +/** + * clk_drop_range - Reset any range set on that clock + * @clk: clock source + * + * Returns success (0) or negative errno. + */ +static inline int clk_drop_range(struct clk *clk) +{ + return clk_set_rate_range(clk, 0, ULONG_MAX); +} + #if defined(CONFIG_OF) && defined(CONFIG_COMMON_CLK) struct clk *of_clk_get(struct device_node *np, int index); struct clk *of_clk_get_by_name(struct device_node *np, const char *name); -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech> To: Mike Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org> Cc: Dom Cobley <dom@raspberrypi.com>, Tim Gover <tim.gover@raspberrypi.com>, Dave Stevenson <dave.stevenson@raspberrypi.com>, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, Maxime Ripard <maxime@cerno.tech>, Phil Elwell <phil@raspberrypi.com> Subject: [PATCH v3 05/10] clk: Add clk_drop_range Date: Thu, 20 Jan 2022 15:34:12 +0100 [thread overview] Message-ID: <20220120143417.543744-6-maxime@cerno.tech> (raw) In-Reply-To: <20220120143417.543744-1-maxime@cerno.tech> In order to reset the range on a clock, we need to call clk_set_rate_range with a minimum of 0 and a maximum of ULONG_MAX. Since it's fairly inconvenient, let's introduce a clk_drop_range() function that will do just this. Suggested-by: Stephen Boyd <sboyd@kernel.org> Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/clk/clk-rate-test.c | 4 ++-- include/linux/clk.h | 11 +++++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-rate-test.c b/drivers/clk/clk-rate-test.c index baf0ea315322..9beed87f663c 100644 --- a/drivers/clk/clk-rate-test.c +++ b/drivers/clk/clk-rate-test.c @@ -458,7 +458,7 @@ static void clk_rate_range_test_multiple_set_range_rate_maximized(struct kunit * KUNIT_ASSERT_TRUE(test, rate > 0); KUNIT_ASSERT_EQ(test, rate, DUMMY_CLOCK_RATE_1); - ret = clk_set_rate_range(user2, 0, ULONG_MAX); + ret = clk_drop_range(user2); KUNIT_ASSERT_EQ(test, ret, 0); rate = clk_get_rate(clk); @@ -570,7 +570,7 @@ static void clk_rate_range_test_multiple_set_range_rate_minimized(struct kunit * KUNIT_ASSERT_TRUE(test, rate > 0); KUNIT_ASSERT_EQ(test, rate, DUMMY_CLOCK_RATE_2); - ret = clk_set_rate_range(user2, 0, ULONG_MAX); + ret = clk_drop_range(user2); KUNIT_ASSERT_EQ(test, ret, 0); rate = clk_get_rate(clk); diff --git a/include/linux/clk.h b/include/linux/clk.h index 266e8de3cb51..f365dac7be17 100644 --- a/include/linux/clk.h +++ b/include/linux/clk.h @@ -1005,6 +1005,17 @@ static inline struct clk *clk_get_optional(struct device *dev, const char *id) return clk; } +/** + * clk_drop_range - Reset any range set on that clock + * @clk: clock source + * + * Returns success (0) or negative errno. + */ +static inline int clk_drop_range(struct clk *clk) +{ + return clk_set_rate_range(clk, 0, ULONG_MAX); +} + #if defined(CONFIG_OF) && defined(CONFIG_COMMON_CLK) struct clk *of_clk_get(struct device_node *np, int index); struct clk *of_clk_get_by_name(struct device_node *np, const char *name); -- 2.34.1
next prev parent reply other threads:[~2022-01-20 14:34 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-20 14:34 [PATCH v3 00/10] clk: Improve clock range handling Maxime Ripard 2022-01-20 14:34 ` Maxime Ripard 2022-01-20 14:34 ` [PATCH v3 01/10] clk: Add Kunit tests for rate Maxime Ripard 2022-01-20 14:34 ` Maxime Ripard 2022-01-20 21:31 ` Stephen Boyd 2022-01-20 21:31 ` Stephen Boyd 2022-01-20 21:56 ` Daniel Latypov 2022-01-20 21:56 ` Daniel Latypov 2022-01-21 4:34 ` Stephen Boyd 2022-01-21 4:34 ` Stephen Boyd 2022-01-21 5:25 ` Daniel Latypov 2022-01-21 5:25 ` Daniel Latypov 2022-01-22 1:51 ` Stephen Boyd 2022-01-22 1:51 ` Stephen Boyd 2022-01-20 14:34 ` [PATCH v3 02/10] clk: Always clamp the rounded rate Maxime Ripard 2022-01-20 14:34 ` Maxime Ripard 2022-01-20 14:34 ` [PATCH v3 03/10] clk: Use clamp instead of open-coding our own Maxime Ripard 2022-01-20 14:34 ` Maxime Ripard 2022-01-20 14:34 ` [PATCH v3 04/10] clk: Always set the rate on clk_set_range_rate Maxime Ripard 2022-01-20 14:34 ` Maxime Ripard 2022-01-20 14:34 ` Maxime Ripard [this message] 2022-01-20 14:34 ` [PATCH v3 05/10] clk: Add clk_drop_range Maxime Ripard 2022-01-20 14:34 ` [PATCH v3 06/10] clk: bcm: rpi: Add variant structure Maxime Ripard 2022-01-20 14:34 ` Maxime Ripard 2022-01-20 14:34 ` [PATCH v3 07/10] clk: bcm: rpi: Set a default minimum rate Maxime Ripard 2022-01-20 14:34 ` Maxime Ripard 2022-01-20 14:34 ` [PATCH v3 08/10] clk: bcm: rpi: Run some clocks at the minimum rate allowed Maxime Ripard 2022-01-20 14:34 ` Maxime Ripard 2022-01-20 14:34 ` [PATCH v3 09/10] drm/vc4: Add logging and comments Maxime Ripard 2022-01-20 14:34 ` Maxime Ripard 2022-01-20 14:34 ` [PATCH v3 10/10] drm/vc4: hdmi: Remove clock rate initialization Maxime Ripard 2022-01-20 14:34 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220120143417.543744-6-maxime@cerno.tech \ --to=maxime@cerno.tech \ --cc=dave.stevenson@raspberrypi.com \ --cc=dom@raspberrypi.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-clk@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=phil@raspberrypi.com \ --cc=sboyd@kernel.org \ --cc=tim.gover@raspberrypi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.