From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Sean Christopherson <seanjc@google.com>
Subject: [kvm-unit-tests PATCH 0/8] x86: APIC bug fix and cleanup
Date: Fri, 21 Jan 2022 23:18:44 +0000 [thread overview]
Message-ID: <20220121231852.1439917-1-seanjc@google.com> (raw)
Fix a bug introduced by the UEFI support where setup_tss() can race with
enable_x2apic() and crash the test due to attempting to read an x2APIC MSR
prior to enabling x2APIC (failure manifests in smptest3).
In an attempt to avoid similar bugs in the future, clean up the per-cpu
stuff and convert apic_ops into a per-cpu pointer. 32-bit KUT has a
chick-and-egg problem due to using the APIC ID to choose the selector
for GS (the per-cpu segment), so the original bug "has" to say on a
dedicated helper.
Sean Christopherson (8):
x86: Always use legacy xAPIC to get APIC ID during TSS setup
x86: nVMX: Load actual GS.base for both guest and host
x86: smp: Replace spaces with tabs
x86: desc: Replace spaces with tabs
x86: Add proper helpers for per-cpu reads/writes
x86: apic: Replace spaces with tabs
x86: apic: Track APIC ops on a per-cpu basis
x86: apic: Make xAPIC and I/O APIC pointers static
lib/x86/apic-defs.h | 3 +-
lib/x86/apic.c | 157 ++++++++++++++++++++++++--------------------
lib/x86/apic.h | 5 +-
lib/x86/desc.c | 120 ++++++++++++++++-----------------
lib/x86/desc.h | 68 +++++++++----------
lib/x86/setup.c | 4 +-
lib/x86/smp.c | 128 +++++++++++++++++-------------------
lib/x86/smp.h | 67 +++++++++++++++++++
x86/vmx.c | 4 +-
9 files changed, 311 insertions(+), 245 deletions(-)
base-commit: 3df301615cead4142fe28629d86142de32fc6768
--
2.35.0.rc0.227.g00780c9af4-goog
next reply other threads:[~2022-01-21 23:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 23:18 Sean Christopherson [this message]
2022-01-21 23:18 ` [kvm-unit-tests PATCH 1/8] x86: Always use legacy xAPIC to get APIC ID during TSS setup Sean Christopherson
2022-01-22 1:18 ` David Matlack
2022-01-21 23:18 ` [kvm-unit-tests PATCH 2/8] x86: nVMX: Load actual GS.base for both guest and host Sean Christopherson
2022-01-21 23:18 ` [kvm-unit-tests PATCH 3/8] x86: smp: Replace spaces with tabs Sean Christopherson
2022-01-21 23:18 ` [kvm-unit-tests PATCH 4/8] x86: desc: " Sean Christopherson
2022-01-21 23:18 ` [kvm-unit-tests PATCH 5/8] x86: Add proper helpers for per-cpu reads/writes Sean Christopherson
2022-01-21 23:18 ` [kvm-unit-tests PATCH 6/8] x86: apic: Replace spaces with tabs Sean Christopherson
2022-01-21 23:18 ` [kvm-unit-tests PATCH 7/8] x86: apic: Track APIC ops on a per-cpu basis Sean Christopherson
2022-01-21 23:18 ` [kvm-unit-tests PATCH 8/8] x86: apic: Make xAPIC and I/O APIC pointers static Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121231852.1439917-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.