All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jinrong Liang <ljr.kernel@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Xianting Tian <xianting.tian@linux.alibaba.com>,
	Jim Mattson <jmattson@google.com>,
	Sean Christopherson <seanjc@google.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Joerg Roedel <joro@8bytes.org>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 00/19] KVM: x86: Bulk removal of unused function parameters
Date: Tue, 25 Jan 2022 17:58:50 +0800	[thread overview]
Message-ID: <20220125095909.38122-1-cloudliang@tencent.com> (raw)

From: Like Xu <likexu@tencent.com>

Hi,

This patch set is a follow up to a similar patch [1], and may
hopefully help to improve the code quality of KVM.

Basically, the cleanup is triggered by a compiler feature[2], but obviously
there are a lot of false positives here, and so far we may apply at least
this changset, which also helps the related developers to think more
carefully about why these functions were declared that way in the first
place or what is left after a series of loosely-coupled clean-ups.

[1] https://lore.kernel.org/kvm/20220124020456.156386-1-xianting.tian@linux.alibaba.com/
[2] ccflags-y += -Wunused-parameter

Thanks,
Like Xu

Jinrong Liang (19):
  KVM: x86/mmu: Remove unused "kvm" of kvm_mmu_unlink_parents()
  KVM: x86/mmu: Remove unused "kvm" of __rmap_write_protect()
  KVM: x86/mmu: Remove unused "vcpu" of
    reset_{tdp,ept}_shadow_zero_bits_mask()
  KVM: x86/tdp_mmu: Remove unused "kvm" of kvm_tdp_mmu_get_root()
  KVM: x86/mmu_audit: Remove unused "level" of audit_spte_after_sync()
  KVM: x86/svm: Remove unused "vcpu" of svm_check_exit_valid()
  KVM: x86/svm: Remove unused "vcpu" of nested_svm_check_tlb_ctl()
  KVM: x86/svm: Remove unused "vcpu" of kvm_after_interrupt()
  KVM: x86/sev: Remove unused "svm" of sev_es_prepare_guest_switch()
  KVM: x86/sev: Remove unused "kvm" of sev_unbind_asid()
  KVM: x86/sev: Remove unused "vector" of sev_vcpu_deliver_sipi_vector()
  KVM: x86/i8259: Remove unused "addr" of elcr_ioport_{read,write}()
  KVM: x86/ioapic: Remove unused "addr" and "length" of
    ioapic_read_indirect()
  KVM: x86/emulate: Remove unused "ctxt" of setup_syscalls_segments()
  KVM: x86/emulate: Remove unused "ctxt" of task_switch_{16, 32}()
  KVM: x86: Remove unused "vcpu" of kvm_arch_tsc_has_attr()
  KVM: x86: Remove unused "vcpu" of kvm_scale_tsc()
  KVM: Remove unused "kvm" of kvm_make_vcpu_request()
  KVM: Remove unused "flags" of kvm_pv_kick_cpu_op()

 arch/x86/include/asm/kvm_host.h |  2 +-
 arch/x86/kvm/emulate.c          | 20 ++++++++------------
 arch/x86/kvm/i8259.c            |  8 ++++----
 arch/x86/kvm/ioapic.c           |  6 ++----
 arch/x86/kvm/mmu/mmu.c          | 23 ++++++++++-------------
 arch/x86/kvm/mmu/mmu_audit.c    |  4 ++--
 arch/x86/kvm/mmu/tdp_mmu.c      |  4 ++--
 arch/x86/kvm/mmu/tdp_mmu.h      |  3 +--
 arch/x86/kvm/svm/nested.c       |  4 ++--
 arch/x86/kvm/svm/sev.c          | 12 ++++++------
 arch/x86/kvm/svm/svm.c          | 10 +++++-----
 arch/x86/kvm/svm/svm.h          |  4 ++--
 arch/x86/kvm/vmx/vmx.c          |  2 +-
 arch/x86/kvm/x86.c              | 25 ++++++++++++-------------
 arch/x86/kvm/x86.h              |  2 +-
 virt/kvm/kvm_main.c             |  9 ++++-----
 16 files changed, 63 insertions(+), 75 deletions(-)

-- 
2.33.1


             reply	other threads:[~2022-01-25 10:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25  9:58 Jinrong Liang [this message]
2022-01-25  9:58 ` [PATCH 01/19] KVM: x86/mmu: Remove unused "kvm" of kvm_mmu_unlink_parents() Jinrong Liang
2022-01-25  9:58 ` [PATCH 02/19] KVM: x86/mmu: Remove unused "kvm" of __rmap_write_protect() Jinrong Liang
2022-01-25  9:58 ` [PATCH 03/19] KVM: x86/mmu: Remove unused "vcpu" of reset_{tdp,ept}_shadow_zero_bits_mask() Jinrong Liang
2022-01-25  9:58 ` [PATCH 04/19] KVM: x86/tdp_mmu: Remove unused "kvm" of kvm_tdp_mmu_get_root() Jinrong Liang
2022-01-25  9:58 ` [PATCH 05/19] KVM: x86/mmu_audit: Remove unused "level" of audit_spte_after_sync() Jinrong Liang
2022-01-25  9:58 ` [PATCH 06/19] KVM: x86/svm: Remove unused "vcpu" of svm_check_exit_valid() Jinrong Liang
2022-01-25  9:58 ` [PATCH 07/19] KVM: x86/svm: Remove unused "vcpu" of nested_svm_check_tlb_ctl() Jinrong Liang
2022-01-25 16:02   ` Paolo Bonzini
2022-01-25  9:58 ` [PATCH 08/19] KVM: x86: Remove unused "vcpu" of kvm_after_interrupt() Jinrong Liang
2022-01-25  9:58 ` [PATCH 09/19] KVM: x86/svm: Remove unused "svm" of sev_es_prepare_guest_switch() Jinrong Liang
2022-01-25 16:29   ` Paolo Bonzini
2022-01-25  9:59 ` [PATCH 10/19] KVM: x86/sev: Remove unused "kvm" of sev_unbind_asid() Jinrong Liang
2022-01-25  9:59 ` [PATCH 11/19] KVM: x86/svm: Remove unused "vector" of sev_vcpu_deliver_sipi_vector() Jinrong Liang
2022-01-25 16:16   ` Paolo Bonzini
2022-01-25  9:59 ` [PATCH 12/19] KVM: x86/i8259: Remove unused "addr" of elcr_ioport_{read,write}() Jinrong Liang
2022-01-25  9:59 ` [PATCH 13/19] KVM: x86/ioapic: Remove unused "addr" and "length" of ioapic_read_indirect() Jinrong Liang
2022-01-25  9:59 ` [PATCH 14/19] KVM: x86/emulate: Remove unused "ctxt" of setup_syscalls_segments() Jinrong Liang
2022-01-25  9:59 ` [PATCH 15/19] KVM: x86/emulate: Remove unused "ctxt" of task_switch_{16, 32}() Jinrong Liang
2022-01-25 16:29   ` Paolo Bonzini
2022-01-25  9:59 ` [PATCH 16/19] KVM: x86: Remove unused "vcpu" of kvm_arch_tsc_has_attr() Jinrong Liang
2022-01-25 16:31   ` Paolo Bonzini
2022-01-25  9:59 ` [PATCH 17/19] KVM: x86: Remove unused "vcpu" of kvm_scale_tsc() Jinrong Liang
2022-01-25  9:59 ` [PATCH 18/19] KVM: Remove unused "kvm" of kvm_make_vcpu_request() Jinrong Liang
2022-01-25  9:59 ` [PATCH 19/19] KVM: Remove unused "flags" of kvm_pv_kick_cpu_op() Jinrong Liang
2022-01-25 16:32 ` [PATCH 00/19] KVM: x86: Bulk removal of unused function parameters Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220125095909.38122-1-cloudliang@tencent.com \
    --to=ljr.kernel@gmail.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=xianting.tian@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.