From: Maxime Ripard <maxime@cerno.tech> To: Mike Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org> Cc: Dom Cobley <dom@raspberrypi.com>, Tim Gover <tim.gover@raspberrypi.com>, Dave Stevenson <dave.stevenson@raspberrypi.com>, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, Maxime Ripard <maxime@cerno.tech>, Phil Elwell <phil@raspberrypi.com> Subject: [PATCH v4 03/10] clk: Use clamp instead of open-coding our own Date: Tue, 25 Jan 2022 15:15:42 +0100 [thread overview] Message-ID: <20220125141549.747889-4-maxime@cerno.tech> (raw) In-Reply-To: <20220125141549.747889-1-maxime@cerno.tech> The code in clk_set_rate_range() will, if the current rate is outside of the new range, will force it to the minimum or maximum. This is equivalent to using clamp, while being less readable. Let's switch to using clamp instead. Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/clk/clk.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 7bb5ae0fb688..150d1bc0985b 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -2365,11 +2365,7 @@ int clk_set_rate_range(struct clk *clk, unsigned long min, unsigned long max) * this corner case when determining the rate */ - if (rate < min) - rate = min; - else - rate = max; - + rate = clamp(clk->core->req_rate, min, max); ret = clk_core_set_rate_nolock(clk->core, rate); if (ret) { /* rollback the changes */ -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech> To: Mike Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org> Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, Dave Stevenson <dave.stevenson@raspberrypi.com>, Phil Elwell <phil@raspberrypi.com>, Tim Gover <tim.gover@raspberrypi.com>, Dom Cobley <dom@raspberrypi.com>, Maxime Ripard <maxime@cerno.tech> Subject: [PATCH v4 03/10] clk: Use clamp instead of open-coding our own Date: Tue, 25 Jan 2022 15:15:42 +0100 [thread overview] Message-ID: <20220125141549.747889-4-maxime@cerno.tech> (raw) In-Reply-To: <20220125141549.747889-1-maxime@cerno.tech> The code in clk_set_rate_range() will, if the current rate is outside of the new range, will force it to the minimum or maximum. This is equivalent to using clamp, while being less readable. Let's switch to using clamp instead. Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/clk/clk.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 7bb5ae0fb688..150d1bc0985b 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -2365,11 +2365,7 @@ int clk_set_rate_range(struct clk *clk, unsigned long min, unsigned long max) * this corner case when determining the rate */ - if (rate < min) - rate = min; - else - rate = max; - + rate = clamp(clk->core->req_rate, min, max); ret = clk_core_set_rate_nolock(clk->core, rate); if (ret) { /* rollback the changes */ -- 2.34.1
next prev parent reply other threads:[~2022-01-25 14:16 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-25 14:15 [PATCH v4 00/10] clk: Improve clock range handling Maxime Ripard 2022-01-25 14:15 ` Maxime Ripard 2022-01-25 14:15 ` [PATCH v4 01/10] clk: Introduce Kunit Tests for the framework Maxime Ripard 2022-01-25 14:15 ` Maxime Ripard 2022-02-19 2:20 ` Stephen Boyd 2022-02-19 2:20 ` Stephen Boyd 2022-02-21 15:12 ` Maxime Ripard 2022-02-21 15:12 ` Maxime Ripard 2022-02-24 22:30 ` Stephen Boyd 2022-02-24 22:30 ` Stephen Boyd 2022-01-25 14:15 ` [PATCH v4 02/10] clk: Always clamp the rounded rate Maxime Ripard 2022-01-25 14:15 ` Maxime Ripard 2022-02-18 23:15 ` Stephen Boyd 2022-02-18 23:15 ` Stephen Boyd 2022-02-21 16:18 ` Maxime Ripard 2022-02-21 16:18 ` Maxime Ripard 2022-02-21 16:43 ` Maxime Ripard 2022-02-21 16:43 ` Maxime Ripard 2022-02-24 22:39 ` Stephen Boyd 2022-02-24 22:39 ` Stephen Boyd 2022-02-25 9:35 ` Maxime Ripard 2022-02-25 9:35 ` Maxime Ripard 2022-02-24 22:32 ` Stephen Boyd 2022-02-24 22:32 ` Stephen Boyd 2022-02-25 9:45 ` Maxime Ripard 2022-02-25 9:45 ` Maxime Ripard 2022-01-25 14:15 ` Maxime Ripard [this message] 2022-01-25 14:15 ` [PATCH v4 03/10] clk: Use clamp instead of open-coding our own Maxime Ripard 2022-02-18 22:34 ` Stephen Boyd 2022-02-18 22:34 ` Stephen Boyd 2022-02-21 16:30 ` Maxime Ripard 2022-02-21 16:30 ` Maxime Ripard 2022-02-24 22:44 ` Stephen Boyd 2022-02-24 22:44 ` Stephen Boyd 2022-02-25 9:39 ` Maxime Ripard 2022-02-25 9:39 ` Maxime Ripard 2022-01-25 14:15 ` [PATCH v4 04/10] clk: Always set the rate on clk_set_range_rate Maxime Ripard 2022-01-25 14:15 ` Maxime Ripard 2022-01-25 14:15 ` [PATCH v4 05/10] clk: Add clk_drop_range Maxime Ripard 2022-01-25 14:15 ` Maxime Ripard 2022-02-19 2:22 ` Stephen Boyd 2022-02-19 2:22 ` Stephen Boyd 2022-01-25 14:15 ` [PATCH v4 06/10] clk: bcm: rpi: Add variant structure Maxime Ripard 2022-01-25 14:15 ` Maxime Ripard 2022-01-25 14:15 ` [PATCH v4 07/10] clk: bcm: rpi: Set a default minimum rate Maxime Ripard 2022-01-25 14:15 ` Maxime Ripard 2022-01-25 14:15 ` [PATCH v4 08/10] clk: bcm: rpi: Run some clocks at the minimum rate allowed Maxime Ripard 2022-01-25 14:15 ` Maxime Ripard 2022-01-25 14:15 ` [PATCH v4 09/10] drm/vc4: Add logging and comments Maxime Ripard 2022-01-25 14:15 ` Maxime Ripard 2022-01-25 14:15 ` [PATCH v4 10/10] drm/vc4: hdmi: Remove clock rate initialization Maxime Ripard 2022-01-25 14:15 ` Maxime Ripard 2022-02-10 10:19 ` [PATCH v4 00/10] clk: Improve clock range handling Maxime Ripard 2022-02-10 10:19 ` Maxime Ripard 2022-02-19 2:25 ` Stephen Boyd 2022-02-19 2:25 ` Stephen Boyd 2022-02-14 9:45 ` [PATCH v4 0/10] " Laurent Pinchart 2022-02-14 9:45 ` Laurent Pinchart 2022-02-19 2:24 ` Stephen Boyd 2022-02-19 2:24 ` Stephen Boyd 2022-02-21 9:56 ` Laurent Pinchart 2022-02-21 9:56 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220125141549.747889-4-maxime@cerno.tech \ --to=maxime@cerno.tech \ --cc=dave.stevenson@raspberrypi.com \ --cc=dom@raspberrypi.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-clk@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=phil@raspberrypi.com \ --cc=sboyd@kernel.org \ --cc=tim.gover@raspberrypi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.