From: Miquel Raynal <miquel.raynal@bootlin.com> To: Mark Brown <broonie@kernel.org>, <linux-spi@vger.kernel.org> Cc: Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Tudor Ambarus <Tudor.Ambarus@microchip.com>, Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>, <linux-mtd@lists.infradead.org>, Boris Brezillon <boris.brezillon@collabora.com>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Julien Su <juliensu@mxic.com.tw>, Jaime Liao <jaimeliao@mxic.com.tw>, Miquel Raynal <miquel.raynal@bootlin.com> Subject: [PATCH v10 02/13] spi: spi-mem: Check the controller extra capabilities Date: Thu, 27 Jan 2022 10:17:57 +0100 [thread overview] Message-ID: <20220127091808.1043392-3-miquel.raynal@bootlin.com> (raw) In-Reply-To: <20220127091808.1043392-1-miquel.raynal@bootlin.com> Controllers can now provide a spi-mem capabilities structure. Let's make use of it in spi_mem_controller_default_supports_op(). As we want to check for DTR operations as well as normal operations in a single helper, let's pull the necessary checks from spi_mem_dtr_supports_op() for now. However, because no controller provide these extra capabilities, this change has no effect so far. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Reviewed-by: Pratyush Yadav <p.yadav@ti.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Link: https://lore.kernel.org/linux-mtd/20220104083631.40776-3-miquel.raynal@bootlin.com --- drivers/spi/spi-mem.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c index 37f4443ce9a0..86e6597bc3dc 100644 --- a/drivers/spi/spi-mem.c +++ b/drivers/spi/spi-mem.c @@ -173,11 +173,20 @@ EXPORT_SYMBOL_GPL(spi_mem_dtr_supports_op); bool spi_mem_default_supports_op(struct spi_mem *mem, const struct spi_mem_op *op) { - if (op->cmd.dtr || op->addr.dtr || op->dummy.dtr || op->data.dtr) - return false; + struct spi_controller *ctlr = mem->spi->controller; + bool op_is_dtr = + op->cmd.dtr || op->addr.dtr || op->dummy.dtr || op->data.dtr; - if (op->cmd.nbytes != 1) - return false; + if (op_is_dtr) { + if (!spi_mem_controller_is_capable(ctlr, dtr)) + return false; + + if (op->cmd.nbytes != 2) + return false; + } else { + if (op->cmd.nbytes != 1) + return false; + } return spi_mem_check_buswidth(mem, op); } -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: Mark Brown <broonie@kernel.org>, <linux-spi@vger.kernel.org> Cc: Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Tudor Ambarus <Tudor.Ambarus@microchip.com>, Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>, <linux-mtd@lists.infradead.org>, Boris Brezillon <boris.brezillon@collabora.com>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Julien Su <juliensu@mxic.com.tw>, Jaime Liao <jaimeliao@mxic.com.tw>, Miquel Raynal <miquel.raynal@bootlin.com> Subject: [PATCH v10 02/13] spi: spi-mem: Check the controller extra capabilities Date: Thu, 27 Jan 2022 10:17:57 +0100 [thread overview] Message-ID: <20220127091808.1043392-3-miquel.raynal@bootlin.com> (raw) In-Reply-To: <20220127091808.1043392-1-miquel.raynal@bootlin.com> Controllers can now provide a spi-mem capabilities structure. Let's make use of it in spi_mem_controller_default_supports_op(). As we want to check for DTR operations as well as normal operations in a single helper, let's pull the necessary checks from spi_mem_dtr_supports_op() for now. However, because no controller provide these extra capabilities, this change has no effect so far. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Reviewed-by: Pratyush Yadav <p.yadav@ti.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Link: https://lore.kernel.org/linux-mtd/20220104083631.40776-3-miquel.raynal@bootlin.com --- drivers/spi/spi-mem.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c index 37f4443ce9a0..86e6597bc3dc 100644 --- a/drivers/spi/spi-mem.c +++ b/drivers/spi/spi-mem.c @@ -173,11 +173,20 @@ EXPORT_SYMBOL_GPL(spi_mem_dtr_supports_op); bool spi_mem_default_supports_op(struct spi_mem *mem, const struct spi_mem_op *op) { - if (op->cmd.dtr || op->addr.dtr || op->dummy.dtr || op->data.dtr) - return false; + struct spi_controller *ctlr = mem->spi->controller; + bool op_is_dtr = + op->cmd.dtr || op->addr.dtr || op->dummy.dtr || op->data.dtr; - if (op->cmd.nbytes != 1) - return false; + if (op_is_dtr) { + if (!spi_mem_controller_is_capable(ctlr, dtr)) + return false; + + if (op->cmd.nbytes != 2) + return false; + } else { + if (op->cmd.nbytes != 1) + return false; + } return spi_mem_check_buswidth(mem, op); } -- 2.27.0 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-01-27 9:18 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-27 9:17 [PATCH v10 00/13] External ECC engines & Macronix support Miquel Raynal 2022-01-27 9:17 ` Miquel Raynal 2022-01-27 9:17 ` [PATCH v10 01/13] spi: spi-mem: Introduce a capability structure Miquel Raynal 2022-01-27 9:17 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-27 9:17 ` Miquel Raynal [this message] 2022-01-27 9:17 ` [PATCH v10 02/13] spi: spi-mem: Check the controller extra capabilities Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-27 9:17 ` [PATCH v10 03/13] spi: cadence-quadspi: Provide a capability structure Miquel Raynal 2022-01-27 9:17 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-27 9:17 ` [PATCH v10 04/13] spi: mxic: " Miquel Raynal 2022-01-27 9:17 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-27 9:18 ` [PATCH v10 05/13] spi: spi-mem: Kill the spi_mem_dtr_supports_op() helper Miquel Raynal 2022-01-27 9:18 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-27 9:18 ` [PATCH v10 06/13] spi: spi-mem: Add an ecc parameter to the spi_mem_op structure Miquel Raynal 2022-01-27 9:18 ` Miquel Raynal 2022-01-28 8:03 ` Tudor.Ambarus 2022-01-28 8:03 ` Tudor.Ambarus 2022-01-31 16:22 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-27 9:18 ` [PATCH v10 07/13] mtd: spinand: Delay a little bit the dirmap creation Miquel Raynal 2022-01-27 9:18 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-27 9:18 ` [PATCH v10 08/13] mtd: spinand: Create direct mapping descriptors for ECC operations Miquel Raynal 2022-01-27 9:18 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-27 9:18 ` [PATCH v10 09/13] spi: mxic: Fix the transmit path Miquel Raynal 2022-01-27 9:18 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-27 9:18 ` [PATCH v10 10/13] spi: mxic: Create a helper to configure the controller before an operation Miquel Raynal 2022-01-27 9:18 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-31 16:22 ` Miquel Raynal 2022-01-27 9:18 ` [PATCH v10 11/13] spi: mxic: Create a helper to ease the start of " Miquel Raynal 2022-01-27 9:18 ` Miquel Raynal 2022-01-31 16:21 ` Miquel Raynal 2022-01-31 16:21 ` Miquel Raynal 2022-01-27 9:18 ` [PATCH v10 12/13] spi: mxic: Add support for direct mapping Miquel Raynal 2022-01-27 9:18 ` Miquel Raynal 2022-01-31 16:21 ` Miquel Raynal 2022-01-31 16:21 ` Miquel Raynal 2022-01-27 9:18 ` [PATCH v10 13/13] spi: mxic: Add support for pipelined ECC operations Miquel Raynal 2022-01-27 9:18 ` Miquel Raynal 2022-01-31 16:21 ` Miquel Raynal 2022-01-31 16:21 ` Miquel Raynal 2022-01-27 19:56 ` [PATCH v10 00/13] External ECC engines & Macronix support Mark Brown 2022-01-27 19:56 ` Mark Brown 2022-01-28 8:08 ` Miquel Raynal 2022-01-28 8:08 ` Miquel Raynal 2022-01-28 22:34 ` Mark Brown 2022-01-28 22:34 ` Mark Brown 2022-01-31 13:49 ` Miquel Raynal 2022-01-31 13:49 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220127091808.1043392-3-miquel.raynal@bootlin.com \ --to=miquel.raynal@bootlin.com \ --cc=Tudor.Ambarus@microchip.com \ --cc=boris.brezillon@collabora.com \ --cc=broonie@kernel.org \ --cc=jaimeliao@mxic.com.tw \ --cc=juliensu@mxic.com.tw \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=michael@walle.cc \ --cc=p.yadav@ti.com \ --cc=richard@nod.at \ --cc=thomas.petazzoni@bootlin.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.