All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Sierra <alex.sierra@amd.com>
To: <akpm@linux-foundation.org>, <Felix.Kuehling@amd.com>,
	<linux-mm@kvack.org>, <rcampbell@nvidia.com>,
	<linux-ext4@vger.kernel.org>, <linux-xfs@vger.kernel.org>
Cc: <amd-gfx@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <hch@lst.de>, <jgg@nvidia.com>,
	<jglisse@redhat.com>, <apopple@nvidia.com>, <willy@infradead.org>
Subject: [PATCH v5 03/10] mm/gup: fail get_user_pages for LONGTERM dev coherent type
Date: Fri, 28 Jan 2022 14:08:18 -0600	[thread overview]
Message-ID: <20220128200825.8623-4-alex.sierra@amd.com> (raw)
In-Reply-To: <20220128200825.8623-1-alex.sierra@amd.com>

Avoid long term pinning for Coherent device type pages. This could
interfere with their own device memory manager. For now, we are just
returning error for PIN_LONGTERM Coherent device type pages. Eventually,
these type of pages will get migrated to system memory, once the device
migration pages support is added.

Signed-off-by: Alex Sierra <alex.sierra@amd.com>
Acked-by: Felix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: Alistair Poppple <apopple@nvidia.com>
---
 mm/gup.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/mm/gup.c b/mm/gup.c
index f0af462ac1e2..f596b932d7d7 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -1864,6 +1864,12 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
 		 * If we get a movable page, since we are going to be pinning
 		 * these entries, try to move them out if possible.
 		 */
+		if (is_dev_private_or_coherent_page(head)) {
+			WARN_ON_ONCE(is_device_private_page(head));
+			ret = -EFAULT;
+			goto unpin_pages;
+		}
+
 		if (!is_pinnable_page(head)) {
 			if (PageHuge(head)) {
 				if (!isolate_huge_page(head, &movable_page_list))
@@ -1894,6 +1900,7 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
 	if (list_empty(&movable_page_list) && !isolation_error_count)
 		return nr_pages;
 
+unpin_pages:
 	if (gup_flags & FOLL_PIN) {
 		unpin_user_pages(pages, nr_pages);
 	} else {
-- 
2.32.0


WARNING: multiple messages have this Message-ID (diff)
From: Alex Sierra <alex.sierra@amd.com>
To: <akpm@linux-foundation.org>, <Felix.Kuehling@amd.com>,
	<linux-mm@kvack.org>, <rcampbell@nvidia.com>,
	<linux-ext4@vger.kernel.org>, <linux-xfs@vger.kernel.org>
Cc: willy@infradead.org, apopple@nvidia.com,
	dri-devel@lists.freedesktop.org, jglisse@redhat.com,
	amd-gfx@lists.freedesktop.org, jgg@nvidia.com, hch@lst.de
Subject: [PATCH v5 03/10] mm/gup: fail get_user_pages for LONGTERM dev coherent type
Date: Fri, 28 Jan 2022 14:08:18 -0600	[thread overview]
Message-ID: <20220128200825.8623-4-alex.sierra@amd.com> (raw)
In-Reply-To: <20220128200825.8623-1-alex.sierra@amd.com>

Avoid long term pinning for Coherent device type pages. This could
interfere with their own device memory manager. For now, we are just
returning error for PIN_LONGTERM Coherent device type pages. Eventually,
these type of pages will get migrated to system memory, once the device
migration pages support is added.

Signed-off-by: Alex Sierra <alex.sierra@amd.com>
Acked-by: Felix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: Alistair Poppple <apopple@nvidia.com>
---
 mm/gup.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/mm/gup.c b/mm/gup.c
index f0af462ac1e2..f596b932d7d7 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -1864,6 +1864,12 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
 		 * If we get a movable page, since we are going to be pinning
 		 * these entries, try to move them out if possible.
 		 */
+		if (is_dev_private_or_coherent_page(head)) {
+			WARN_ON_ONCE(is_device_private_page(head));
+			ret = -EFAULT;
+			goto unpin_pages;
+		}
+
 		if (!is_pinnable_page(head)) {
 			if (PageHuge(head)) {
 				if (!isolate_huge_page(head, &movable_page_list))
@@ -1894,6 +1900,7 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
 	if (list_empty(&movable_page_list) && !isolation_error_count)
 		return nr_pages;
 
+unpin_pages:
 	if (gup_flags & FOLL_PIN) {
 		unpin_user_pages(pages, nr_pages);
 	} else {
-- 
2.32.0


  parent reply	other threads:[~2022-01-28 20:09 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28 20:08 [PATCH v5 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping Alex Sierra
2022-01-28 20:08 ` Alex Sierra
2022-01-28 20:08 ` [PATCH v5 01/10] mm: add zone device coherent type memory support Alex Sierra
2022-01-28 20:08   ` Alex Sierra
2022-01-31  6:20   ` Alistair Popple
2022-01-31  6:20     ` Alistair Popple
2022-01-28 20:08 ` [PATCH v5 02/10] mm: add device coherent vma selection for memory migration Alex Sierra
2022-01-28 20:08   ` Alex Sierra
2022-01-31  6:32   ` Alistair Popple
2022-01-31  6:32     ` Alistair Popple
2022-01-31 19:48   ` [PATCH] " Alex Sierra
2022-01-31 19:48     ` Alex Sierra
2022-01-31 23:04     ` Alistair Popple
2022-01-31 23:04       ` Alistair Popple
2022-01-28 20:08 ` Alex Sierra [this message]
2022-01-28 20:08   ` [PATCH v5 03/10] mm/gup: fail get_user_pages for LONGTERM dev coherent type Alex Sierra
2022-01-28 20:08 ` [PATCH v5 04/10] drm/amdkfd: add SPM support for SVM Alex Sierra
2022-01-28 20:08   ` Alex Sierra
2022-01-28 20:08 ` [PATCH v5 05/10] drm/amdkfd: coherent type as sys mem on migration to ram Alex Sierra
2022-01-28 20:08   ` Alex Sierra
2022-01-28 20:08 ` [PATCH v5 06/10] lib: test_hmm add ioctl to get zone device type Alex Sierra
2022-01-28 20:08   ` Alex Sierra
2022-01-28 20:08 ` [PATCH v5 07/10] lib: test_hmm add module param for " Alex Sierra
2022-01-28 20:08   ` Alex Sierra
2022-01-28 20:08 ` [PATCH v5 08/10] lib: add support for device coherent type in test_hmm Alex Sierra
2022-01-28 20:08   ` Alex Sierra
2022-01-28 20:08 ` [PATCH v5 09/10] tools: update hmm-test to support device coherent type Alex Sierra
2022-01-28 20:08   ` Alex Sierra
2022-01-31 23:27   ` Sierra Guiza, Alejandro (Alex)
2022-01-31 23:27     ` Sierra Guiza, Alejandro (Alex)
2022-01-31 23:37     ` Alistair Popple
2022-01-31 23:37       ` Alistair Popple
2022-01-28 20:08 ` [PATCH v5 10/10] tools: update test_hmm script to support SP config Alex Sierra
2022-01-28 20:08   ` Alex Sierra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220128200825.8623-4-alex.sierra@amd.com \
    --to=alex.sierra@amd.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=apopple@nvidia.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hch@lst.de \
    --cc=jgg@nvidia.com \
    --cc=jglisse@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=rcampbell@nvidia.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.