From: Dmitry Osipenko <digetx@gmail.com>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Russell King" <linux@armlinux.org.uk>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>, "Guo Ren" <guoren@kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Greg Ungerer" <gerg@linux-m68k.org>,
"Joshua Thompson" <funaho@jurai.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Sebastian Reichel" <sre@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Greentime Hu" <green.hu@gmail.com>,
"Vincent Chen" <deanbo422@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Helge Deller" <deller@gmx.de>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Rich Felker" <dalias@libc.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Juergen Gross" <jgross@suse.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>, "Pavel Machek" <pavel@ucw.cz>,
"Lee Jones" <lee.jones@linaro.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
alankao@andestech.com,
"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org,
linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: [PATCH v6 18/21] memory: emif: Use kernel_can_power_off()
Date: Mon, 31 Jan 2022 02:37:15 +0300 [thread overview]
Message-ID: <20220130233718.21544-19-digetx@gmail.com> (raw)
In-Reply-To: <20220130233718.21544-1-digetx@gmail.com>
Replace legacy pm_power_off with kernel_can_power_off() helper that
is aware about chained power-off handlers.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/memory/emif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 762d0c0f0716..cab10d5274a0 100644
--- a/drivers/memory/emif.c
+++ b/drivers/memory/emif.c
@@ -630,7 +630,7 @@ static irqreturn_t emif_threaded_isr(int irq, void *dev_id)
dev_emerg(emif->dev, "SDRAM temperature exceeds operating limit.. Needs shut down!!!\n");
/* If we have Power OFF ability, use it, else try restarting */
- if (pm_power_off) {
+ if (kernel_can_power_off()) {
kernel_power_off();
} else {
WARN(1, "FIXME: NO pm_power_off!!! trying restart\n");
--
2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Russell King" <linux@armlinux.org.uk>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>, "Guo Ren" <guoren@kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Greg Ungerer" <gerg@linux-m68k.org>,
"Joshua Thompson" <funaho@jurai.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Sebastian Reichel" <sre@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Greentime Hu" <green.hu@gmail.com>,
"Vincent Chen" <deanbo422@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Helge Deller" <deller@gmx.de>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Rich Felker" <dalias@libc.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Juergen Gross" <jgross@suse.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>, "Pavel Machek" <pavel@ucw.cz>,
"Lee Jones" <lee.jones@linaro.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
alankao@andestech.com,
"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org,
linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: [PATCH v6 18/21] memory: emif: Use kernel_can_power_off()
Date: Mon, 31 Jan 2022 02:37:15 +0300 [thread overview]
Message-ID: <20220130233718.21544-19-digetx@gmail.com> (raw)
In-Reply-To: <20220130233718.21544-1-digetx@gmail.com>
Replace legacy pm_power_off with kernel_can_power_off() helper that
is aware about chained power-off handlers.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/memory/emif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 762d0c0f0716..cab10d5274a0 100644
--- a/drivers/memory/emif.c
+++ b/drivers/memory/emif.c
@@ -630,7 +630,7 @@ static irqreturn_t emif_threaded_isr(int irq, void *dev_id)
dev_emerg(emif->dev, "SDRAM temperature exceeds operating limit.. Needs shut down!!!\n");
/* If we have Power OFF ability, use it, else try restarting */
- if (pm_power_off) {
+ if (kernel_can_power_off()) {
kernel_power_off();
} else {
WARN(1, "FIXME: NO pm_power_off!!! trying restart\n");
--
2.34.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Russell King" <linux@armlinux.org.uk>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>, "Guo Ren" <guoren@kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Greg Ungerer" <gerg@linux-m68k.org>,
"Joshua Thompson" <funaho@jurai.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Sebastian Reichel" <sre@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Greentime Hu" <green.hu@gmail.com>,
"Vincent Chen" <deanbo422@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Helge Deller" <deller@gmx.de>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Rich Felker" <dalias@libc.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Juergen Gross" <jgross@suse.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>, "Pavel Machek" <pavel@ucw.cz>,
"Lee Jones" <lee.jones@linaro.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
alankao@andestech.com,
"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org,
linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: [PATCH v6 18/21] memory: emif: Use kernel_can_power_off()
Date: Sun, 30 Jan 2022 23:37:15 +0000 [thread overview]
Message-ID: <20220130233718.21544-19-digetx@gmail.com> (raw)
In-Reply-To: <20220130233718.21544-1-digetx@gmail.com>
Replace legacy pm_power_off with kernel_can_power_off() helper that
is aware about chained power-off handlers.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/memory/emif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 762d0c0f0716..cab10d5274a0 100644
--- a/drivers/memory/emif.c
+++ b/drivers/memory/emif.c
@@ -630,7 +630,7 @@ static irqreturn_t emif_threaded_isr(int irq, void *dev_id)
dev_emerg(emif->dev, "SDRAM temperature exceeds operating limit.. Needs shut down!!!\n");
/* If we have Power OFF ability, use it, else try restarting */
- if (pm_power_off) {
+ if (kernel_can_power_off()) {
kernel_power_off();
} else {
WARN(1, "FIXME: NO pm_power_off!!! trying restart\n");
--
2.34.1
next prev parent reply other threads:[~2022-01-30 23:39 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 23:36 [PATCH v6 00/21] Introduce power-off+restart call chain API Dmitry Osipenko
2022-01-30 23:36 ` Dmitry Osipenko
2022-01-30 23:36 ` Dmitry Osipenko
2022-01-30 23:36 ` [PATCH v6 01/21] notifier: Add blocking_notifier_call_chain_is_empty() Dmitry Osipenko
2022-01-30 23:36 ` Dmitry Osipenko
2022-01-30 23:36 ` Dmitry Osipenko
2022-01-30 23:36 ` [PATCH v6 02/21] notifier: Add atomic/blocking_notifier_chain_register_unique_prio() Dmitry Osipenko
2022-01-30 23:36 ` Dmitry Osipenko
2022-01-30 23:36 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 03/21] reboot: Print error message if restart handler has duplicated priority Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 04/21] kernel: Add combined power-off+restart handler call chain API Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 05/21] ARM: Use do_kernel_power_off() Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 06/21] csky: " Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 07/21] riscv: " Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 08/21] arm64: " Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 09/21] parisc: " Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 10/21] xen/x86: " Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 11/21] powerpc: " Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 12/21] m68k: Switch to new sys-off handler API Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 13/21] sh: Use do_kernel_power_off() Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 14/21] x86: " Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 15/21] ia64: " Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 16/21] mips: " Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-02-21 14:42 ` Thomas Bogendoerfer
2022-02-21 14:42 ` Thomas Bogendoerfer
2022-02-21 14:42 ` Thomas Bogendoerfer
2022-01-30 23:37 ` [PATCH v6 17/21] nds32: " Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko [this message]
2022-01-30 23:37 ` [PATCH v6 18/21] memory: emif: Use kernel_can_power_off() Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-31 9:28 ` Krzysztof Kozlowski
2022-01-31 9:28 ` Krzysztof Kozlowski
2022-01-31 9:28 ` Krzysztof Kozlowski
2022-01-30 23:37 ` [PATCH v6 19/21] ACPI: power: Switch to sys-off handler API Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 20/21] regulator: pfuze100: Use devm_register_sys_off_handler() Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` [PATCH v6 21/21] reboot: Remove pm_power_off_prepare() Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-01-30 23:37 ` Dmitry Osipenko
2022-02-15 22:00 ` [PATCH v6 00/21] Introduce power-off+restart call chain API Dmitry Osipenko
2022-02-15 22:00 ` Dmitry Osipenko
2022-02-15 22:00 ` Dmitry Osipenko
2022-02-16 12:25 ` Rafael J. Wysocki
2022-02-16 12:25 ` Rafael J. Wysocki
2022-02-16 12:25 ` Rafael J. Wysocki
2022-02-16 20:30 ` Helge Deller
2022-02-16 20:30 ` Helge Deller
2022-02-16 20:30 ` Helge Deller
2022-02-17 10:12 ` Dmitry Osipenko
2022-02-17 10:12 ` Dmitry Osipenko
2022-02-17 10:12 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220130233718.21544-19-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=alankao@andestech.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=benh@kernel.crashing.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dalias@libc.org \
--cc=daniel.lezcano@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=deanbo422@gmail.com \
--cc=deller@gmx.de \
--cc=funaho@jurai.org \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=green.hu@gmail.com \
--cc=guoren@kernel.org \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jonathanh@nvidia.com \
--cc=kclin@andestech.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=lenb@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mpe@ellerman.id.au \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulus@samba.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=sre@kernel.org \
--cc=ssantosh@kernel.org \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=tsbogend@alpha.franken.de \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.