All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Anderson <dianders@chromium.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: pmaliset@codeaurora.org, mka@chromium.org,
	quic_rjendra@quicinc.com,
	Shaik Sajida Bhanu <sbhanu@codeaurora.org>,
	kgodara@codeaurora.org, konrad.dybcio@somainline.org,
	Sankeerth Billakanti <quic_sbillaka@quicinc.com>,
	sibis@codeaurora.org, swboyd@chromium.org,
	Douglas Anderson <dianders@chromium.org>,
	Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 07/14] arm64: dts: qcom: sc7280: Add edp_out port and HPD lines
Date: Wed,  2 Feb 2022 13:23:41 -0800	[thread overview]
Message-ID: <20220202132301.v3.7.Ic84bb69c45be2fccf50e3bd17b845fe20eec624c@changeid> (raw)
In-Reply-To: <20220202212348.1391534-1-dianders@chromium.org>

Like dp_out, we should have defined edp_out in sc7280.dtsi so we don't
need to do this in the board files.

Like dp_hot_plug_det, we should define edp_hot_plug_det in
sc7280.dtsi.

We should set the default pinctrl for edp_hot_plug_det in
sc7280.dtsi. NOTE: this is _unlike_ the dp_hot_plug_det. It is
reasonable that in some boards the dedicated DP Hot Plug Detect will
not be hooked up in favor of Type C mechanisms. This is unlike eDP
where the Hot Plug Detect line (which functions as "panel ready" in
eDP) is highly likely to be used by boards.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

Changes in v3:
- ("Add edp_out port and HPD lines") new for v3.

 arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 4d5892411a38..3f9837921c17 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -3010,6 +3010,8 @@ mdss_dsi_phy: phy@ae94400 {
 
 			mdss_edp: edp@aea0000 {
 				compatible = "qcom,sc7280-edp";
+				pinctrl-names = "default";
+				pinctrl-0 = <&edp_hot_plug_det>;
 
 				reg = <0 0xaea0000 0 0x200>,
 				      <0 0xaea0200 0 0x200>,
@@ -3052,12 +3054,18 @@ mdss_edp: edp@aea0000 {
 				ports {
 					#address-cells = <1>;
 					#size-cells = <0>;
+
 					port@0 {
 						reg = <0>;
 						edp_in: endpoint {
 							remote-endpoint = <&dpu_intf5_out>;
 						};
 					};
+
+					port@1 {
+						reg = <1>;
+						edp_out: endpoint { };
+					};
 				};
 
 				edp_opp_table: opp-table {
@@ -3277,6 +3285,11 @@ dp_hot_plug_det: dp-hot-plug-det {
 				bias-disable;
 			};
 
+			edp_hot_plug_det: edp-hot-plug-det {
+				pins = "gpio60";
+				function = "edp_hot";
+			};
+
 			pcie1_clkreq_n: pcie1-clkreq-n {
 				pins = "gpio79";
 				function = "pcie1_clkreqn";
-- 
2.35.0.rc2.247.g8bbb082509-goog


  parent reply	other threads:[~2022-02-02 21:24 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-02 21:23 [PATCH v3 00/14] arm64: dts: qcom: sc7x80: A smattering of misc dts cleanups + herobrine-rev1 Douglas Anderson
2022-02-02 21:23 ` [PATCH v3 01/14] arm64: dts: qcom: sc7180-trogdor: Add "-regulator" suffix to pp3300_hub Douglas Anderson
2022-02-03 21:24   ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 02/14] arm64: dts: qcom: sc7280-herobrine: Consistently add "-regulator" suffix Douglas Anderson
2022-02-03 21:24   ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 03/14] arm64: dts: qcom: sc7280: Properly sort sdc pinctrl lines Douglas Anderson
2022-02-03 21:24   ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 04/14] arm64: dts: qcom: sc7280: Clean up sdc1 / sdc2 pinctrl Douglas Anderson
2022-02-02 22:42   ` Matthias Kaehlcke
2022-02-03 21:28   ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 05/14] arm64: dts: qcom: sc7280-idp: No need for "input-enable" on sw_ctrl Douglas Anderson
2022-02-03 21:28   ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 06/14] arm64: dts: qcom: sc7280: Fix sort order of dp_hot_plug_det / pcie1_clkreq_n Douglas Anderson
2022-02-02 22:45   ` Matthias Kaehlcke
2022-02-03 21:28   ` Stephen Boyd
2022-02-02 21:23 ` Douglas Anderson [this message]
2022-02-02 22:51   ` [PATCH v3 07/14] arm64: dts: qcom: sc7280: Add edp_out port and HPD lines Matthias Kaehlcke
2022-02-03 21:30   ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 08/14] arm64: dts: qcom: sc7280: Move pcie1_clkreq pull / drive str to boards Douglas Anderson
2022-02-03 17:07   ` Matthias Kaehlcke
2022-02-03 21:30   ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 09/14] arm64: dts: qcom: sc7280: Disable pull from pcie1_clkreq Douglas Anderson
2022-02-03 17:20   ` Matthias Kaehlcke
2022-02-03 21:42   ` Stephen Boyd
2022-02-03 21:53     ` Doug Anderson
2022-02-03 21:59       ` Stephen Boyd
2022-02-03 23:42         ` Doug Anderson
2022-02-02 21:23 ` [PATCH v3 10/14] arm64: dts: qcom: sc7280: Move dp_hot_plug_det pull from SoC dtsi file Douglas Anderson
2022-02-03 17:22   ` Matthias Kaehlcke
2022-02-03 21:42   ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 11/14] arm64: dts: qcom: sc7280: Add a blank line in the dp node Douglas Anderson
2022-02-03 17:26   ` Matthias Kaehlcke
2022-02-03 21:42   ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 12/14] arm64: dts: qcom: sc7280: Add herobrine-r1 Douglas Anderson
2022-02-03 18:05   ` Matthias Kaehlcke
2022-02-03 23:26   ` Doug Anderson
2022-02-04 22:14     ` Doug Anderson
2022-02-02 21:23 ` [PATCH v3 13/14] arm64: dts: qcom: sc7280: Add the CPU compatible to the soc@0 node Douglas Anderson
2022-02-03 21:44   ` Stephen Boyd
2022-02-04 21:51   ` Bjorn Andersson
2022-02-05  2:59     ` Stephen Boyd
2022-02-02 21:23 ` [PATCH v3 14/14] arm64: dts: qcom: sc7280: Remove "qcom,sc7280" from top-level of boards Douglas Anderson
2022-02-03 21:45   ` Stephen Boyd
2022-02-04 21:54 ` (subset) [PATCH v3 00/14] arm64: dts: qcom: sc7x80: A smattering of misc dts cleanups + herobrine-rev1 Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220202132301.v3.7.Ic84bb69c45be2fccf50e3bd17b845fe20eec624c@changeid \
    --to=dianders@chromium.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kgodara@codeaurora.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=pmaliset@codeaurora.org \
    --cc=quic_rjendra@quicinc.com \
    --cc=quic_sbillaka@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=sbhanu@codeaurora.org \
    --cc=sibis@codeaurora.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.