All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jan Harkes <jaharkes@cs.cmu.edu>,
	coda@cs.cmu.edu, Paul Moore <paul@paul-moore.com>,
	Eric Paris <eparis@redhat.com>,
	Balbir Singh <bsingharora@gmail.com>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, codalist@coda.cs.cmu.edu,
	linux-audit@redhat.com
Cc: Leo Yan <leo.yan@linaro.org>, Richard Guy Briggs <rgb@redhat.com>
Subject: [PATCH v4 4/5] audit: Use task_is_in_init_pid_ns()
Date: Fri,  4 Feb 2022 21:50:50 +0800	[thread overview]
Message-ID: <20220204135051.60639-5-leo.yan@linaro.org> (raw)
In-Reply-To: <20220204135051.60639-1-leo.yan@linaro.org>

Replace open code with task_is_in_init_pid_ns() for checking root PID
namespace.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Balbir Singh <bsingharora@gmail.com>
Acked-by: Paul Moore <paul@paul-moore.com>
Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
---
 kernel/audit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/audit.c b/kernel/audit.c
index 7690c29d4ee4..4dfa58865d9a 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -1056,7 +1056,7 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 msg_type)
 	case AUDIT_MAKE_EQUIV:
 		/* Only support auditd and auditctl in initial pid namespace
 		 * for now. */
-		if (task_active_pid_ns(current) != &init_pid_ns)
+		if (!task_is_in_init_pid_ns(current))
 			return -EPERM;
 
 		if (!netlink_capable(skb, CAP_AUDIT_CONTROL))
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Leo Yan <leo.yan@linaro.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jan Harkes <jaharkes@cs.cmu.edu>,
	coda@cs.cmu.edu, Paul Moore <paul@paul-moore.com>,
	Eric Paris <eparis@redhat.com>,
	Balbir Singh <bsingharora@gmail.com>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, codalist@coda.cs.cmu.edu,
	linux-audit@redhat.com
Cc: Leo Yan <leo.yan@linaro.org>, Richard Guy Briggs <rgb@redhat.com>
Subject: [PATCH v4 4/5] audit: Use task_is_in_init_pid_ns()
Date: Fri,  4 Feb 2022 21:50:50 +0800	[thread overview]
Message-ID: <20220204135051.60639-5-leo.yan@linaro.org> (raw)
In-Reply-To: <20220204135051.60639-1-leo.yan@linaro.org>

Replace open code with task_is_in_init_pid_ns() for checking root PID
namespace.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Balbir Singh <bsingharora@gmail.com>
Acked-by: Paul Moore <paul@paul-moore.com>
Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
---
 kernel/audit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/audit.c b/kernel/audit.c
index 7690c29d4ee4..4dfa58865d9a 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -1056,7 +1056,7 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 msg_type)
 	case AUDIT_MAKE_EQUIV:
 		/* Only support auditd and auditctl in initial pid namespace
 		 * for now. */
-		if (task_active_pid_ns(current) != &init_pid_ns)
+		if (!task_is_in_init_pid_ns(current))
 			return -EPERM;
 
 		if (!netlink_capable(skb, CAP_AUDIT_CONTROL))
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Leo Yan <leo.yan@linaro.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jan Harkes <jaharkes@cs.cmu.edu>,
	coda@cs.cmu.edu, Paul Moore <paul@paul-moore.com>,
	Eric Paris <eparis@redhat.com>,
	Balbir Singh <bsingharora@gmail.com>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu,
	linux-audit@redhat.com
Cc: Richard Guy Briggs <rgb@redhat.com>, Leo Yan <leo.yan@linaro.org>
Subject: [PATCH v4 4/5] audit: Use task_is_in_init_pid_ns()
Date: Fri,  4 Feb 2022 21:50:50 +0800	[thread overview]
Message-ID: <20220204135051.60639-5-leo.yan@linaro.org> (raw)
In-Reply-To: <20220204135051.60639-1-leo.yan@linaro.org>

Replace open code with task_is_in_init_pid_ns() for checking root PID
namespace.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Balbir Singh <bsingharora@gmail.com>
Acked-by: Paul Moore <paul@paul-moore.com>
Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
---
 kernel/audit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/audit.c b/kernel/audit.c
index 7690c29d4ee4..4dfa58865d9a 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -1056,7 +1056,7 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 msg_type)
 	case AUDIT_MAKE_EQUIV:
 		/* Only support auditd and auditctl in initial pid namespace
 		 * for now. */
-		if (task_active_pid_ns(current) != &init_pid_ns)
+		if (!task_is_in_init_pid_ns(current))
 			return -EPERM;
 
 		if (!netlink_capable(skb, CAP_AUDIT_CONTROL))
-- 
2.25.1

--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


  parent reply	other threads:[~2022-02-04 13:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04 13:50 [PATCH v4 0/5] pid: Use helper task_is_in_root_ns() Leo Yan
2022-02-04 13:50 ` Leo Yan
2022-02-04 13:50 ` Leo Yan
2022-02-04 13:50 ` [PATCH v4 1/5] coresight: etm3x: Use task_is_in_init_pid_ns() Leo Yan
2022-02-04 13:50   ` Leo Yan
2022-02-04 13:50   ` Leo Yan
2022-02-04 13:50 ` [PATCH v4 2/5] coresight: etm4x: " Leo Yan
2022-02-04 13:50   ` Leo Yan
2022-02-04 13:50   ` Leo Yan
2022-02-04 13:50 ` [PATCH v4 3/5] coda: " Leo Yan
2022-02-04 13:50   ` Leo Yan
2022-02-04 13:50   ` Leo Yan
2022-02-04 13:50 ` Leo Yan [this message]
2022-02-04 13:50   ` [PATCH v4 4/5] audit: " Leo Yan
2022-02-04 13:50   ` Leo Yan
2022-02-04 13:50 ` [PATCH v4 5/5] taskstats: " Leo Yan
2022-02-04 13:50   ` Leo Yan
2022-02-04 13:50   ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220204135051.60639-5-leo.yan@linaro.org \
    --to=leo.yan@linaro.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bsingharora@gmail.com \
    --cc=coda@cs.cmu.edu \
    --cc=codalist@coda.cs.cmu.edu \
    --cc=coresight@lists.linaro.org \
    --cc=eparis@redhat.com \
    --cc=jaharkes@cs.cmu.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=paul@paul-moore.com \
    --cc=rgb@redhat.com \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.