All of lore.kernel.org
 help / color / mirror / Atom feed
From: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
To: <jikos@kernel.org>, <benjamin.tissoires@redhat.com>,
	<linux-input@vger.kernel.org>, <Nehal-Bakulchandra.shah@amd.com>
Cc: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Subject: [PATCH 1/5] HID: amd_sfh: Handle amd_sfh work buffer in PM ops
Date: Tue, 8 Feb 2022 17:51:08 +0530	[thread overview]
Message-ID: <20220208122112.942471-2-Basavaraj.Natikar@amd.com> (raw)
In-Reply-To: <20220208122112.942471-1-Basavaraj.Natikar@amd.com>

Since in the current amd_sfh design the sensor data is periodically
obtained in the form of poll data, during the suspend/resume cycle,
scheduling a delayed work adds no value.

So, cancel the work and restart back during the suspend/resume cycle
respectively.

Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
---
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
index d3f32ffe299a..dacac30a6b27 100644
--- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
+++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
@@ -290,6 +290,8 @@ static int __maybe_unused amd_mp2_pci_resume(struct device *dev)
 		}
 	}
 
+	schedule_delayed_work(&cl_data->work_buffer, msecs_to_jiffies(AMD_SFH_IDLE_LOOP));
+
 	return 0;
 }
 
@@ -312,6 +314,8 @@ static int __maybe_unused amd_mp2_pci_suspend(struct device *dev)
 		}
 	}
 
+	cancel_delayed_work_sync(&cl_data->work_buffer);
+
 	return 0;
 }
 
-- 
2.25.1


  reply	other threads:[~2022-02-08 13:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08 12:21 [PATCH 0/5] Handle amd_sfh work buffer and interrupts Basavaraj Natikar
2022-02-08 12:21 ` Basavaraj Natikar [this message]
2022-02-08 12:21 ` [PATCH 2/5] HID: amd_sfh: Correct the structure field name Basavaraj Natikar
2022-02-08 12:21 ` [PATCH 3/5] HID: amd_sfh: Disable the interrupt for all command Basavaraj Natikar
2022-02-08 12:21 ` [PATCH 4/5] HID: amd_sfh: Add functionality to clear interrupts Basavaraj Natikar
2022-02-08 12:21 ` [PATCH 5/5] HID: amd_sfh: Add interrupt handler to process interrupts Basavaraj Natikar
2022-02-14 15:29 ` [PATCH 0/5] Handle amd_sfh work buffer and interrupts Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220208122112.942471-2-Basavaraj.Natikar@amd.com \
    --to=basavaraj.natikar@amd.com \
    --cc=Nehal-Bakulchandra.shah@amd.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.