All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: raymond.barbiero.dev@gmail.com
Cc: fstests@vger.kernel.org, jack@suse.cz,
	mgorman@techsingularity.net, dave@stgolabs.net,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 02/25] child: fix usage of gzFile and gzopen()
Date: Wed,  9 Feb 2022 14:25:47 -0800	[thread overview]
Message-ID: <20220209222610.438470-3-mcgrof@kernel.org> (raw)
In-Reply-To: <20220209222610.438470-1-mcgrof@kernel.org>

The code uses gzFile as a pointer, but it is not the
intended design. This works as a pointer works just
as well as the stupid file descriptor. Fix this usage
to shut up gcc compilation warnings and make proper use
of the API.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 child.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/child.c b/child.c
index 7abb238..04bc474 100644
--- a/child.c
+++ b/child.c
@@ -329,7 +329,7 @@ void child_run(struct child_struct *child0, const char *loadfile)
 	char **sparams, **params;
 	char *p;
 	const char *status;
-	gzFile *gzf;
+	gzFile gzf;
 	pid_t parent = getppid();
 	double targett;
 	struct child_struct *child;
@@ -348,7 +348,7 @@ void child_run(struct child_struct *child0, const char *loadfile)
 	}
 
 	gzf = gzopen(loadfile, "r");
-	if (gzf == NULL) {
+	if (!gzf) {
 		perror(loadfile);
 		exit(1);
 	}
-- 
2.34.1


  parent reply	other threads:[~2022-02-09 22:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09 22:25 [PATCH 00/25] dbench: fix compile warnings and update a bit Luis Chamberlain
2022-02-09 22:25 ` [PATCH 01/25] dbench: simplify open_loadfile() as check_loadfile_ok() Luis Chamberlain
2022-02-09 22:25 ` Luis Chamberlain [this message]
2022-02-09 22:25 ` [PATCH 03/25] dbench: remove unused double t value Luis Chamberlain
2022-02-09 22:25 ` [PATCH 04/25] child: fix data type comparison on child_run Luis Chamberlain
2022-02-09 22:25 ` [PATCH 05/25] Makefile.in: disable unused warning for rpc generated code Luis Chamberlain
2022-02-09 22:25 ` [PATCH 06/25] configure.ac: run autoupdate Luis Chamberlain
2022-02-09 22:25 ` [PATCH 07/25] dbench: update use of time.h or sys/time.h Luis Chamberlain
2022-02-09 22:25 ` [PATCH 08/25] config.h.in: run autoconf Luis Chamberlain
2022-02-09 22:25 ` [PATCH 09/25] snprintf: specify safe fallthrough on switches Luis Chamberlain
2022-02-09 22:25 ` [PATCH 10/25] nfsio.c: include dbench.h before nfs.h Luis Chamberlain
2022-02-09 22:25 ` [PATCH 11/25] nfsio: remove unused status variable Luis Chamberlain
2022-02-09 22:25 ` [PATCH 12/25] child: be expicit about string truncation goal Luis Chamberlain
2022-02-09 22:25 ` [PATCH 13/25] child: do not overlap on memcpy() Luis Chamberlain
2022-02-09 22:25 ` [PATCH 14/25] dbench.h: use bits/types.h instead of defining uint32 Luis Chamberlain
2022-02-09 22:26 ` [PATCH 15/25] sockio.c: use uint32_t Luis Chamberlain
2022-02-09 22:26 ` [PATCH 16/25] libnfs.c: fix a few simple compile warnings Luis Chamberlain
2022-02-09 22:26 ` [PATCH 17/25] libnfs: fix compilation warning for inet_tons Luis Chamberlain
2022-02-09 22:26 ` [PATCH 18/25] libnfs.c: fix sign conflict compile warning Luis Chamberlain
2022-02-09 22:26 ` [PATCH 19/25] Makefile.in: Luis Chamberlain
2022-02-09 22:26 ` [PATCH 20/25] linux_scsi.c: fix redeclaration of _GNU_SOURCE Luis Chamberlain
2022-02-09 22:26 ` [PATCH 21/25] Makefile.in: modernize build output with V=1 or V=0 Luis Chamberlain
2022-02-09 22:26 ` [PATCH 22/25] Makefile.in: declare datarootdir Luis Chamberlain
2022-02-09 22:26 ` [PATCH 23/25] configure.ac: fix smbclient detection Luis Chamberlain
2022-02-09 22:26 ` [PATCH 24/25] libiscsi: fix compile warning on data types Luis Chamberlain
2022-02-09 22:26 ` [PATCH 25/25] smb: fix compilation and disable warning on deprecated-declarations Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220209222610.438470-3-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=dave@stgolabs.net \
    --cc=fstests@vger.kernel.org \
    --cc=jack@suse.cz \
    --cc=mgorman@techsingularity.net \
    --cc=raymond.barbiero.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.