All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>,
	linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com,
	Jiri Kosina <jikos@kernel.org>,
	linux-input@vger.kernel.org,
	"Sean O'Brien" <seobrien@chromium.org>,
	Douglas Anderson <dianders@chromium.org>,
	Jiri Kosina <jkosina@suse.cz>
Subject: [PATCH v4 4/4] HID: google: modify HID device groups of eel
Date: Wed, 16 Feb 2022 11:59:01 -0800	[thread overview]
Message-ID: <20220216195901.1326924-5-swboyd@chromium.org> (raw)
In-Reply-To: <20220216195901.1326924-1-swboyd@chromium.org>

From: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>

If HID_GROUP of eel is set to HID_GROUP_GENERIC, Whiskers Tablet Mode
Switch of eel hammer will not be detected by system because the
hid-vivaldi driver probes the device. When it is set to
HID_GROUP_VIVALDI, system will detect Whiskers Tablet Mode Switch
successfully and also support the vivaldi keyboard layout.

Cc: Jiri Kosina <jikos@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Tested-by: "Sean O'Brien" <seobrien@chromium.org>
Cc: Douglas Anderson <dianders@chromium.org>
Acked-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
[swboyd@chromium.org: Expand on commit text]
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
 drivers/hid/hid-google-hammer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
index f8e6dccf6ed8..8c4881796a0c 100644
--- a/drivers/hid/hid-google-hammer.c
+++ b/drivers/hid/hid-google-hammer.c
@@ -636,7 +636,7 @@ static void hammer_remove(struct hid_device *hdev)
 static const struct hid_device_id hammer_devices[] = {
 	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
 		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_DON) },
-	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
+	{ HID_DEVICE(BUS_USB, HID_GROUP_VIVALDI,
 		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_EEL) },
 	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
 		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_HAMMER) },
-- 
https://chromeos.dev


      parent reply	other threads:[~2022-02-16 19:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16 19:58 [PATCH v4 0/4] Input/HID: Consolidate ChromeOS Vivaldi keyboard logic Stephen Boyd
2022-02-16 19:58 ` [PATCH v4 1/4] Input: Extract ChromeOS vivaldi physmap show function Stephen Boyd
2022-02-16 22:23   ` Stephen Boyd
2022-02-28  7:59   ` Dmitry Torokhov
2022-02-16 19:58 ` [PATCH v4 2/4] HID: Extract vivaldi hid feature mapping for use in hid-hammer Stephen Boyd
2022-02-28  8:01   ` Dmitry Torokhov
2022-02-16 19:59 ` [PATCH v4 3/4] HID: google: Add support for vivaldi to hid-hammer Stephen Boyd
2022-02-16 19:59 ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220216195901.1326924-5-swboyd@chromium.org \
    --to=swboyd@chromium.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jikos@kernel.org \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seobrien@chromium.org \
    --cc=xiazhengqiao@huaqin.corp-partner.google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.