All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: linux-clk@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Dongjiu Geng" <gengdongjiu@huawei.com>
Subject: [PATCH v4 3/5] clk: hisilicon: Terminate clk_div_table with sentinel element
Date: Fri, 18 Feb 2022 01:09:19 +0100	[thread overview]
Message-ID: <20220218000922.134857-4-j.neuschaefer@gmx.net> (raw)
In-Reply-To: <20220218000922.134857-1-j.neuschaefer@gmx.net>

In order that the end of a clk_div_table can be detected, it must be
terminated with a sentinel element (.div = 0).

Fixes: 6c81966107dc0 ("clk: hisilicon: Add clock driver for hi3559A SoC")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---

v4:
- add /* sentinel */ comment into sentinel element

v3:
- no changes

v2:
- Add Fixes tag
---
 drivers/clk/hisilicon/clk-hi3559a.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/hisilicon/clk-hi3559a.c b/drivers/clk/hisilicon/clk-hi3559a.c
index 56012a3d02192..9ea1a80acbe8b 100644
--- a/drivers/clk/hisilicon/clk-hi3559a.c
+++ b/drivers/clk/hisilicon/clk-hi3559a.c
@@ -611,8 +611,8 @@ static struct hisi_mux_clock hi3559av100_shub_mux_clks[] = {


 /* shub div clk */
-static struct clk_div_table shub_spi_clk_table[] = {{0, 8}, {1, 4}, {2, 2}};
-static struct clk_div_table shub_uart_div_clk_table[] = {{1, 8}, {2, 4}};
+static struct clk_div_table shub_spi_clk_table[] = {{0, 8}, {1, 4}, {2, 2}, {/*sentinel*/}};
+static struct clk_div_table shub_uart_div_clk_table[] = {{1, 8}, {2, 4}, {/*sentinel*/}};

 static struct hisi_divider_clock hi3559av100_shub_div_clks[] = {
 	{ HI3559AV100_SHUB_SPI_SOURCE_CLK, "clk_spi_clk", "shub_clk", 0, 0x20, 24, 2,
--
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: linux-clk@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Dongjiu Geng" <gengdongjiu@huawei.com>
Subject: [PATCH v4 3/5] clk: hisilicon: Terminate clk_div_table with sentinel element
Date: Fri, 18 Feb 2022 01:09:19 +0100	[thread overview]
Message-ID: <20220218000922.134857-4-j.neuschaefer@gmx.net> (raw)
In-Reply-To: <20220218000922.134857-1-j.neuschaefer@gmx.net>

In order that the end of a clk_div_table can be detected, it must be
terminated with a sentinel element (.div = 0).

Fixes: 6c81966107dc0 ("clk: hisilicon: Add clock driver for hi3559A SoC")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---

v4:
- add /* sentinel */ comment into sentinel element

v3:
- no changes

v2:
- Add Fixes tag
---
 drivers/clk/hisilicon/clk-hi3559a.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/hisilicon/clk-hi3559a.c b/drivers/clk/hisilicon/clk-hi3559a.c
index 56012a3d02192..9ea1a80acbe8b 100644
--- a/drivers/clk/hisilicon/clk-hi3559a.c
+++ b/drivers/clk/hisilicon/clk-hi3559a.c
@@ -611,8 +611,8 @@ static struct hisi_mux_clock hi3559av100_shub_mux_clks[] = {


 /* shub div clk */
-static struct clk_div_table shub_spi_clk_table[] = {{0, 8}, {1, 4}, {2, 2}};
-static struct clk_div_table shub_uart_div_clk_table[] = {{1, 8}, {2, 4}};
+static struct clk_div_table shub_spi_clk_table[] = {{0, 8}, {1, 4}, {2, 2}, {/*sentinel*/}};
+static struct clk_div_table shub_uart_div_clk_table[] = {{1, 8}, {2, 4}, {/*sentinel*/}};

 static struct hisi_divider_clock hi3559av100_shub_div_clks[] = {
 	{ HI3559AV100_SHUB_SPI_SOURCE_CLK, "clk_spi_clk", "shub_clk", 0, 0x20, 24, 2,
--
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-02-18  0:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18  0:09 [PATCH v4 0/5] clk drivers: Terminate clk_div_table with sentinel element Jonathan Neuschäfer
2022-02-18  0:09 ` Jonathan Neuschäfer
2022-02-18  0:09 ` [PATCH v4 1/5] clk: actions: " Jonathan Neuschäfer
2022-02-18  0:09   ` Jonathan Neuschäfer
2022-03-12  2:16   ` Stephen Boyd
2022-03-12  2:16     ` Stephen Boyd
2022-02-18  0:09 ` [PATCH v4 2/5] clk: loongson1: " Jonathan Neuschäfer
2022-02-18  0:09   ` Jonathan Neuschäfer
2022-03-12  2:16   ` Stephen Boyd
2022-03-12  2:16     ` Stephen Boyd
2022-02-18  0:09 ` Jonathan Neuschäfer [this message]
2022-02-18  0:09   ` [PATCH v4 3/5] clk: hisilicon: " Jonathan Neuschäfer
2022-03-12  2:16   ` Stephen Boyd
2022-03-12  2:16     ` Stephen Boyd
2022-02-18  0:09 ` [PATCH v4 4/5] clk: clps711x: " Jonathan Neuschäfer
2022-02-18  0:09   ` Jonathan Neuschäfer
2022-03-12  2:16   ` Stephen Boyd
2022-03-12  2:16     ` Stephen Boyd
2022-02-18  0:09 ` [PATCH v4 5/5] clk: actions: Make sentinel elements more obvious Jonathan Neuschäfer
2022-02-18  0:09   ` Jonathan Neuschäfer
2022-03-12  2:17   ` Stephen Boyd
2022-03-12  2:17     ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220218000922.134857-4-j.neuschaefer@gmx.net \
    --to=j.neuschaefer@gmx.net \
    --cc=f4bug@amsat.org \
    --cc=gengdongjiu@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.