All of lore.kernel.org
 help / color / mirror / Atom feed
From: trondmy@gmail.com
To: linux-nfs@vger.kernel.org
Subject: [PATCH v5 0/6] Readdir improvements
Date: Fri, 18 Feb 2022 16:24:18 -0500	[thread overview]
Message-ID: <20220218212424.1840077-1-trond.myklebust@hammerspace.com> (raw)

From: Trond Myklebust <trond.myklebust@hammerspace.com>

The current NFS readdir code will always try to maximise the amount of
readahead it performs on the assumption that we can cache anything that
isn't immediately read by the process.
There are several cases where this assumption breaks down, including
when the 'ls -l' heuristic kicks in to try to force use of readdirplus
as a batch replacement for lookup/getattr.

--
v2: Remove reset of dtsize when NFS_INO_FORCE_READDIR is set
v3: Avoid excessive window shrinking in uncached_readdir case
v4: Track 'ls -l' cache hit/miss statistics
    Improved algorithm for falling back to uncached readdir
    Skip readdirplus when files are being written to
v5: bugfixes
    Skip readdirplus when the acdirmax/acregmax values are low
    Request a full XDR buffer when doing READDIRPLUS

Trond Myklebust (6):
  NFS: Adjust the amount of readahead performed by NFS readdir
  NFS: Simplify nfs_readdir_xdr_to_array()
  NFS: Improve algorithm for falling back to uncached readdir
  NFS: Improve heuristic for readdirplus
  NFS: Don't ask for readdirplus unless it can help nfs_getattr()
  NFSv4: Ask for a full XDR buffer of readdir goodness

 fs/nfs/dir.c           | 214 +++++++++++++++++++++++++++--------------
 fs/nfs/inode.c         |  37 +++----
 fs/nfs/internal.h      |   4 +-
 fs/nfs/nfs3xdr.c       |   7 +-
 fs/nfs/nfs4xdr.c       |   6 +-
 fs/nfs/nfstrace.h      |   1 -
 include/linux/nfs_fs.h |   7 +-
 7 files changed, 173 insertions(+), 103 deletions(-)

-- 
2.35.1


             reply	other threads:[~2022-02-18 21:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18 21:24 trondmy [this message]
2022-02-18 21:24 ` [PATCH v5 1/6] NFS: Adjust the amount of readahead performed by NFS readdir trondmy
2022-02-18 21:24   ` [PATCH v5 2/6] NFS: Simplify nfs_readdir_xdr_to_array() trondmy
2022-02-18 21:24     ` [PATCH v5 3/6] NFS: Improve algorithm for falling back to uncached readdir trondmy
2022-02-18 21:24       ` [PATCH v5 4/6] NFS: Improve heuristic for readdirplus trondmy
2022-02-18 21:24         ` [PATCH v5 5/6] NFS: Don't ask for readdirplus unless it can help nfs_getattr() trondmy
2022-02-18 21:24           ` [PATCH v5 6/6] NFSv4: Ask for a full XDR buffer of readdir goodness trondmy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220218212424.1840077-1-trond.myklebust@hammerspace.com \
    --to=trondmy@gmail.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.