From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> To: dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Michael Rodin <mrodin@de.adit-jv.com>, michael@rodin.online, efriedrich@de.adit-jv.com, erosca@de.adit-jv.com Subject: [PATCH 0/2] drm: rcar-du: Avoid flicker when enabling a VSP plane Date: Mon, 21 Feb 2022 19:13:38 +0200 [thread overview] Message-ID: <20220221171340.11113-1-laurent.pinchart+renesas@ideasonboard.com> (raw) Hello, This patch series avoids flicker in some scenarios related to dual output configuration. The issue was originally reported by Michael Rodin in [1]. The problem is described in details there, and copied here to facilitate discussion: -------- Restarting a display unit group can cause a visible flicker on the display. Particularly when a LVDS display is connected to a Salvator board and an HDMI display is (re)connected, then there will be 2 visible flickers on the LVDS display: 1. during atomic_flush (The need_restart flag is set in this case by rcar_du_vsp_enable.): rcar_du_crtc_atomic_flush rcar_du_crtc_update_planes ... ... /* Restart the group if plane sources have changed. */ if (rcrtc->group->need_restart) rcar_du_group_restart(rcrtc->group); 2. during atomic_enable: rcar_du_crtc_atomic_enable rcar_du_crtc_start rcar_du_group_start_stop(rcrtc->group, true); To avoid flickers in all use cases, do not restart DU groups on the Gen3 SoCs at all, since it is not required any more. -------- The proposed patch unfortunately introduced a regression. This series fixes the issue in the first scenario described above. The second scenario still leads to flicker, and I don't think that can be fixed as the hardware requires the whole group of outputs to be stopped for some register changes to take effect. [1] https://lore.kernel.org/dri-devel/1637680811-90510-1-git-send-email-mrodin@de.adit-jv.com Laurent Pinchart (2): drm: rcar-du: Don't select VSP1 sink on Gen3 drm: rcar-du: Don't restart group when enabling plane on Gen3 drivers/gpu/drm/rcar-du/rcar_du_plane.c | 12 ++++++++++-- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 9 --------- 2 files changed, 10 insertions(+), 11 deletions(-) -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> To: dri-devel@lists.freedesktop.org Cc: efriedrich@de.adit-jv.com, michael@rodin.online, Michael Rodin <mrodin@de.adit-jv.com>, linux-renesas-soc@vger.kernel.org, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, erosca@de.adit-jv.com Subject: [PATCH 0/2] drm: rcar-du: Avoid flicker when enabling a VSP plane Date: Mon, 21 Feb 2022 19:13:38 +0200 [thread overview] Message-ID: <20220221171340.11113-1-laurent.pinchart+renesas@ideasonboard.com> (raw) Hello, This patch series avoids flicker in some scenarios related to dual output configuration. The issue was originally reported by Michael Rodin in [1]. The problem is described in details there, and copied here to facilitate discussion: -------- Restarting a display unit group can cause a visible flicker on the display. Particularly when a LVDS display is connected to a Salvator board and an HDMI display is (re)connected, then there will be 2 visible flickers on the LVDS display: 1. during atomic_flush (The need_restart flag is set in this case by rcar_du_vsp_enable.): rcar_du_crtc_atomic_flush rcar_du_crtc_update_planes ... ... /* Restart the group if plane sources have changed. */ if (rcrtc->group->need_restart) rcar_du_group_restart(rcrtc->group); 2. during atomic_enable: rcar_du_crtc_atomic_enable rcar_du_crtc_start rcar_du_group_start_stop(rcrtc->group, true); To avoid flickers in all use cases, do not restart DU groups on the Gen3 SoCs at all, since it is not required any more. -------- The proposed patch unfortunately introduced a regression. This series fixes the issue in the first scenario described above. The second scenario still leads to flicker, and I don't think that can be fixed as the hardware requires the whole group of outputs to be stopped for some register changes to take effect. [1] https://lore.kernel.org/dri-devel/1637680811-90510-1-git-send-email-mrodin@de.adit-jv.com Laurent Pinchart (2): drm: rcar-du: Don't select VSP1 sink on Gen3 drm: rcar-du: Don't restart group when enabling plane on Gen3 drivers/gpu/drm/rcar-du/rcar_du_plane.c | 12 ++++++++++-- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 9 --------- 2 files changed, 10 insertions(+), 11 deletions(-) -- Regards, Laurent Pinchart
next reply other threads:[~2022-02-21 17:13 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-21 17:13 Laurent Pinchart [this message] 2022-02-21 17:13 ` [PATCH 0/2] drm: rcar-du: Avoid flicker when enabling a VSP plane Laurent Pinchart 2022-02-21 17:13 ` [PATCH 1/2] drm: rcar-du: Don't select VSP1 sink on Gen3 Laurent Pinchart 2022-02-21 17:13 ` Laurent Pinchart 2022-03-03 11:58 ` Kieran Bingham 2022-03-03 11:58 ` Kieran Bingham 2022-02-21 17:13 ` [PATCH 2/2] drm: rcar-du: Don't restart group when enabling plane " Laurent Pinchart 2022-02-21 17:13 ` Laurent Pinchart 2022-03-03 12:00 ` Kieran Bingham 2022-03-03 12:00 ` Kieran Bingham
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220221171340.11113-1-laurent.pinchart+renesas@ideasonboard.com \ --to=laurent.pinchart+renesas@ideasonboard.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=efriedrich@de.adit-jv.com \ --cc=erosca@de.adit-jv.com \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=michael@rodin.online \ --cc=mrodin@de.adit-jv.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.