All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shubham Mishra <shivam828787@gmail.com>
To: git@vger.kernel.org
Cc: me@ttaylorr.com, Shubham Mishra <shivam828787@gmail.com>
Subject: [PATCH 2/2] t0003: remove pipes
Date: Tue, 22 Feb 2022 17:13:13 +0530	[thread overview]
Message-ID: <20220222114313.14921-3-shivam828787@gmail.com> (raw)
In-Reply-To: <20220222114313.14921-1-shivam828787@gmail.com>

pipes doesn't care about error codes and ignore them thus we should not use them in tests.
As an easy alternative, I am using a tmp file to write from git command so we can test the exit code.

Signed-off-by: Shubham Mishra <shivam828787@gmail.com>
---
 t/t0003-attributes.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/t/t0003-attributes.sh b/t/t0003-attributes.sh
index b9ed612af1..51f9f6503c 100755
--- a/t/t0003-attributes.sh
+++ b/t/t0003-attributes.sh
@@ -205,15 +205,15 @@ test_expect_success 'attribute test: read paths from stdin' '
 test_expect_success 'attribute test: --all option' '
 	grep -v unspecified <expect-all | sort >specified-all &&
 	sed -e "s/:.*//" <expect-all | uniq >stdin-all &&
-	git check-attr --stdin --all <stdin-all | sort >actual &&
+	git check-attr --stdin --all <stdin-all >tmp && sort tmp >actual &&
 	test_cmp specified-all actual
 '
 
 test_expect_success 'attribute test: --cached option' '
-	git check-attr --cached --stdin --all <stdin-all | sort >actual &&
+	git check-attr --cached --stdin --all <stdin-all >tmp && sort tmp >actual &&
 	test_must_be_empty actual &&
 	git add .gitattributes a/.gitattributes a/b/.gitattributes &&
-	git check-attr --cached --stdin --all <stdin-all | sort >actual &&
+	git check-attr --cached --stdin --all <stdin-all >tmp && sort tmp >actual &&
 	test_cmp specified-all actual
 '
 
-- 
2.25.1


  parent reply	other threads:[~2022-02-22 11:43 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22 11:43 [PATCH 0/2] microproject: avoid using pipes in test Shubham Mishra
2022-02-22 11:43 ` [PATCH 1/2] t0001: remove pipes Shubham Mishra
2022-02-22 13:54   ` Derrick Stolee
2022-02-22 18:16     ` Shubham Mishra
2022-02-22 20:32   ` Christian Couder
2022-02-23 21:07     ` Junio C Hamano
2022-02-24  3:28       ` Christian Couder
2022-02-22 11:43 ` Shubham Mishra [this message]
2022-02-22 13:50 ` [PATCH 0/2] microproject: avoid using pipes in test Derrick Stolee
2022-02-22 14:24 ` Ævar Arnfjörð Bjarmason
2022-02-22 19:12   ` Shubham Mishra
2022-02-22 19:39   ` Taylor Blau
2022-02-23 11:53 ` [PATCH v2 0/2] avoid pipes with Git on LHS Shubham Mishra
2022-02-23 11:53   ` [PATCH v2 1/2] t0001: " Shubham Mishra
2022-02-23 17:53     ` Taylor Blau
2022-02-23 18:01       ` Shubham Mishra
2022-02-23 18:02         ` Taylor Blau
2022-02-23 21:10     ` Junio C Hamano
2022-02-24  5:14       ` Shubham Mishra
2022-02-23 11:53   ` [PATCH v2 2/2] t0003: " Shubham Mishra
2022-02-23 17:54     ` Taylor Blau
2022-02-23 19:59       ` Shubham Mishra
2022-02-23 12:08   ` [PATCH v2 0/2] " Shubham Mishra
2022-02-23 13:19     ` Shaoxuan Yuan
2022-02-23 18:01       ` Taylor Blau
2022-02-23 20:04         ` Shubham Mishra
2022-02-24  3:43 ` [PATCH 0/2] microproject: avoid using pipes in test Christian Couder
2022-02-24  5:22   ` Shubham Mishra
2022-02-24  9:29     ` Christian Couder
2022-02-24 10:13       ` Shubham Mishra
2022-02-24 18:22         ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220222114313.14921-3-shivam828787@gmail.com \
    --to=shivam828787@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.