All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: broonie@kernel.org
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
	pierre-louis.bossart@linux.intel.com,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	quic_srivasam@quicinc.com,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [PATCH v2 1/9] ASoC: codecs: rx-macro: fix accessing compander for aux
Date: Tue, 22 Feb 2022 18:32:04 +0000	[thread overview]
Message-ID: <20220222183212.11580-2-srinivas.kandagatla@linaro.org> (raw)
In-Reply-To: <20220222183212.11580-1-srinivas.kandagatla@linaro.org>

AUX interpolator does not have compander, so check before accessing
compander data for this.

Without this checkan array of out bounds access will be made in
comp_enabled[] array.

Fixes: 4f692926f562 ("ASoC: codecs: lpass-rx-macro: add dapm widgets and route")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 sound/soc/codecs/lpass-rx-macro.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c
index 2b272a82eabf..32e85d2e9b90 100644
--- a/sound/soc/codecs/lpass-rx-macro.c
+++ b/sound/soc/codecs/lpass-rx-macro.c
@@ -2039,6 +2039,10 @@ static int rx_macro_load_compander_coeff(struct snd_soc_component *component,
 	int i;
 	int hph_pwr_mode;
 
+	/* AUX does not have compander */
+	if (comp == INTERP_AUX)
+		return 0;
+
 	if (!rx->comp_enabled[comp])
 		return 0;
 
-- 
2.21.0


WARNING: multiple messages have this Message-ID (diff)
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: broonie@kernel.org
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
	linux-kernel@vger.kernel.org,
	pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	quic_srivasam@quicinc.com
Subject: [PATCH v2 1/9] ASoC: codecs: rx-macro: fix accessing compander for aux
Date: Tue, 22 Feb 2022 18:32:04 +0000	[thread overview]
Message-ID: <20220222183212.11580-2-srinivas.kandagatla@linaro.org> (raw)
In-Reply-To: <20220222183212.11580-1-srinivas.kandagatla@linaro.org>

AUX interpolator does not have compander, so check before accessing
compander data for this.

Without this checkan array of out bounds access will be made in
comp_enabled[] array.

Fixes: 4f692926f562 ("ASoC: codecs: lpass-rx-macro: add dapm widgets and route")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 sound/soc/codecs/lpass-rx-macro.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c
index 2b272a82eabf..32e85d2e9b90 100644
--- a/sound/soc/codecs/lpass-rx-macro.c
+++ b/sound/soc/codecs/lpass-rx-macro.c
@@ -2039,6 +2039,10 @@ static int rx_macro_load_compander_coeff(struct snd_soc_component *component,
 	int i;
 	int hph_pwr_mode;
 
+	/* AUX does not have compander */
+	if (comp == INTERP_AUX)
+		return 0;
+
 	if (!rx->comp_enabled[comp])
 		return 0;
 
-- 
2.21.0


  reply	other threads:[~2022-02-22 18:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22 18:32 [PATCH v2 0/9] ASoC: codecs: qcom fix validation failures Srinivas Kandagatla
2022-02-22 18:32 ` Srinivas Kandagatla
2022-02-22 18:32 ` Srinivas Kandagatla [this message]
2022-02-22 18:32   ` [PATCH v2 1/9] ASoC: codecs: rx-macro: fix accessing compander for aux Srinivas Kandagatla
2022-02-22 18:32 ` [PATCH v2 2/9] ASoC: codecs: rx-macro: fix accessing array out of bounds for enum type Srinivas Kandagatla
2022-02-22 18:32   ` Srinivas Kandagatla
2022-02-22 18:32 ` [PATCH v2 3/9] ASoC: codecs: tx-macro: " Srinivas Kandagatla
2022-02-22 18:32   ` Srinivas Kandagatla
2022-02-22 18:45   ` Mark Brown
2022-02-22 18:45     ` Mark Brown
2022-02-22 18:32 ` [PATCH v2 4/9] ASoC: codecs: va-macro: " Srinivas Kandagatla
2022-02-22 18:32   ` Srinivas Kandagatla
2022-02-22 18:32 ` [PATCH v2 5/9] ASoC: codecs: wsa-macro: " Srinivas Kandagatla
2022-02-22 18:32   ` Srinivas Kandagatla
2022-02-22 18:32 ` [PATCH v2 6/9] ASoC: codecs: wc938x: " Srinivas Kandagatla
2022-02-22 18:32   ` Srinivas Kandagatla
2022-02-22 18:32 ` [PATCH v2 7/9] ASoC: codecs: wcd938x: fix kcontrol max values Srinivas Kandagatla
2022-02-22 18:32   ` Srinivas Kandagatla
2022-02-22 18:32 ` [PATCH v2 8/9] ASoC: codecs: wcd934x: " Srinivas Kandagatla
2022-02-22 18:32   ` Srinivas Kandagatla
2022-02-22 18:32 ` [PATCH v2 9/9] ASoC: codecs: wcd934x: fix return value of wcd934x_rx_hph_mode_put Srinivas Kandagatla
2022-02-22 18:32   ` Srinivas Kandagatla
2022-02-23  4:08 ` (subset) [PATCH v2 0/9] ASoC: codecs: qcom fix validation failures Mark Brown
2022-02-23  4:08   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220222183212.11580-2-srinivas.kandagatla@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=quic_srivasam@quicinc.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.